Import ResponderEventPlugin changes from RN #5308
Conversation
|
👍 assuming you do a quick check to make sure this doesn't break anything. Doesn't looks like it should… |
|
Ugh, the tests for this in RN aren't running. Kicking this down the road… |
|
@spicyj updated the pull request. |
|
This imports the ResponderEventPlugin.js changes made in facebook/react-native@a0168a8 and facebook/react-native@5c1ac2a. Notably, the changes in the latter diff by @andreicoman11 (internally D2163934) required changes to ResponderEventPlugin-test (which sadly doesn't run in the RN repo) to match its the new behavior. In particular, this now calls responderGrant before calling responderTerminationRequest, whereas it should call responderTerminationRequest first and not dispatch the responderGrant event if responderTerminationRequest returns false. I am going to commit this changed test because it matches the current behavior that RN has been using since August – but this at least deviates from the original intended behavior of ResponderEventPlugin and may be worth revisiting so that responderGrant is one again called at the right times. cc interested parties @vjeux @kmagiera @jordwalke |
Import ResponderEventPlugin changes from RN
This imports the ResponderEventPlugin.js changes made in facebook/react-native@a0168a8 and facebook/react-native@5c1ac2a and updates tests to match.