Improve error message when mounting non-string/function elements #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Invariant Violation: Element type is invalid: expected a string (for ' + | ||
| 'built-in components) or a class/function (for composite components) ' + | ||
| 'but got: object.' | ||
| ); |
There was a problem hiding this comment.
Want to add one of these testamajiggers for the addendum?
There was a problem hiding this comment.
I have a secret test already in src/isomorphic/classic/element/__tests__/ReactElementValidator-test.js…
sophiebits
added a commit
that referenced
this pull request
Jun 17, 2015
Improve error message when mounting non-string/function elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People keep getting tripped up by the nonsense error you currently get and manage not to see the warning. See #3478. I think this check is cheap enough. (We also have a warning at element creation time, which is more useful if you notice it.)