Give the user a warning when using unoptimized JSX code #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user to the correct location in the documentation to optimize.
|
Yeah - can you imagine if people thought it was okay to compile JSX inside of the browser! Awesome. Not sure the markdown anchor belongs in this PR though? |
| @@ -20,7 +20,7 @@ We provide CDN-hosted versions of React [on our download page](/react/downloads. | |||
|
|
|||
| We have instructions for building from `master` [in our GitHub repository](https://github.com/facebook/react). We build a tree of CommonJS modules under `build/modules` which you can drop into any environment or packaging tool that supports CommonJS. | |||
|
|
|||
| ## JSX | |||
| ## <a id="jsx"></a>JSX | |||
There was a problem hiding this comment.
Like @jordwalke said, I'm going to figure this out in a separate diff. But good call.
|
💥 Thanks! |
zpao
added a commit
that referenced
this pull request
Sep 19, 2013
Give the user a warning when using unoptimized JSX code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in: https://groups.google.com/forum/#!topic/reactjs/5anr4Oxs8tA
Implemented it for all the situations whereby text/jsx is used - not just synchronous loading as discussed in the group conversation.