Warn when rendering directly into document.body #3211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in response to facebook#3207 to address concerns regarding third-party scripts and browser plugins potentially altering DOM nodes within document.body, causing problems with reconciliation.
| container !== document.body, | ||
| 'render(): Rendering components directly into document.body is ' + | ||
| 'discouraged, since its children are often manipulated by third party' + | ||
| 'scripts and browser extensions. This may lead to subtle reconciliation' + |
There was a problem hiding this comment.
missing a space after "reconciliation"
|
@spicyj thanks for the help, just pushed two more commits to address your concerns. Let me know if there's anything else I can do here. |
|
Looks good, thanks – will merge after we release 0.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #3207 to address concerns regarding third-party
scripts and browser plugins potentially altering DOM nodes within
document.body, causing problems with reconciliation.