[tests] fix hidden use() warnings #31984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Jan 5, 2025
| @@ -561,6 +577,7 @@ describe('ReactUse', () => { | |||
| 'triggered by `use`, wrap your component in a error boundary.', | |||
| ); | |||
| } | |||
| console.error.mockRestore(); | |||
There was a problem hiding this comment.
If you don't restore the mock at the end of a test using spyOnDev, all tests after it will have the console errors silenced and break the toErrorDev / assertConsoleErrorDev tests.
This quick fix isn't the best either because if this test fails, the mock won't restore so test after it will fail even though they pass. The best would be to restore in an afterEach in setupTests.js, but that will fail a bunch of tests so I'll follow up with that.
|
Comparing: 03e4ec2...247b671 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
force-pushed
the
rh/fix-react-use-warnings
branch
from
83dec33 to
e4e412b
Compare
rickhanlonii
force-pushed
the
rh/fix-react-use-warnings
branch
from
11db179 to
f67863c
Compare
kassens
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spyOnDevis such a footgun.