[assert helpers] ReactChildren-test #31844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Dec 18, 2024
| ' See https://react.dev/link/warning-keys for more information.\n' + | ||
| ' in div (at **)\n' + | ||
| ' in **/ReactChildren-test.js:**:** (at **)\n' + | ||
| ' in **/ReactChildren.js:**:** (at **)\n' + |
There was a problem hiding this comment.
@sebmarkbage another example of the file path thing
|
Comparing: 8f92ea4...b3ee936 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
force-pushed
the
rh/asserts/reactchildren
branch
from
2c653b8 to
ab11da2
Compare
rickhanlonii
force-pushed
the
rh/asserts/reactchildren
branch
from
ab11da2 to
5981201
Compare
Comment on lines
+984
to
+991
| await act(() => { | ||
| root.render( | ||
| <ComponentRenderingClonedChildren> | ||
| <div /> | ||
| <div /> | ||
| </ComponentRenderingClonedChildren>, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
this doesn't error anymore?
| <div /> | ||
| </ComponentRenderingMappedChildren>, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
no error here anymore?
There was a problem hiding this comment.
Yeah it's confusing but the toErrorDev() helper is a console.error, and since the array was empty it means there were no console errors. The assert helpers throw if a test ends with un-asserted logs, so no assertion is needed.
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 19, 2024
Based off facebook#31843 Commit to review: facebook@2c653b8 Moar tests DiffTrain build for [36d15d5](facebook@36d15d5)
rickhanlonii
added a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #31843
Commit to review: 2c653b8
Moar tests