Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #31840 in sync-nextjs-14 #31842

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Dec 18, 2024

cherry-picks #31840 into the base version of React in latest Next.js 14 release

Copy link

vercel bot commented Dec 18, 2024

@sebmarkbage is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 18, 2024
…f reportGlobalError (facebook#31840)

We might have already resolved models that are not pending and so are
not rejected by aborting the stream. When those later get parsed they
might discover new chunks which end up as pending. These should be
errored since they will never be able to resolve later.

This avoids infinitely hanging the stream.

This same fix needs to be ported to ReactFlightClient that has the same
issue.
@gnoff gnoff force-pushed the cherry-pick-closed-encode-fix branch from 292441f to 5ad0221 Compare December 18, 2024 21:31
@gnoff gnoff merged commit 178c267 into facebook:sync-nextjs-14 Dec 18, 2024
3 of 4 checks passed
ztanner added a commit to vercel/next.js that referenced this pull request Dec 19, 2024
Updates React from 14898b6a9 to 178c267a4e.

### React upstream changes

- facebook/react#31842
- facebook/react#31841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants