Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flags] Delete enableSchedulerDebugger #31826

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[flags] Delete enableSchedulerDebugger #31826

merged 1 commit into from
Dec 18, 2024

Conversation

rickhanlonii
Copy link
Member

The tool for this isn't used so I killed it internally and we can clean up the code to make it easier to reduce the scheduler code.

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:19pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 17, 2024
@rickhanlonii rickhanlonii force-pushed the rh/rm-ff-scheduler-debugger branch from 2987d7a to 3ab781a Compare December 17, 2024 23:18
rickhanlonii
rickhanlonii commented Dec 17, 2024
View reviewed changes
packages/scheduler/src/forks/Scheduler.js
@@ -606,9 +583,6 @@ export {
unstable_getCurrentPriorityLevel,
shouldYieldToHost as unstable_shouldYield,
requestPaint as unstable_requestPaint,
unstable_continueExecution,
unstable_pauseExecution,
unstable_getFirstCallbackNode,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if it's ok to delete these methods or if we should keep them around as noops, seems like something you would have an opinion on @acdlite

@react-sizebot
Copy link

Comparing: facec3e...38c2927

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.22% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.71 kB 510.71 kB = 91.28 kB 91.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.16% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.86 kB 516.86 kB = 92.24 kB 92.24 kB
facebook-www/ReactDOM-prod.classic.js = 592.42 kB 592.42 kB = 104.37 kB 104.38 kB
facebook-www/ReactDOM-prod.modern.js = 582.68 kB 582.68 kB = 102.82 kB 102.82 kB
oss-stable-semver/scheduler/cjs/scheduler.development.js = 12.43 kB 12.14 kB = 2.74 kB 2.68 kB
oss-stable/scheduler/cjs/scheduler.development.js = 12.43 kB 12.14 kB = 2.74 kB 2.68 kB
oss-experimental/scheduler/cjs/scheduler.development.js = 12.23 kB 11.95 kB = 2.69 kB 2.64 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js = 12.20 kB 11.91 kB = 2.67 kB 2.61 kB
facebook-www/Scheduler-profiling.classic.js = 11.05 kB 10.79 kB = 2.73 kB 2.67 kB
facebook-www/Scheduler-profiling.modern.js = 11.05 kB 10.79 kB = 2.73 kB 2.67 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js = 10.87 kB 10.61 kB = 2.67 kB 2.61 kB
facebook-www/Scheduler-prod.classic.js = 10.62 kB 10.36 kB = 2.63 kB 2.57 kB
facebook-www/Scheduler-prod.modern.js = 10.62 kB 10.36 kB = 2.63 kB 2.57 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.development.js = 14.03 kB 13.69 kB = 2.97 kB 2.92 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_mock.development.js = 14.03 kB 13.69 kB = 2.97 kB 2.92 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.development.js = 14.03 kB 13.69 kB = 2.97 kB 2.92 kB
facebook-react-native/scheduler/cjs/SchedulerMock-dev.js = 13.98 kB 13.64 kB = 2.93 kB 2.89 kB
oss-stable-semver/scheduler/cjs/scheduler.production.js = 10.44 kB 10.18 kB = 2.57 kB 2.51 kB
oss-stable/scheduler/cjs/scheduler.production.js = 10.44 kB 10.18 kB = 2.57 kB 2.51 kB
facebook-react-native/scheduler/cjs/Scheduler-prod.js = 10.44 kB 10.18 kB = 2.57 kB 2.51 kB
facebook-www/SchedulerMock-prod.classic.js = 12.35 kB 12.04 kB = 2.91 kB 2.86 kB
facebook-www/SchedulerMock-prod.modern.js = 12.35 kB 12.04 kB = 2.91 kB 2.86 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.production.js = 12.30 kB 11.99 kB = 2.87 kB 2.83 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_mock.production.js = 12.30 kB 11.99 kB = 2.87 kB 2.83 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.production.js = 12.30 kB 11.99 kB = 2.87 kB 2.83 kB
oss-experimental/scheduler/cjs/scheduler.production.js = 10.31 kB 10.05 kB = 2.52 kB 2.46 kB
facebook-react-native/scheduler/cjs/SchedulerMock-prod.js = 12.28 kB 11.97 kB = 2.86 kB 2.82 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task.development.js = 4.83 kB 4.64 kB = 1.22 kB 1.19 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_post_task.development.js = 4.83 kB 4.64 kB = 1.22 kB 1.19 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task.development.js = 4.83 kB 4.64 kB = 1.22 kB 1.19 kB
facebook-www/SchedulerPostTask-dev.classic.js = 4.81 kB 4.62 kB = 1.21 kB 1.17 kB
facebook-www/SchedulerPostTask-dev.modern.js = 4.81 kB 4.62 kB = 1.21 kB 1.17 kB
facebook-www/SchedulerPostTask-prod.classic.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
facebook-www/SchedulerPostTask-prod.modern.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
facebook-www/SchedulerPostTask-profiling.classic.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
facebook-www/SchedulerPostTask-profiling.modern.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task.production.js = 4.15 kB 3.97 kB = 1.15 kB 1.12 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_post_task.production.js = 4.15 kB 3.97 kB = 1.15 kB 1.12 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task.production.js = 4.15 kB 3.97 kB = 1.15 kB 1.12 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/scheduler/cjs/scheduler.native.development.js = 12.51 kB 12.33 kB = 2.58 kB 2.55 kB
oss-stable/scheduler/cjs/scheduler.native.development.js = 12.51 kB 12.33 kB = 2.58 kB 2.55 kB
oss-experimental/scheduler/cjs/scheduler.native.development.js = 12.32 kB 12.14 kB = 2.54 kB 2.51 kB
oss-stable-semver/scheduler/cjs/scheduler.native.production.js = 11.04 kB 10.87 kB = 2.48 kB 2.45 kB
oss-stable/scheduler/cjs/scheduler.native.production.js = 11.04 kB 10.87 kB = 2.48 kB 2.45 kB
oss-experimental/scheduler/cjs/scheduler.native.production.js = 10.96 kB 10.79 kB = 2.46 kB 2.43 kB
facebook-www/Scheduler-dev.classic.js = 16.12 kB 15.84 kB = 3.44 kB 3.39 kB
facebook-www/Scheduler-dev.modern.js = 16.12 kB 15.84 kB = 3.44 kB 3.39 kB
facebook-www/SchedulerMock-dev.classic.js = 17.42 kB 17.07 kB = 3.65 kB 3.60 kB
facebook-www/SchedulerMock-dev.modern.js = 17.42 kB 17.07 kB = 3.65 kB 3.60 kB
oss-stable-semver/scheduler/cjs/scheduler.development.js = 12.43 kB 12.14 kB = 2.74 kB 2.68 kB
oss-stable/scheduler/cjs/scheduler.development.js = 12.43 kB 12.14 kB = 2.74 kB 2.68 kB
oss-experimental/scheduler/cjs/scheduler.development.js = 12.23 kB 11.95 kB = 2.69 kB 2.64 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js = 12.20 kB 11.91 kB = 2.67 kB 2.61 kB
facebook-www/Scheduler-profiling.classic.js = 11.05 kB 10.79 kB = 2.73 kB 2.67 kB
facebook-www/Scheduler-profiling.modern.js = 11.05 kB 10.79 kB = 2.73 kB 2.67 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js = 10.87 kB 10.61 kB = 2.67 kB 2.61 kB
facebook-www/Scheduler-prod.classic.js = 10.62 kB 10.36 kB = 2.63 kB 2.57 kB
facebook-www/Scheduler-prod.modern.js = 10.62 kB 10.36 kB = 2.63 kB 2.57 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.development.js = 14.03 kB 13.69 kB = 2.97 kB 2.92 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_mock.development.js = 14.03 kB 13.69 kB = 2.97 kB 2.92 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.development.js = 14.03 kB 13.69 kB = 2.97 kB 2.92 kB
facebook-react-native/scheduler/cjs/SchedulerMock-dev.js = 13.98 kB 13.64 kB = 2.93 kB 2.89 kB
oss-stable-semver/scheduler/cjs/scheduler.production.js = 10.44 kB 10.18 kB = 2.57 kB 2.51 kB
oss-stable/scheduler/cjs/scheduler.production.js = 10.44 kB 10.18 kB = 2.57 kB 2.51 kB
facebook-react-native/scheduler/cjs/Scheduler-prod.js = 10.44 kB 10.18 kB = 2.57 kB 2.51 kB
facebook-www/SchedulerMock-prod.classic.js = 12.35 kB 12.04 kB = 2.91 kB 2.86 kB
facebook-www/SchedulerMock-prod.modern.js = 12.35 kB 12.04 kB = 2.91 kB 2.86 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.production.js = 12.30 kB 11.99 kB = 2.87 kB 2.83 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_mock.production.js = 12.30 kB 11.99 kB = 2.87 kB 2.83 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.production.js = 12.30 kB 11.99 kB = 2.87 kB 2.83 kB
oss-experimental/scheduler/cjs/scheduler.production.js = 10.31 kB 10.05 kB = 2.52 kB 2.46 kB
facebook-react-native/scheduler/cjs/SchedulerMock-prod.js = 12.28 kB 11.97 kB = 2.86 kB 2.82 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task.development.js = 4.83 kB 4.64 kB = 1.22 kB 1.19 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_post_task.development.js = 4.83 kB 4.64 kB = 1.22 kB 1.19 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task.development.js = 4.83 kB 4.64 kB = 1.22 kB 1.19 kB
facebook-www/SchedulerPostTask-dev.classic.js = 4.81 kB 4.62 kB = 1.21 kB 1.17 kB
facebook-www/SchedulerPostTask-dev.modern.js = 4.81 kB 4.62 kB = 1.21 kB 1.17 kB
facebook-www/SchedulerPostTask-prod.classic.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
facebook-www/SchedulerPostTask-prod.modern.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
facebook-www/SchedulerPostTask-profiling.classic.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
facebook-www/SchedulerPostTask-profiling.modern.js = 4.16 kB 3.98 kB = 1.16 kB 1.13 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task.production.js = 4.15 kB 3.97 kB = 1.15 kB 1.12 kB
oss-stable-semver/scheduler/cjs/scheduler-unstable_post_task.production.js = 4.15 kB 3.97 kB = 1.15 kB 1.12 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task.production.js = 4.15 kB 3.97 kB = 1.15 kB 1.12 kB

Generated by 🚫 dangerJS against 3ab781a

@rickhanlonii rickhanlonii merged commit 1e9ef39 into facebook:main Dec 18, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-scheduler-debugger branch December 18, 2024 18:29
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@rickhanlonii
[flags] Delete enableSchedulerDebugger (#31826)
9c3a23a 
The tool for this isn't used so I killed it internally and we can clean
up the code to make it easier to reduce the scheduler code.

DiffTrain build for [1e9ef39](1e9ef39)
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@rickhanlonii
[flags] Delete enableSchedulerDebugger (#31826)
82d7548 
The tool for this isn't used so I killed it internally and we can clean
up the code to make it easier to reduce the scheduler code.

DiffTrain build for [1e9ef39](1e9ef39)
This was referenced Dec 18, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @sebmarkbage @facebook-github-bot