Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disableIEWorkarounds #31756

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

rickhanlonii
Copy link
Member

Based off #31755

This is landed everywhere.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:45pm

@react-sizebot
Copy link

react-sizebot commented Dec 13, 2024

Comparing: 17ca4b1...882748c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.72 kB 510.72 kB = 91.37 kB 91.37 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.63 kB 515.63 kB = 92.07 kB 92.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.55 kB 595.55 kB = 105.06 kB 105.06 kB
facebook-www/ReactDOM-prod.modern.js = 585.82 kB 585.82 kB = 103.49 kB 103.49 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js = 63.39 kB 63.03 kB = 15.81 kB 15.69 kB

Generated by 🚫 dangerJS against 89d7493

Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up!

Just check lints for some unused imports now and there's a second cleanup commit that somehow got into this PR. consoleManagedByDevToolsDuringStrictMode

@rickhanlonii rickhanlonii force-pushed the rh/rm-ff-ie-workarounds branch from 441804f to 5961888 Compare December 13, 2024 16:03
@@ -50,7 +49,6 @@ import {
} from './ReactDOMTextarea';
import {validateTextNesting} from './validateDOMNesting';
import {track} from './inputValueTracking';
import setInnerHTML from './setInnerHTML';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also delete setInnerHTML now, so I removed it in this diff.

@rickhanlonii rickhanlonii merged commit fb12845 into facebook:main Dec 13, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-ie-workarounds branch December 13, 2024 17:26
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
Based off #31755

This is landed everywhere.

DiffTrain build for [fb12845](fb12845)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
Based off #31755

This is landed everywhere.

DiffTrain build for [fb12845](fb12845)
rickhanlonii added a commit that referenced this pull request Dec 13, 2024
Based on #31756

This is landed everywhere
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
Based on #31756

This is landed everywhere

DiffTrain build for [ef63718](ef63718)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
Based on #31756

This is landed everywhere

DiffTrain build for [ef63718](ef63718)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 13, 2024
Based off facebook#31755

This is landed everywhere.

DiffTrain build for [fb12845](facebook@fb12845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants