Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight Parcel] Align with more recent changes #31741

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[Flight Parcel] Align with more recent changes #31741

merged 4 commits into from
Dec 12, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Dec 12, 2024 •
edited
Loading

Follow up to #31725.

I diffed against the Turbopack one to find any unexpected discrepancies. Some parts are forked enough that it's hard to diff but I think I got most of it.

@sebmarkbage sebmarkbage requested a review from gnoff December 12, 2024 05:37
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 5:45am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 12, 2024
@sebmarkbage
Move ReactFlightClientConfigBundlerParcel to the client folder
33d5755 
Aligns with the others.
@sebmarkbage
Inject Parcel Flight Client into DevTools
135d09d 
This ensures that owner stacks can be printed for log replaying.
@react-sizebot
Copy link

Comparing: ca58742...4e917d7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.76 kB 510.76 kB = 91.41 kB 91.41 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.69 kB 515.69 kB = 92.12 kB 92.12 kB
facebook-www/ReactDOM-prod.classic.js = 595.61 kB 595.61 kB = 105.12 kB 105.12 kB
facebook-www/ReactDOM-prod.modern.js = 585.88 kB 585.88 kB = 103.55 kB 103.55 kB
oss-experimental/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-experimental/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-experimental/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-experimental/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-stable-rc/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-stable-rc/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-stable-rc/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-stable-rc/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-stable-semver/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-stable-semver/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-stable-semver/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-stable/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-stable/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-stable/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-stable/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-experimental/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-stable-rc/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-stable-semver/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-stable/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-experimental/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-stable/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-experimental/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-experimental/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-experimental/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-stable-rc/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-stable-rc/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-stable-rc/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-stable-rc/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-stable-semver/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-stable-semver/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-stable-semver/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-stable/react-server-dom-parcel/static.browser.js +∞% 0.00 kB 0.32 kB +∞% 0.00 kB 0.19 kB
oss-stable/react-server-dom-parcel/static.edge.js +∞% 0.00 kB 0.31 kB +∞% 0.00 kB 0.18 kB
oss-stable/react-server-dom-parcel/static.js +∞% 0.00 kB 0.19 kB +∞% 0.00 kB 0.16 kB
oss-stable/react-server-dom-parcel/static.node.js +∞% 0.00 kB 0.35 kB +∞% 0.00 kB 0.20 kB
oss-experimental/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-stable-rc/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-stable-semver/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-stable/react-server-dom-parcel/server.node.js +207.32% 0.25 kB 0.76 kB +87.97% 0.16 kB 0.30 kB
oss-experimental/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-stable/react-server-dom-parcel/server.edge.js +184.15% 0.25 kB 0.70 kB +80.50% 0.16 kB 0.29 kB
oss-experimental/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable-semver/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable/react-server-dom-parcel/server.browser.js +179.76% 0.25 kB 0.71 kB +79.50% 0.16 kB 0.29 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js +1.60% 84.25 kB 85.60 kB +0.78% 17.74 kB 17.87 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js +1.60% 84.25 kB 85.60 kB +0.78% 17.74 kB 17.87 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js +1.60% 84.25 kB 85.60 kB +0.78% 17.74 kB 17.87 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +1.60% 84.61 kB 85.96 kB +0.81% 17.83 kB 17.97 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +1.60% 84.61 kB 85.96 kB +0.81% 17.83 kB 17.97 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +1.60% 84.61 kB 85.96 kB +0.81% 17.83 kB 17.97 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js +1.57% 87.72 kB 89.09 kB +1.34% 18.37 kB 18.62 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js +1.57% 87.72 kB 89.09 kB +1.34% 18.37 kB 18.62 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js +1.57% 87.72 kB 89.09 kB +1.34% 18.37 kB 18.62 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +1.25% 132.71 kB 134.38 kB +1.01% 24.89 kB 25.14 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +1.25% 132.71 kB 134.38 kB +1.01% 24.89 kB 25.14 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +1.25% 132.71 kB 134.38 kB +1.01% 24.89 kB 25.14 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +1.23% 128.81 kB 130.39 kB +0.40% 24.22 kB 24.32 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +1.23% 128.81 kB 130.39 kB +0.40% 24.22 kB 24.32 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +1.23% 128.81 kB 130.39 kB +0.40% 24.22 kB 24.32 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +1.21% 130.26 kB 131.84 kB +0.40% 24.48 kB 24.58 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +1.21% 130.26 kB 131.84 kB +0.40% 24.48 kB 24.58 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +1.21% 130.26 kB 131.84 kB +0.40% 24.48 kB 24.58 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +1.03% 86.97 kB 87.86 kB +1.98% 16.29 kB 16.61 kB
oss-stable-rc/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.98% 86.97 kB 87.82 kB +1.84% 16.29 kB 16.59 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.98% 86.97 kB 87.82 kB +1.84% 16.29 kB 16.59 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.79% 95.28 kB 96.03 kB +1.61% 17.84 kB 18.13 kB

Generated by 🚫 dangerJS against 135d09d

@sebmarkbage sebmarkbage merged commit 130095f into facebook:main Dec 12, 2024
187 checks passed
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @gnoff @facebook-github-bot