Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Color and badge non-primary environments #31738

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Dec 12, 2024

Stacked on #31737.

Screenshot 2024-12-11 at 8 41 15 PM

When mixing environments (like "use cache" or third party RSC) it's useful to color and badge those components differently to differentiate.

I'm not putting them in separate tracks because when they do actually execute, like cache misses or third party RSCs, they behave like they're part of the same tree.

@sebmarkbage sebmarkbage requested review from gnoff and eps1lon December 12, 2024 01:44
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 6:19pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 12, 2024
@sebmarkbage sebmarkbage force-pushed the flightenvcolor branch 2 times, most recently from ff997f3 to 492ac59 Compare December 12, 2024 01:47
@react-sizebot
Copy link

react-sizebot commented Dec 12, 2024

Comparing: bdf1871...aca1898

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.76 kB 510.76 kB = 91.36 kB 91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.55 kB 515.55 kB = 92.17 kB 92.17 kB
facebook-www/ReactDOM-prod.classic.js = 592.44 kB 592.44 kB = 104.43 kB 104.43 kB
facebook-www/ReactDOM-prod.modern.js = 582.70 kB 582.70 kB = 102.88 kB 102.87 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.50% 102.40 kB 102.91 kB +0.54% 19.40 kB 19.51 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.49% 102.52 kB 103.03 kB +0.55% 19.57 kB 19.68 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +0.49% 103.84 kB 104.35 kB +0.52% 19.32 kB 19.42 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.48% 104.71 kB 105.21 kB +0.53% 19.96 kB 20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.48% 105.01 kB 105.52 kB +0.54% 19.96 kB 20.07 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.48% 105.26 kB 105.77 kB +0.54% 20.09 kB 20.20 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.48% 106.62 kB 107.13 kB +0.51% 20.28 kB 20.39 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.47% 106.81 kB 107.32 kB +0.53% 20.30 kB 20.41 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.46% 109.26 kB 109.76 kB +0.53% 20.75 kB 20.86 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.46% 111.00 kB 111.51 kB +0.59% 21.08 kB 21.20 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.46% 111.09 kB 111.60 kB +0.59% 21.11 kB 21.24 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.45% 112.00 kB 112.51 kB +0.50% 21.02 kB 21.12 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.45% 113.33 kB 113.84 kB +0.52% 21.27 kB 21.38 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.26% 142.83 kB 143.20 kB +0.28% 33.52 kB 33.62 kB

Generated by 🚫 dangerJS against 09ea57d

Copy link
Collaborator

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider as an alternative to use the env as a prefix instead of a suffix? This would align it with replayed logs, and avoid two successive brackets, e.g. [Cache] ServerComponent [deduped] vs. ServerComponent [Cache] [deduped].

@sebmarkbage
Copy link
Collaborator Author

This is aligning with the React DevTools tree view where it's after.

@sebmarkbage sebmarkbage merged commit 54e86bd into facebook:main Dec 16, 2024
187 checks passed
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc

* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
  [flags] Clean up scheduler flags (facebook#31814)
  Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (facebook#31761)
  Enable disableDefaultPropsExceptForClasses (facebook#31804)
  Turn on useModernStrictMode in test renderers (facebook#31769)
  [compiler][ez] Add shape for global Object.keys (facebook#31583)
  [compiler] Context variables as dependencies (facebook#31582)
  [compiler] Add fire to known React APIs (facebook#31795)
  [compiler] Add option for firing effect functions (facebook#31794)
  [compiler][be] Logger based debug printing in test runner (facebook#31809)
  [compiler][ez] Clean up duplicate code in propagateScopeDeps (facebook#31581)
  [compiler] Repro for aliased captures within inner function expressions (facebook#31770)
  [compiler][be] Playground now compiles entire program (facebook#31774)
  [Flight] Color and badge non-primary environments (facebook#31738)
  [Flight] Emit Deduped Server Components Marker (facebook#31737)
  [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (facebook#31736)
  Clean up context access profiling experiment (facebook#31806)
  [Flight] Stack Parallel Components in Separate Tracks (facebook#31735)
  Flag for requestPaint (facebook#31805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants