[Flight] Track Timing Information #31716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
flighttimings
branch
from
ba1b688 to
208d67e
Compare
This provides us a relative time to emit timestamps against for cross environment transfer. This allows for a bit more compact representation and preserves floating point precision in subsequent timestamps.
This excludes simply outlined tasks.
sebmarkbage
force-pushed
the
flighttimings
branch
from
f9fc19f to
6616ffe
Compare
eps1lon
approved these changes
Dec 10, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #31715.
This adds profiling data for Server Components to the RSC stream (but doesn't yet use it for anything). This is on behind
enableProfilerTimerwhich is on for Dev and Profiling builds. However, for now there's no Profiling build of Flight so in practice only in DEV. It's gated onenableComponentPerformanceTrackwhich is experimental only for now.We first emit a timeOrigin in the beginning of the stream. This provides us a relative time to emit timestamps against for cross environment transfer so that we can log it in terms of absolute times. Using this as a separate field allows the actual relative timestamps to be a bit more compact representation and preserves floating point precision.
We emit a timestamp before emitting a Server Component which represents the start time of the Server Component. The end time is either when the next Server Component starts or when we finish the task.
We omit the end time for simple tasks that are outlined without Server Components.
By encoding this as part of the debugInfo stream, this information can be forwarded between Server to Server RSC.