[compiler] Fix: ref.current now correctly reactive #31521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
mofeiZ
commented
Nov 12, 2024
Comment on lines
+549
to
+552
| maybeDependency = { | ||
| identifier: maybeDependency.identifier, | ||
| path: [], | ||
| }; |
There was a problem hiding this comment.
Now we explicitly downgrade ref.current.a.b dependencies to just ref.
mofeiZ
commented
Nov 12, 2024
Comment on lines
444
to
445
| if (isRefValueType(maybeDependency.identifier)) { | ||
| return false; |
There was a problem hiding this comment.
This is a little weird. Ideally we should take the ref type producing the ref.current read as a dependency, but this seems like an edge case (we don't allow ref.current reads in render anyways).
Happy to turn this into an invariant instead
There was a problem hiding this comment.
yeah interesting. seems worth trying to add an invariant here in a follow-up and see if there's any place it gets hit
mofeiZ
commented
Nov 12, 2024
Comment on lines
+101
to
+102
| (kind: ok) <div>{"cb":{"kind":"Function","result":1},"shouldInvokeFns":true}</div> | ||
| <div>{"cb":{"kind":"Function","result":2},"shouldInvokeFns":true}</div> |
There was a problem hiding this comment.
Note that here, the re-render receives a different ref argument (i.e. ref parameters should be considered reactive)
mofeiZ
commented
Nov 12, 2024
Comment on lines
-32
to
+39
| if ($[0] === Symbol.for("react.memo_cache_sentinel")) { | ||
| if ($[0] !== ref) { | ||
| t0 = () => { | ||
| ref.current = 2; | ||
| }; | ||
| $[0] = ref; | ||
| $[1] = t0; | ||
| } else { | ||
| t0 = $[1]; | ||
| } |
There was a problem hiding this comment.
This is now correct!
mofeiZ
added a commit
that referenced
this pull request
Nov 12, 2024
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31519). * #31521 * __->__ #31519
josephsavona
approved these changes
Nov 12, 2024
Comment on lines
444
to
445
| if (isRefValueType(maybeDependency.identifier)) { | ||
| return false; |
There was a problem hiding this comment.
yeah interesting. seems worth trying to add an invariant here in a follow-up and see if there's any place it gets hit
We were previously filtering out `ref.current` dependencies in propagateScopeDependencies:checkValidDependency`. This is incorrect. Instead, we now always take a dependency on ref values (the outer box) as they may be reactive. Pruning is done in pruneNonReactiveDependencies. This PR includes a small patch to `collectReactiveIdentifier`. Prior to this, we conservatively assumed that pruned scopes always produced reactive declarations. This assumption fixed a bug with non-reactivity, but some of these declarations are `useRef` calls. Now we have special handling for this case ```js // This often produces a pruned scope React.useRef(1); ```
This was referenced Nov 15, 2024
mofeiZ
added a commit
that referenced
this pull request
Nov 15, 2024
…31200) Recursively visit inner function instructions to extract dependencies instead of using `LoweredFunction.dependencies` directly. This is currently gated by enableFunctionDependencyRewrite, which needs to be removed before we delete `LoweredFunction.dependencies` altogether (#31204). Some nice side effects - optional-chaining deps for inner functions - full DCE and outlining for inner functions (see #31202) - fewer extraneous instructions (see #31204) - --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31200). * #31202 * #31203 * #31201 * __->__ #31200 * #31521
mofeiZ
added a commit
that referenced
this pull request
Nov 15, 2024
`JSXMemberExpression` is currently the only instruction (that I know of) that directly references identifier lvalues without a corresponding `LoadLocal`. This has some side effects: - deadcode elimination and constant propagation now reach JSXMemberExpressions - we can delete `LoweredFunction.dependencies` without dangling references (previously, the only reference to JSXMemberExpression objects in HIR was in function dependencies) - JSXMemberExpression now is consistent with all other instructions (e.g. has a rvalue-producing LoadLocal) ' --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31201). * #31202 * #31203 * __->__ #31201 * #31200 * #31521
mofeiZ
added a commit
that referenced
this pull request
Nov 15, 2024
Add more `FIXTURE_ENTRYPOINT`s ' --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31203). * #31202 * __->__ #31203 * #31201 * #31200 * #31521
mofeiZ
added a commit
that referenced
this pull request
Nov 15, 2024
Now that we rely on function context exclusively, let's clean up `HIRFunction.context` after DCE. This PR is in preparation of #31204, which would otherwise have unnecessary declarations (of context values that become entirely DCE'd) ' --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31202). * __->__ #31202 * #31203 * #31201 * #31200 * #31521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously filtering out
ref.currentdependencies in propagateScopeDependencies:checkValidDependency`. This is incorrect.Instead, we now always take a dependency on ref values (the outer box) as they may be reactive. Pruning is done in pruneNonReactiveDependencies.
This PR includes a small patch to
collectReactiveIdentifier. Prior to this, we conservatively assumed that pruned scopes always produced reactive declarations. This assumption fixed a bug with non-reactivity, but some of these declarations areuseRefcalls. Now we have special handling for this caseStack created with Sapling. Best reviewed with ReviewStack.
dependenciesin propagateScopeDeps #31200