Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Re-land] Make prerendering always non-blocking (#31268)" #31355

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jackpope
Copy link
Contributor

This reverts commit 6c4bbc7.

It looked like the bug we found on the original land was related to broken product code. But through landing #31268 we found additional bugs internally. Since disabling the feature flag does not fix the bugs, we have to revert again to unblock the sync. We can continue to debug with our internal build.

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 4:11pm

@react-sizebot
Copy link

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against b001ae3

@jackpope jackpope merged commit cae764c into facebook:main Oct 25, 2024
184 checks passed
@jackpope jackpope deleted the revert-non-blocking-prerendering branch October 25, 2024 16:17
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
…1355)

This reverts commit 6c4bbc7.

It looked like the bug we found on the original land was related to
broken product code. But through landing #31268 we found additional bugs
internally. Since disabling the feature flag does not fix the bugs, we
have to revert again to unblock the sync. We can continue to debug with
our internal build.

DiffTrain build for [cae764c](cae764c)
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
…1355)

This reverts commit 6c4bbc7.

It looked like the bug we found on the original land was related to
broken product code. But through landing #31268 we found additional bugs
internally. Since disabling the feature flag does not fix the bugs, we
have to revert again to unblock the sync. We can continue to debug with
our internal build.

DiffTrain build for [cae764c](cae764c)
acdlite pushed a commit to acdlite/react that referenced this pull request Nov 7, 2024
…book#31268)" (facebook#31355)"

This reverts commit cae764c.


This reverts commit 6c4bbc7.

It looked like the bug we found on the original land was related to
broken product code. But through landing facebook#31268 we found additional bugs
internally. Since disabling the feature flag does not fix the bugs, we
have to revert again to unblock the sync. We can continue to debug with
our internal build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants