Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] handle throwing after abort during render #30730

Merged
merged 1 commit into from
Aug 17, 2024
Merged

[Fizz] handle throwing after abort during render #30730

merged 1 commit into from
Aug 17, 2024

Commits on Aug 16, 2024

  1. [Fizz] handle throwing after abort during render 

    It is possible to throw after aborting during a render and we were not properly tracking this. We use an AbortSigil to mark whether a rendering task needs to abort but the throw interrupts that and we end up handling an error on the error pathway instead.

This change reworks the abort-while-rendering support to be robust to throws after calling abort
    @gnoff
    gnoff committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5bb2101 View commit details
    Browse the repository at this point in the history