Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-dom/server used with Deno #30655

Closed

Conversation

birkskyum
Copy link

@birkskyum birkskyum commented Aug 10, 2024

Repro steps here

I find that when using react-dom with deno (e.g. with Remix), there is an error when serving a build:

Task start remix-serve ./build/server/index.js
error: Uncaught (in promise) SyntaxError: The requested module 'react-dom/server' does not provide an export named 'renderToPipeableStream' at file:///Users/admin/repos/deno-kitchensink/my-remix-app2/build/server/index.js?t=1723290078885:6:10
    at async run (file:///Users/admin/repos/remix-app/node_modules/@remix-run/serve/dist/cli.js:111:15)

It's because the react-dom/server try to use the .browser bundle instead of the .node bundle.

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 0:49am

@facebook-github-bot
Copy link

Hi @birkskyum!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@sebmarkbage
Copy link
Collaborator

This is intentional since Deno favors web streams. You can import react-dom/server.node manually if you have enabled node support and favors using that rather than native web streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants