Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Refactor download-build-artifacts #30484

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 26, 2024

Stack from ghstack (oldest at bottom):

Extracts out the code to download builds from GH into its own module so
that it can be reused later.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 5:21pm

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@react-sizebot
Copy link

react-sizebot commented Jul 26, 2024

Comparing: 1350a85...589e186

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.28 kB 506.28 kB = 90.68 kB 90.68 kB
facebook-www/ReactDOM-prod.classic.js = 601.27 kB 598.90 kB = 106.28 kB 105.77 kB
facebook-www/ReactDOM-prod.modern.js = 577.38 kB 575.01 kB = 102.52 kB 102.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOM-profiling.classic.js = 631.23 kB 628.86 kB = 110.73 kB 110.24 kB
facebook-www/ReactDOMTesting-prod.classic.js = 616.01 kB 613.64 kB = 109.98 kB 109.47 kB
facebook-www/ReactDOM-profiling.modern.js = 606.70 kB 604.34 kB = 106.76 kB 106.29 kB
facebook-www/ReactDOM-prod.classic.js = 601.27 kB 598.90 kB = 106.28 kB 105.77 kB
facebook-www/ReactDOMTesting-prod.modern.js = 592.12 kB 589.76 kB = 106.23 kB 105.73 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,106.31 kB 1,101.84 kB = 186.95 kB 186.23 kB
facebook-www/ReactDOM-prod.modern.js = 577.38 kB 575.01 kB = 102.52 kB 102.01 kB
facebook-www/ReactDOM-dev.classic.js = 1,089.40 kB 1,084.92 kB = 183.00 kB 182.27 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,069.13 kB 1,064.66 kB = 180.36 kB 179.63 kB
facebook-www/ReactDOM-dev.modern.js = 1,052.22 kB 1,047.74 kB = 176.45 kB 175.74 kB
facebook-react-native/react/cjs/React-profiling.js = 19.08 kB 18.99 kB = 4.91 kB 4.89 kB
facebook-react-native/react/cjs/React-prod.js = 18.65 kB 18.56 kB = 4.83 kB 4.80 kB
facebook-www/ReactReconciler-prod.classic.js = 461.89 kB 459.18 kB = 74.68 kB 74.15 kB
facebook-www/ReactReconciler-prod.modern.js = 442.99 kB 440.29 kB = 71.87 kB 71.34 kB
facebook-www/ReactReconciler-dev.classic.js = 741.72 kB 737.01 kB = 118.39 kB 117.69 kB
facebook-www/ReactART-prod.classic.js = 370.65 kB 368.28 kB = 62.82 kB 62.34 kB
facebook-www/ReactReconciler-dev.modern.js = 716.85 kB 712.14 kB = 114.27 kB 113.57 kB
facebook-www/ReactART-prod.modern.js = 353.18 kB 350.81 kB = 60.09 kB 59.58 kB
facebook-www/ReactART-dev.classic.js = 659.17 kB 654.69 kB = 105.76 kB 105.09 kB
facebook-www/ReactART-dev.modern.js = 635.68 kB 631.21 kB = 102.06 kB 101.38 kB
facebook-www/React-dev.classic.js = 74.39 kB 73.80 kB = 16.27 kB 16.19 kB
facebook-www/React-dev.modern.js = 73.53 kB 72.94 kB = 16.13 kB 16.05 kB
facebook-www/React-profiling.classic.js = 22.92 kB 22.61 kB = 5.94 kB 5.87 kB
facebook-www/React-profiling.modern.js = 22.92 kB 22.60 kB = 5.94 kB 5.87 kB
facebook-www/React-prod.classic.js = 22.48 kB 22.17 kB = 5.86 kB 5.79 kB
facebook-www/React-prod.modern.js = 22.48 kB 22.17 kB = 5.86 kB 5.79 kB

Generated by 🚫 dangerJS against e8a6010

@poteto poteto merged commit e8a6010 into gh/poteto/39/base Jul 26, 2024
185 checks passed
poteto added a commit that referenced this pull request Jul 26, 2024
Extracts out the code to download builds from GH into its own module so
that it can be reused later.

ghstack-source-id: 26687db971d06339d099d1d5075825efb82cf6b8
Pull Request resolved: #30484
@poteto poteto deleted the gh/poteto/39/head branch July 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants