Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RN fork of consoleWithStackDev so we can improve the mainline one #30305

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

sebmarkbage
Copy link
Collaborator

We're removing this wrapper from the mainline but RN is still using component stacks to filter out warnings.

This is unfortunate since it'll be hard to keep track of the interplay with these, DevTools and how you're supposed to implement error dialogs in userspace.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 5:29pm

@sebmarkbage sebmarkbage merged commit 9647333 into facebook:main Jul 10, 2024
138 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
…#30305)

We're removing this wrapper from the mainline but RN is still using
component stacks to filter out warnings.

This is unfortunate since it'll be hard to keep track of the interplay
with these, DevTools and how you're supposed to implement error dialogs
in userspace.

DiffTrain build for commit 9647333.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants