Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Provide support for custom fbt-like macro functions #29893

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

josephsavona
Copy link
Contributor

@josephsavona josephsavona commented Jun 14, 2024

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 0:25am

josephsavona added a commit that referenced this pull request Jun 14, 2024
ghstack-source-id: 6c05e7aa20ba8cbd19c932b052ce4c744ed5f07b
Pull Request resolved: #29893
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 14, 2024
const $ = _c(2);
const theme = useTheme();

const t0 = cx({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i verified that without the change (and without the @customMacros(cx) pragma) this fixture assigns cx to a local

Copy link
Contributor

@mofeiZ mofeiZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_soclean!

josephsavona added a commit that referenced this pull request Jun 14, 2024
ghstack-source-id: e3c6455ac2240914c3f25f3266a0cbb4a63971b5
Pull Request resolved: #29893
@react-sizebot
Copy link

react-sizebot commented Jun 14, 2024

Comparing: 2ba462b...8d49249

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.80 kB 497.80 kB = 89.24 kB 89.24 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.62 kB 502.62 kB = 89.94 kB 89.94 kB
facebook-www/ReactDOM-prod.classic.js = 597.04 kB 597.04 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.38 kB 571.38 kB = 101.25 kB 101.25 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 8d49249

@josephsavona josephsavona merged commit 8d49249 into gh/josephsavona/32/base Jun 14, 2024
55 checks passed
josephsavona added a commit that referenced this pull request Jun 14, 2024
ghstack-source-id: e3c6455ac2240914c3f25f3266a0cbb4a63971b5
Pull Request resolved: #29893
@josephsavona josephsavona deleted the gh/josephsavona/32/head branch June 14, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants