Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Eval Fake Server Component Functions to Recreate Native Stacks #29632

Merged
merged 5 commits into from
May 30, 2024
Merged

[Flight] Eval Fake Server Component Functions to Recreate Native Stacks #29632

merged 5 commits into from
May 30, 2024

Commits on May 29, 2024

  1. Create a Fake Server Component function for every stack line 

    This lets the native stack traces include Server Component's stack frames.

This applies to client element's stacks, console replay stacks, and server component's stacks.
    @sebmarkbage
    sebmarkbage committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e4c9b4f View commit details
    Browse the repository at this point in the history

  2. Since we filter the debug stack, we already removed the console wrapper

    @sebmarkbage
    sebmarkbage committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e5296ba View commit details
    Browse the repository at this point in the history

  3. Use (anonymous) as the default name 

    This is because otherwise it ends up being "eval" instead of missing
due to this being in an eval:ed script.
    @sebmarkbage
    sebmarkbage committed May 29, 2024
    Configuration menu
    Copy the full SHA
    11b91f1 View commit details
    Browse the repository at this point in the history

  4. Use "use client" as the task name at the boundary between server/client 

    There should be only one of these if you follow the owner stack.

For host components and built-ins we use the string name since nothing else
will have those as the owner it'll always terminate with those and they
don't have another name.
    @sebmarkbage
    sebmarkbage committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e68e81e View commit details
    Browse the repository at this point in the history

  5. Run in owner task context

    @sebmarkbage
    sebmarkbage committed May 29, 2024
    Configuration menu
    Copy the full SHA
    592ad3f View commit details
    Browse the repository at this point in the history