Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renderToStaticNodeStream #28873

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 19, 2024

Stacked on #28872

renderToStaticNodeStream was not originally deprecated when renderToNodeStream was deprecated because it did not yet have a clear analog in the modern streaming implementation for SSR. In React 19 we have already removed renderToNodeStream. This change removes renderToStaticNodeStream as well because you can replicate it's semantics using renderToPipeableStream with onAllReady or renderToReadableStream with await stream.allready.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 19, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 19, 2024

Comparing: d329ff9...229e7d3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.91 kB 168.91 kB = 52.93 kB 52.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.56 kB 170.56 kB = 53.43 kB 53.44 kB
facebook-www/ReactDOM-prod.classic.js = 590.81 kB 590.81 kB = 103.90 kB 103.90 kB
facebook-www/ReactDOM-prod.modern.js = 566.62 kB 566.62 kB = 100.09 kB 100.09 kB
oss-experimental/react-dom/server.node.js = 0.69 kB 0.63 kB = 0.26 kB 0.26 kB
oss-stable-semver/react-dom/server.node.js = 0.69 kB 0.63 kB = 0.26 kB 0.26 kB
oss-stable/react-dom/server.node.js = 0.69 kB 0.63 kB = 0.26 kB 0.26 kB
oss-experimental/react-dom/server.browser.js = 0.65 kB 0.59 kB = 0.26 kB 0.25 kB
oss-stable-semver/react-dom/server.browser.js = 0.65 kB 0.59 kB = 0.26 kB 0.25 kB
oss-stable/react-dom/server.browser.js = 0.65 kB 0.59 kB = 0.26 kB 0.25 kB
oss-experimental/react-dom/server.edge.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable-semver/react-dom/server.edge.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable/react-dom/server.edge.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-experimental/react-dom/server.bun.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable-semver/react-dom/server.bun.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable/react-dom/server.bun.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
test_utils/ReactAllWarnings.js Deleted 64.71 kB 0.00 kB Deleted 16.19 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js = 85.60 kB 85.40 kB = 26.06 kB 26.00 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.min.js = 80.19 kB 79.99 kB = 24.87 kB 24.81 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.min.js = 80.16 kB 79.96 kB = 24.84 kB 24.78 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 438.47 kB 435.98 kB = 98.55 kB 97.90 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js = 341.34 kB 339.34 kB = 74.89 kB 74.38 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 417.01 kB 414.52 kB = 95.67 kB 95.02 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 416.98 kB 414.50 kB = 95.64 kB 94.99 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.js = 320.32 kB 318.32 kB = 71.96 kB 71.45 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.js = 320.29 kB 318.30 kB = 71.93 kB 71.42 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 88.57 kB 87.82 kB = 27.18 kB 26.91 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 83.25 kB 82.51 kB = 25.97 kB 25.70 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.min.js = 83.23 kB 82.48 kB = 25.94 kB 25.67 kB
oss-experimental/react-dom/server.node.js = 0.69 kB 0.63 kB = 0.26 kB 0.26 kB
oss-stable-semver/react-dom/server.node.js = 0.69 kB 0.63 kB = 0.26 kB 0.26 kB
oss-stable/react-dom/server.node.js = 0.69 kB 0.63 kB = 0.26 kB 0.26 kB
oss-experimental/react-dom/server.browser.js = 0.65 kB 0.59 kB = 0.26 kB 0.25 kB
oss-stable-semver/react-dom/server.browser.js = 0.65 kB 0.59 kB = 0.26 kB 0.25 kB
oss-stable/react-dom/server.browser.js = 0.65 kB 0.59 kB = 0.26 kB 0.25 kB
oss-experimental/react-dom/server.edge.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable-semver/react-dom/server.edge.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable/react-dom/server.edge.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-experimental/react-dom/server.bun.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable-semver/react-dom/server.bun.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
oss-stable/react-dom/server.bun.js = 0.65 kB 0.59 kB = 0.27 kB 0.26 kB
test_utils/ReactAllWarnings.js Deleted 64.71 kB 0.00 kB Deleted 16.19 kB 0.00 kB

Generated by 🚫 dangerJS against 229e7d3

renderToStaticNodeStream was not origianlly deprecated when renderToNodeStream was deprecated because it did not yet have a clear analog in the modern streaming implementation for SSR. In React 19 we have already removed renderToNodeStream. This change remvoes renderToStaticNodeStream as well because you can replicate it's semantics using renderToPipeableStream with onAllReady or renderToReadableStream with await stream.allready.
@gnoff gnoff force-pushed the remove-rendertostaticnodestream branch from a22f189 to 229e7d3 Compare April 19, 2024 01:45
@gnoff gnoff merged commit 33a3244 into facebook:main Apr 19, 2024
38 checks passed
@gnoff gnoff deleted the remove-rendertostaticnodestream branch April 19, 2024 04:06
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
Stacked on #28872

renderToStaticNodeStream was not originally deprecated when
renderToNodeStream was deprecated because it did not yet have a clear
analog in the modern streaming implementation for SSR. In React 19 we
have already removed renderToNodeStream. This change removes
renderToStaticNodeStream as well because you can replicate it's
semantics using renderToPipeableStream with onAllReady or
renderToReadableStream with await stream.allready.

DiffTrain build for [33a3244](33a3244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants