Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SECRET INTERNALS to __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE #28789

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Follow up to #28783 and #28786.

Since we've changed the implementations of these we can rename them to something a bit more descriptive while we're at it, since anyone depending on them will need to upgrade their code anyway.

"react" with no condition: __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE
"react" with "react-server" condition: __SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE
"react-dom": __DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE

@sebmarkbage sebmarkbage requested a review from gnoff April 9, 2024 02:08
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 9, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 9, 2024

Comparing: c771016...8d3a6c9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.01% 168.07 kB 168.09 kB +0.01% 52.57 kB 52.57 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.01% 169.88 kB 169.90 kB +0.02% 53.09 kB 53.10 kB
facebook-www/ReactDOM-prod.classic.js = 589.43 kB 589.45 kB = 103.66 kB 103.67 kB
facebook-www/ReactDOM-prod.modern.js = 565.27 kB 565.29 kB +0.01% 99.86 kB 99.87 kB
oss-experimental/scheduler/umd/scheduler.development.js +6.13% 4.91 kB 5.21 kB +2.39% 0.88 kB 0.90 kB
oss-stable-semver/scheduler/umd/scheduler.development.js +6.13% 4.91 kB 5.21 kB +2.39% 0.88 kB 0.90 kB
oss-stable/scheduler/umd/scheduler.development.js +6.13% 4.91 kB 5.21 kB +2.39% 0.88 kB 0.90 kB
oss-experimental/scheduler/umd/scheduler.production.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-experimental/scheduler/umd/scheduler.profiling.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable-semver/scheduler/umd/scheduler.production.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable-semver/scheduler/umd/scheduler.profiling.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable/scheduler/umd/scheduler.production.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable/scheduler/umd/scheduler.profiling.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
facebook-www/shims/ReactBrowserEventEmitter_DO_NOT_USE.js +5.12% 0.39 kB 0.41 kB +1.81% 0.28 kB 0.28 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js +2.00% 0.65 kB 0.66 kB +1.77% 0.45 kB 0.46 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js +2.00% 0.65 kB 0.66 kB +1.77% 0.45 kB 0.46 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js +2.00% 0.65 kB 0.66 kB +1.77% 0.45 kB 0.46 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/scheduler/umd/scheduler.development.js +6.13% 4.91 kB 5.21 kB +2.39% 0.88 kB 0.90 kB
oss-stable-semver/scheduler/umd/scheduler.development.js +6.13% 4.91 kB 5.21 kB +2.39% 0.88 kB 0.90 kB
oss-stable/scheduler/umd/scheduler.development.js +6.13% 4.91 kB 5.21 kB +2.39% 0.88 kB 0.90 kB
oss-experimental/scheduler/umd/scheduler.production.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-experimental/scheduler/umd/scheduler.profiling.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable-semver/scheduler/umd/scheduler.production.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable-semver/scheduler/umd/scheduler.profiling.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable/scheduler/umd/scheduler.production.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
oss-stable/scheduler/umd/scheduler.profiling.min.js +5.92% 4.65 kB 4.92 kB +2.17% 0.88 kB 0.90 kB
facebook-www/shims/ReactBrowserEventEmitter_DO_NOT_USE.js +5.12% 0.39 kB 0.41 kB +1.81% 0.28 kB 0.28 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js +2.00% 0.65 kB 0.66 kB +1.77% 0.45 kB 0.46 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js +2.00% 0.65 kB 0.66 kB +1.77% 0.45 kB 0.46 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js +2.00% 0.65 kB 0.66 kB +1.77% 0.45 kB 0.46 kB
oss-experimental/react-dom/client.js +1.61% 0.62 kB 0.63 kB +1.74% 0.29 kB 0.29 kB
oss-stable-semver/react-dom/client.js +1.61% 0.62 kB 0.63 kB +1.74% 0.29 kB 0.29 kB
oss-stable/react-dom/client.js +1.61% 0.62 kB 0.63 kB +1.74% 0.29 kB 0.29 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +0.69% 3.36 kB 3.38 kB +0.98% 1.23 kB 1.24 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +0.68% 3.38 kB 3.41 kB +0.80% 1.25 kB 1.26 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +0.68% 3.39 kB 3.41 kB +0.88% 1.25 kB 1.26 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.development.js +0.66% 1.98 kB 1.99 kB +0.77% 1.04 kB 1.04 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js +0.66% 1.98 kB 1.99 kB +0.77% 1.04 kB 1.04 kB
oss-stable/react-dom/cjs/react-dom-test-utils.development.js +0.66% 1.98 kB 1.99 kB +0.77% 1.04 kB 1.04 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +0.66% 3.50 kB 3.52 kB +0.83% 1.33 kB 1.34 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +0.65% 3.53 kB 3.55 kB +0.74% 1.35 kB 1.36 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +0.65% 3.53 kB 3.56 kB +0.74% 1.35 kB 1.36 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.min.js +0.63% 0.95 kB 0.95 kB +0.34% 0.59 kB 0.59 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.min.js +0.63% 0.95 kB 0.95 kB +0.34% 0.59 kB 0.59 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.min.js +0.63% 0.95 kB 0.95 kB +0.34% 0.59 kB 0.59 kB
oss-experimental/react-cache/cjs/react-cache.production.min.js +0.60% 2.17 kB 2.18 kB +0.73% 1.10 kB 1.11 kB
oss-stable-semver/react-cache/cjs/react-cache.production.min.js +0.60% 2.17 kB 2.18 kB +0.73% 1.10 kB 1.11 kB
oss-stable/react-cache/cjs/react-cache.production.min.js +0.60% 2.17 kB 2.18 kB +0.73% 1.10 kB 1.11 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js +0.59% 2.70 kB 2.72 kB +0.31% 0.96 kB 0.96 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js +0.59% 2.70 kB 2.72 kB +0.31% 0.96 kB 0.96 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js +0.59% 2.70 kB 2.72 kB +0.31% 0.96 kB 0.96 kB
oss-experimental/react-dom/umd/react-dom-test-utils.development.js +0.56% 2.33 kB 2.34 kB +0.61% 1.15 kB 1.16 kB
oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js +0.56% 2.33 kB 2.34 kB +0.61% 1.15 kB 1.16 kB
oss-stable/react-dom/umd/react-dom-test-utils.development.js +0.56% 2.33 kB 2.34 kB +0.61% 1.15 kB 1.16 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js +0.48% 2.72 kB 2.73 kB +0.51% 1.18 kB 1.18 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +0.48% 2.72 kB 2.73 kB +0.51% 1.18 kB 1.18 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js +0.47% 2.75 kB 2.77 kB +0.56% 1.25 kB 1.25 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js +0.47% 2.75 kB 2.77 kB +0.56% 1.25 kB 1.25 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js +0.47% 2.75 kB 2.77 kB +0.56% 1.25 kB 1.25 kB
oss-experimental/react-cache/cjs/react-cache.development.js +0.31% 8.52 kB 8.55 kB +0.28% 2.89 kB 2.90 kB
oss-stable-semver/react-cache/cjs/react-cache.development.js +0.31% 8.52 kB 8.55 kB +0.28% 2.89 kB 2.90 kB
oss-stable/react-cache/cjs/react-cache.development.js +0.31% 8.52 kB 8.55 kB +0.28% 2.89 kB 2.90 kB
oss-experimental/react/cjs/react-jsx-runtime.profiling.js +0.25% 5.13 kB 5.14 kB +0.27% 2.25 kB 2.26 kB
oss-stable-semver/react/cjs/react-jsx-runtime.profiling.js +0.25% 5.13 kB 5.14 kB +0.27% 2.25 kB 2.26 kB
oss-stable/react/cjs/react-jsx-runtime.profiling.js +0.25% 5.13 kB 5.14 kB +0.27% 2.25 kB 2.26 kB
oss-experimental/react/cjs/react-jsx-runtime.production.js +0.25% 5.13 kB 5.14 kB +0.27% 2.25 kB 2.26 kB
oss-stable-semver/react/cjs/react-jsx-runtime.production.js +0.25% 5.13 kB 5.14 kB +0.27% 2.25 kB 2.26 kB
oss-stable/react/cjs/react-jsx-runtime.production.js +0.25% 5.13 kB 5.14 kB +0.27% 2.25 kB 2.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.js +0.23% 9.79 kB 9.81 kB +0.53% 2.47 kB 2.48 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.js +0.23% 9.81 kB 9.84 kB +0.44% 2.50 kB 2.51 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.js +0.23% 9.82 kB 9.84 kB +0.48% 2.50 kB 2.51 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +0.21% 7.59 kB 7.60 kB +0.24% 1.70 kB 1.70 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +0.21% 7.59 kB 7.60 kB +0.24% 1.70 kB 1.70 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +0.21% 7.59 kB 7.60 kB +0.24% 1.70 kB 1.70 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 8d3a6c9

…S_THEY_CANNOT_UPGRADE

And the RSC one to __SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE.
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of an era

hoxyq
hoxyq previously requested changes Apr 9, 2024
Copy link
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the failing legacy/editing-test.js, I am okay with removing it completely, since its testing RDT against React 15, I think its time to drop support for it.

Maybe I am missing context from previous PRs, but with this changes, will updated react-debug-tools work with React 17 / React 18?

Comment on lines 62 to +63
const ReactSharedInternals = (React: any)
.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
.__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change it to const ReactSharedInternals = (React: any).__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED || (React: any).__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE;

For backwards-compat, so if there is a new patch release of DevTools, this will still work with previous versions of React?

There is a TODO in this file about removing it, I will take a look if we can safely remove it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dispatcher below has already changed so it'll be broken already. Would have to re-add a compat check.

I didn't think I needed to keep DevTools UI in sync though. That's a big burden, but regardless, this hack needs to be fixed since we'll remove the readContext dispatcher too. What applications use it without building React from source?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you can maybe swap it to using use() instead because that can read a Context unconditionally but ofc only works with newer versions of React too.

Copy link
Contributor

@hoxyq hoxyq Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should update every accessor of secret internals and dispatcher inside it to be backwards-compatible:

  • React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED -> React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED || React. __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE
  • <internals>.ReactCurrentDispatcher -> <internals>.ReactCurrentDispatcher || <internals>
  • <dispatcher>.current -> <dispatcher>.current || <dispatcher>.H

I can help with adding compatibility for these or testing the implementation

This should be done for:

  • react-debug-tools, which should not use shared/ReactInternals and use own accessor with compat check
  • react-devtools-shared/src/devtools/cache

Regarding the readContext and Cache stuff, I am planning to migrate away from those, so we can remove it both here in react-devtools-shared/src/devtools/cache and getCacheForType calls, to finally remove Cache component.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the backend I added this compatibility layer that translates older dispatchers to the new format:

https://github.com/facebook/react/blob/main/packages/react-devtools-shared/src/backend/renderer.js#L145-L168

But it could also be done elsewhere.

For react-debug-tools I don't think the public API should even accept a dispatcher since those are not public. So inspectHooks that's exported shouldn't have that argument. It's not a public API to get access to a Fiber neither so the whole inspectHooksOfFiber should be exposed in a private way only to DevTools. (Or the whole thing forked.)

It also doesn't make sense to call it while already inside an active render - so it doesn't make sense that it picks anything up from shared/ReactInternals since the only valid use case is for DevTools which always passes the dispatcher.

@sebmarkbage sebmarkbage dismissed hoxyq’s stale review April 9, 2024 16:20

This was already broken in an earlier PR. Feedback taken as a potential follow up but not blocking this PR.

@sebmarkbage sebmarkbage merged commit f613165 into facebook:main Apr 9, 2024
38 checks passed
@sebmarkbage
Copy link
Collaborator Author

Regarding the failing legacy/editing-test.js, I am okay with removing it completely, since its testing RDT against React 15, I think its time to drop support for it.

The thing is that it would actually break with 16-18 too because the issue is that it used the automatic JSX runtime which pulled in 19. So I converted the legacy tests to use React.createElement instead of JSX.

Maybe I am missing context from previous PRs, but with this changes, will updated react-debug-tools work with React 17 / React 18?

Yea, this compat layer should take care of that I think: https://github.com/facebook/react/blob/main/packages/react-devtools-shared/src/backend/renderer.js#L145-L168

Meaning the compat layer is in the backend.

github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
…RS_THEY_CANNOT_UPGRADE` (#28789)

Follow up to #28783 and #28786.

Since we've changed the implementations of these we can rename them to
something a bit more descriptive while we're at it, since anyone
depending on them will need to upgrade their code anyway.

"react" with no condition:
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react" with "react-server" condition:
`__SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react-dom":
`__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`

DiffTrain build for [f613165](f613165)
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
…RS_THEY_CANNOT_UPGRADE` (#28789)

Follow up to #28783 and #28786.

Since we've changed the implementations of these we can rename them to
something a bit more descriptive while we're at it, since anyone
depending on them will need to upgrade their code anyway.

"react" with no condition:
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react" with "react-server" condition:
`__SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react-dom":
`__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
…RS_THEY_CANNOT_UPGRADE` (#28789)

Follow up to #28783 and #28786.

Since we've changed the implementations of these we can rename them to
something a bit more descriptive while we're at it, since anyone
depending on them will need to upgrade their code anyway.

"react" with no condition:
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react" with "react-server" condition:
`__SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react-dom":
`__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…RS_THEY_CANNOT_UPGRADE` (facebook#28789)

Follow up to facebook#28783 and facebook#28786.

Since we've changed the implementations of these we can rename them to
something a bit more descriptive while we're at it, since anyone
depending on them will need to upgrade their code anyway.

"react" with no condition:
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react" with "react-server" condition:
`__SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react-dom":
`__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
hoxyq pushed a commit that referenced this pull request Apr 15, 2024
This is a follow up to
#28789 (comment)

Revert to use the old readContext detection if not to support older
React.

I haven't actually tested this. Just opening as a suggestion.
hoxyq added a commit that referenced this pull request Apr 15, 2024
Full list of changes:
* Look for a ReactMemoCacheSentinel on state
([gsathya](https://github.com/gsathya) in
[#28831](#28831))
* Use use() in the Cache if available
([sebmarkbage](https://github.com/sebmarkbage) in
[#28793](#28793))
* feat[devtools-fusebox]: support theme option
([hoxyq](https://github.com/hoxyq) in
[#28832](#28832))
* feat[devtools]: add package for fusebox integration
([hoxyq](https://github.com/hoxyq) in
[#28553](#28553))
* feat[devtools]: add method for connecting backend with custom
messaging protocol ([hoxyq](https://github.com/hoxyq) in
[#28552](#28552))
* Rename SECRET INTERNALS to
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
([sebmarkbage](https://github.com/sebmarkbage) in
[#28789](#28789))
* Flatten ReactSharedInternals
([sebmarkbage](https://github.com/sebmarkbage) in
[#28783](#28783))
* feat[devtools]: ship source maps for content scripts and ignore list
installHook script ([hoxyq](https://github.com/hoxyq) in
[#28730](#28730))
* Track Owner for Server Components in DEV
([sebmarkbage](https://github.com/sebmarkbage) in
[#28753](#28753))
* Move ReactDOMLegacy implementation into RootFB
([sebmarkbage](https://github.com/sebmarkbage) in
[#28656](#28656))
* Reland #28672: Remove IndeterminateComponent
([gnoff](https://github.com/gnoff) in
[#28681](#28681))
* Remove reference to deleted <Cache> in un-linted file
([josephsavona](https://github.com/josephsavona) in
[#28715](#28715))
* [be] Remove unshipped experimental <Cache> element type
([josephsavona](https://github.com/josephsavona) in
[#28698](#28698))
* Revert "Remove module pattern function component support"
([rickhanlonii](https://github.com/rickhanlonii) in
[#28670](#28670))
* Remove module pattern function component support
([gnoff](https://github.com/gnoff) in
[#27742](#27742))
* [RTR] Enable warning flag ([jackpope](https://github.com/jackpope) in
[#28419](#28419))
* Update error messages ([rickhanlonii](https://github.com/rickhanlonii)
in [#28652](#28652))
* fix[devtools/ci]: split profiling cache test for different react
versions and toEqual checker ([hoxyq](https://github.com/hoxyq) in
[#28628](#28628))
* Guard against legacy context not being supported in DevTools fixture
([eps1lon](https://github.com/eps1lon) in
[#28596](#28596))
* Use `declare const` instead of `declare var`
([kassens](https://github.com/kassens) in
[#28599](#28599))
* Update isConcurrent RTR option usage
([jackpope](https://github.com/jackpope) in
[#28546](#28546))
* Disable legacy context ([kassens](https://github.com/kassens) in
[#27991](#27991))
* Remove invokeGuardedCallback and replay trick
([sebmarkbage](https://github.com/sebmarkbage) in
[#28515](#28515))
* Remove remaining usages of ReactTestUtils in tests unrelated to
`react-dom/test-util` ([eps1lon](https://github.com/eps1lon) in
[#28534](#28534))
* fix[devtools/e2e]: fixed source inspection in e2e tests
([hoxyq](https://github.com/hoxyq) in
[#28518](#28518))
* Devtools: Display actual pending state when inspecting `useTransition`
([eps1lon](https://github.com/eps1lon) in
[#28499](#28499))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…RS_THEY_CANNOT_UPGRADE` (#28789)

Follow up to #28783 and #28786.

Since we've changed the implementations of these we can rename them to
something a bit more descriptive while we're at it, since anyone
depending on them will need to upgrade their code anyway.

"react" with no condition:
`__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react" with "react-server" condition:
`__SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`
"react-dom":
`__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`

DiffTrain build for commit f613165.
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 19, 2024
Summary:
This sync includes the changes from:
- D56103750
- [TODO] A shim for SECRET_INTERNALS

This sync includes the following changes:
- **[b5e5ce8e0](facebook/react@b5e5ce8e0 )**: Update ReactNativeTypes for root options (part 2) ([#28857](facebook/react#28857)) //<Ricky>//
- **[da6ba53b1](facebook/react@da6ba53b1 )**: [UMD] Remove umd builds ([#28735](facebook/react#28735)) //<Josh Story>//
- **[0c245df1d](facebook/react@0c245df1d )**: Complete the typo fix ([#28856](facebook/react#28856)) //<Sebastian Silbermann>//
- **[f82051d7a](facebook/react@f82051d7a )**: console test utils fix: match entire string, not just first letter ([#28855](facebook/react#28855)) //<Andrew Clark>//
- **[4ca20fd36](facebook/react@4ca20fd36 )**: Test top level fragment inside lazy semantics ([#28852](facebook/react#28852)) //<Sebastian Markbåge>//
- **[c0cf7c696](facebook/react@c0cf7c696 )**: Promote ASYNC_ITERATOR symbol to React Symbols ([#28851](facebook/react#28851)) //<Sebastian Markbåge>//
- **[657428a9e](facebook/react@657428a9e )**: Add ReactNativeTypes for root options ([#28850](facebook/react#28850)) //<Ricky>//
- **[7909d8eab](facebook/react@7909d8eab )**: [Flight] Encode ReadableStream and AsyncIterables ([#28847](facebook/react#28847)) //<Sebastian Markbåge>//
- **[13eb61d05](facebook/react@13eb61d05 )**: Move enableUseDeferredValueInitialArg to canary ([#28818](facebook/react#28818)) //<Andrew Clark>//
- **[8afa144bd](facebook/react@8afa144bd )**: Enable flag disableClientCache ([#28846](facebook/react#28846)) //<Jan Kassens>//
- **[734956ace](facebook/react@734956ace )**: Devtools: Add support for useFormStatus ([#28413](facebook/react#28413)) //<Sebastian Silbermann>//
- **[17e920c00](facebook/react@17e920c00 )**: [Flight Reply] Encode Typed Arrays and Blobs ([#28819](facebook/react#28819)) //<Sebastian Markbåge>//
- **[0347fcd00](facebook/react@0347fcd00 )**: Add on(Caught|Uncaught|Recoverable) opts to RN ([#28836](facebook/react#28836)) //<Ricky>//
- **[c113503ad](facebook/react@c113503ad )**: Flush direct streams in Bun ([#28837](facebook/react#28837)) //<Kenta Iwasaki>//
- **[9defcd56b](facebook/react@9defcd56b )**: Remove redundant props assign ([#28829](facebook/react#28829)) //<Sebastian Silbermann>//
- **[ed4023603](facebook/react@ed4023603 )**: Fix mistaken "react-server" condition ([#28835](facebook/react#28835)) //<Sebastian Markbåge>//
- **[c8a035036](facebook/react@c8a035036 )**: [Fizz] hoistables should never flush before the preamble ([#28802](facebook/react#28802)) //<Josh Story>//
- **[4f5c812a3](facebook/react@4f5c812a3 )**: DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions ([#28593](facebook/react#28593)) //<Sebastian Silbermann>//
- **[435415962](facebook/react@435415962 )**: Backwards compatibility for string refs on WWW ([#28826](facebook/react#28826)) //<Jack Pope>//
- **[608edcc90](facebook/react@608edcc90 )**: [tests] add `assertConsole<method>Dev` helpers ([#28732](facebook/react#28732)) //<Ricky>//
- **[da69b6af9](facebook/react@da69b6af9 )**: ReactDOM.requestFormReset  ([#28809](facebook/react#28809)) //<Andrew Clark>//
- **[374b5d26c](facebook/react@374b5d26c )**: Scaffolding for requestFormReset API ([#28808](facebook/react#28808)) //<Andrew Clark>//
- **[41950d14a](facebook/react@41950d14a )**: Automatically reset forms after action finishes ([#28804](facebook/react#28804)) //<Andrew Clark>//
- **[dc6a7e01e](facebook/react@dc6a7e01e )**: [Float] Don't preload images inside `<noscript>` ([#28815](facebook/react#28815)) //<Josh Story>//
- **[3f947b1b4](facebook/react@3f947b1b4 )**: [tests] Assert scheduler log empty in internalAct ([#28737](facebook/react#28737)) //<Ricky>//
- **[bf09089f6](facebook/react@bf09089f6 )**: Remove Scheduler.log from ReactSuspenseFuzz-test ([#28812](facebook/react#28812)) //<Ricky>//
- **[84cb3b4cb](facebook/react@84cb3b4cb )**: Hardcode disableIEWorkarounds for www ([#28811](facebook/react#28811)) //<Ricky>//
- **[2243b40ab](facebook/react@2243b40ab )**: [tests] assertLog before act in useEffectEvent ([#28763](facebook/react#28763)) //<Ricky>//
- **[dfc64c6e3](facebook/react@dfc64c6e3 )**: [tests] assertLog before act in ReactUse ([#28762](facebook/react#28762)) //<Ricky>//
- **[42eff4bc7](facebook/react@42eff4bc7 )**: [tests] Fix assertions not flushed before act ([#28745](facebook/react#28745)) //<Ricky>//
- **[ed3c65caf](facebook/react@ed3c65caf )**: Warn if outdated JSX transform is detected ([#28781](facebook/react#28781)) //<Andrew Clark>//
- **[3f9e237a2](facebook/react@3f9e237a2 )**: Fix: Suspend while recovering from hydration error ([#28800](facebook/react#28800)) //<Andrew Clark>//
- **[7f5d25e23](facebook/react@7f5d25e23 )**: Fix cloneElement using string ref w no owner ([#28797](facebook/react#28797)) //<Joseph Savona>//
- **[bf40b0244](facebook/react@bf40b0244 )**: [Fizz] Stop publishing external-runtime to stable channel ([#28796](facebook/react#28796)) //<Josh Story>//
- **[7f93cb41c](facebook/react@7f93cb41c )**: [DOM] Infer react-server entries bundles if not explicitly configured ([#28795](facebook/react#28795)) //<Josh Story>//
- **[f61316535](facebook/react@f61316535 )**: Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([#28789](facebook/react#28789)) //<Sebastian Markbåge>//
- **[9644d206e](facebook/react@9644d206e )**: Soften useFormState warning ([#28788](facebook/react#28788)) //<Ricky>//
- **[c771016e1](facebook/react@c771016e1 )**: Rename The Secret Export of Server Internals ([#28786](facebook/react#28786)) //<Sebastian Markbåge>//
- **[d50323eb8](facebook/react@d50323eb8 )**: Flatten ReactSharedInternals ([#28783](facebook/react#28783)) //<Sebastian Markbåge>//
- **[f62cf8c62](facebook/react@f62cf8c62 )**: [Float] treat `props.async` in Float consistent with the rest of react-dom ([#26760](facebook/react#26760)) //<Josh Story>//
- **[dfd3d5af8](facebook/react@dfd3d5af8 )**: Add support for transition{run,start,cancel} events ([#27345](facebook/react#27345)) //<Hugo Sales>//
- **[1f8327f83](facebook/react@1f8327f83 )**: [Fiber] Use real event priority for hydration scheduling ([#28765](facebook/react#28765)) //<Josh Story>//
- **[97c90ed88](facebook/react@97c90ed88 )**: [DOM] Shrink ReactDOMCurrentDispatcher method names ([#28770](facebook/react#28770)) //<Josh Story>//
- **[9007fdc8f](facebook/react@9007fdc8f )**: [DOM] Shrink ReactDOMSharedInternals source representation ([#28771](facebook/react#28771)) //<Josh Story>//
- **[14f50ad15](facebook/react@14f50ad15 )**: [Flight] Allow lazily resolving outlined models ([#28780](facebook/react#28780)) //<Sebastian Markbåge>//
- **[4c12339ce](facebook/react@4c12339ce )**: [DOM] move `flushSync` out of the reconciler ([#28500](facebook/react#28500)) //<Josh Story>//
- **[8e1462e8c](facebook/react@8e1462e8c )**: [Fiber] Move updatePriority tracking to renderers ([#28751](facebook/react#28751)) //<Josh Story>//
- **[0b3b8a6a3](facebook/react@0b3b8a6a3 )**: jsx: Remove unnecessary hasOwnProperty check ([#28775](facebook/react#28775)) //<Andrew Clark>//
- **[2acfb7b60](facebook/react@2acfb7b60 )**: [Flight] Support FormData from Server to Client ([#28754](facebook/react#28754)) //<Sebastian Markbåge>//
- **[d1547defe](facebook/react@d1547defe )**: Fast JSX: Don't clone props object ([#28768](facebook/react#28768)) //<Andrew Clark>//
- **[bfd8da807](facebook/react@bfd8da807 )**: Make class prop resolution faster ([#28766](facebook/react#28766)) //<Andrew Clark>//
- **[cbb6f2b54](facebook/react@cbb6f2b54 )**: [Flight] Support Blobs from Server to Client ([#28755](facebook/react#28755)) //<Sebastian Markbåge>//
- **[f33a6b69c](facebook/react@f33a6b69c )**: Track Owner for Server Components in DEV ([#28753](facebook/react#28753)) //<Sebastian Markbåge>//
- **[e3ebcd54b](facebook/react@e3ebcd54b )**: Move string ref coercion to JSX runtime ([#28473](facebook/react#28473)) //<Andrew Clark>//
- **[fd0da3eef](facebook/react@fd0da3eef )**: Remove _owner field from JSX elements in prod if string refs are disabled ([#28739](facebook/react#28739)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions 48b4ecc...b5e5ce8

jest_e2e[run_all_tests]
bypass-github-export-checks

Reviewed By: kassens

Differential Revision: D56251607

fbshipit-source-id: e16db2fa101fc7ed1e009158c76388206beabd5f
@denchiklut
Copy link

This breaks react-server-dom-webpack it seems like it still relies on: __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE
image

The latest version for today: 19.0.0-rc-fb9a90fa48-20240614
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants