Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up console.log tests #28693

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

rickhanlonii
Copy link
Member

Followups to #28680

One of these test don't need to use console.log.

The others are specifically testing console.log behavior, so I added a comment.

@react-sizebot
Copy link

react-sizebot commented Mar 31, 2024

Comparing: df95577...42b4189

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.05 kB 55.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.94 kB 172.94 kB = 53.91 kB 53.91 kB
facebook-www/ReactDOM-prod.classic.js = 592.68 kB 592.68 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 574.37 kB 574.37 kB = 100.98 kB 100.98 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 42b4189

Copy link
Contributor

@yungsters yungsters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! With 1 minor change needed.

packages/react-client/src/__tests__/ReactFlight-test.js Outdated Show resolved Hide resolved
@rickhanlonii rickhanlonii merged commit e9ae2c8 into facebook:main Apr 1, 2024
38 checks passed
@rickhanlonii rickhanlonii deleted the rh/test-cleanup branch April 1, 2024 14:50
rickhanlonii added a commit that referenced this pull request Apr 1, 2024
Followup from #28693 and
#28680.

In CI, we fail the test for any unasserted console.log. In DEV, we don't
fail, but you can still use the matchers and we'll assert on them.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Followups to facebook#28680

One of these test don't need to use `console.log`. 

The others are specifically testing `console.log` behavior, so I added a
comment.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Followup from facebook#28693 and
facebook#28680.

In CI, we fail the test for any unasserted console.log. In DEV, we don't
fail, but you can still use the matchers and we'll assert on them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants