Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/getRootNode/ownerDocument #28412

Merged
merged 5 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2273,7 +2273,7 @@ function diffHydratedCustomComponent(
// as a shared module for that reason.
const EXPECTED_FORM_ACTION_URL =
// eslint-disable-next-line no-script-url
"javascript:throw new Error('A React form was unexpectedly submitted.')";
"javascript:throw new Error('React form unexpectedly submitted.')";

function diffHydratedGenericElement(
domElement: Element,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,8 @@ export function retryIfBlockedOn(

if (enableFormActions) {
// Check the document if there are any queued form actions.
const root = unblocked.getRootNode();
rickhanlonii marked this conversation as resolved.
Show resolved Hide resolved
// If there's no ownerDocument, then this is the document.
const root = unblocked.ownerDocument || unblocked;
const formReplayingQueue: void | FormReplayingQueue = (root: any)
.$$reactFormReplay;
if (formReplayingQueue != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1015,7 +1015,7 @@ function makeFormFieldPrefix(resumableState: ResumableState): string {
const actionJavaScriptURL = stringToPrecomputedChunk(
escapeTextForBrowser(
// eslint-disable-next-line no-script-url
"javascript:throw new Error('A React form was unexpectedly submitted.')",
"javascript:throw new Error('React form unexpectedly submitted.')",
),
);

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export function completeSegment(containerID, placeholderID) {
// as a shared module for that reason.
const EXPECTED_FORM_ACTION_URL =
// eslint-disable-next-line no-script-url
"javascript:throw new Error('A React form was unexpectedly submitted.')";
"javascript:throw new Error('React form unexpectedly submitted.')";

export function listenToFormSubmissionsForReplaying() {
// A global replay queue ensures actions are replayed in order.
Expand Down Expand Up @@ -196,9 +196,8 @@ export function listenToFormSubmissionsForReplaying() {
// javascript: URL placeholder value. So we might not be the first to declare it.
// We attach it to the form's root node, which is the shared environment context
// where we preserve sequencing and where we'll pick it up from during hydration.
// In practice, this is just the same as document but we might support shadow trees
// in the future.
const root = form.getRootNode();
// If there's no ownerDocument, then this is the document.
const root = form.ownerDocument || form;
(root['$$reactFormReplay'] = root['$$reactFormReplay'] || []).push(
form,
submitter,
Expand Down