Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta-only] Move ReactServerStreamConfigFB to react-server from react-server-dom-fb #27544

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

alunyov
Copy link
Contributor

@alunyov alunyov commented Oct 18, 2023

Code organization PR.

It looks like the ReactServerStreamConfigFB is only used in the relay-server package. This PR moves it to react-server from react-server-dom-fb (similar to how we have config for bun, for example). This avoids cross-package imports from react-server to react-server-dom-fb.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 18, 2023
@react-sizebot
Copy link

Comparing: 9617d39...fa0e599

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.94 kB = 54.44 kB 54.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.06 kB = 55.12 kB 55.12 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.28 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.14 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against fa0e599

@alunyov alunyov changed the title Fb streaming config [meta-only] Move ReactServerStreamConfigFB to react-server from react-server-dom-fb Oct 18, 2023
@alunyov alunyov marked this pull request as ready for review October 18, 2023 22:31
@alunyov alunyov requested a review from gnoff October 19, 2023 16:05
@alunyov alunyov merged commit b67ddaa into facebook:main Oct 19, 2023
2 checks passed
@alunyov alunyov deleted the FbStreamingConfig branch October 19, 2023 16:35
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…act-server-dom-fb` (facebook#27544)

Code organization PR.

It looks like the `ReactServerStreamConfigFB` is only used in the
`relay-server` package. This PR moves it to `react-server` from
`react-server-dom-fb` (similar to how we have config for bun, for
example). This avoids cross-package imports from `react-server` to
`react-server-dom-fb.`
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…act-server-dom-fb` (#27544)

Code organization PR.

It looks like the `ReactServerStreamConfigFB` is only used in the
`relay-server` package. This PR moves it to `react-server` from
`react-server-dom-fb` (similar to how we have config for bun, for
example). This avoids cross-package imports from `react-server` to
`react-server-dom-fb.`

DiffTrain build for commit b67ddaa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants