Regression test: Stylesheet suspends indefinitely when part of error boundary UI during initial hydration #27258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a failing test for a case discovered by Next.js. An error boundary is triggered during initial hydration, and the error fallback includes a stylesheet. If the stylesheet has not yet been loaded, the commit suspends, but never resolves even after the stylesheet finishes loading. Triggering this bug depends on several very specific code paths being triggered simultaneously. There are a few ways we could fix the bug; I'll submit as one or more separate PRs to show that each one is sufficient.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: b277259...20d5e2b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
approved these changes
Aug 21, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 22, 2023
### React upstream changes - facebook/react#27265 - facebook/react#27259 - facebook/react#27264 - facebook/react#27257 - facebook/react#27258 - facebook/react#27187 - facebook/react#27243 - facebook/react#27205 - facebook/react#27220 - facebook/react#27238 - facebook/react#27234 - facebook/react#27224 - facebook/react#27223 - facebook/react#27222 This will help unblock #53906
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…boundary UI during initial hydration (facebook#27258) Adds a failing test for a case discovered by Next.js. An error boundary is triggered during initial hydration, and the error fallback includes a stylesheet. If the stylesheet has not yet been loaded, the commit suspends, but never resolves even after the stylesheet finishes loading. Triggering this bug depends on several very specific code paths being triggered simultaneously. There are a few ways we could fix the bug; I'll submit as one or more separate PRs to show that each one is sufficient.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
…boundary UI during initial hydration (#27258) Adds a failing test for a case discovered by Next.js. An error boundary is triggered during initial hydration, and the error fallback includes a stylesheet. If the stylesheet has not yet been loaded, the commit suspends, but never resolves even after the stylesheet finishes loading. Triggering this bug depends on several very specific code paths being triggered simultaneously. There are a few ways we could fix the bug; I'll submit as one or more separate PRs to show that each one is sufficient. DiffTrain build for commit 7d1c3c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a failing test for a case discovered by Next.js. An error boundary is triggered during initial hydration, and the error fallback includes a stylesheet. If the stylesheet has not yet been loaded, the commit suspends, but never resolves even after the stylesheet finishes loading.
Triggering this bug depends on several very specific code paths being triggered simultaneously. There are a few ways we could fix the bug; I'll submit as one or more separate PRs to show that each one is sufficient.