Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower Suspense throttling heuristic to 300ms #26803

Merged
merged 1 commit into from
May 16, 2023

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented May 11, 2023

Now that the throttling mechanism applies more often, we've decided to lower this a tad to ensure it's not noticeable. The idea is it should be just large enough to prevent jank when lots of different parts of the UI load in rapid succession, but not large enough to make the UI feel sluggish. There's no perfect number, it's just a heuristic.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 11, 2023
@react-sizebot
Copy link

react-sizebot commented May 11, 2023

Comparing: 4bfcd02...8759469

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.23 kB 164.23 kB = 51.76 kB 51.77 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.59 kB 171.59 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 570.55 kB 570.55 kB = 100.65 kB 100.66 kB
facebook-www/ReactDOM-prod.modern.js = 554.29 kB 554.29 kB = 97.84 kB 97.84 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8759469

@acdlite acdlite requested a review from sebmarkbage May 11, 2023 05:00
Now that the throttling mechanism applies more often, we've decided to
lower this a tad to ensure it's not noticeable. The idea is it should be
just large enough to prevent jank when lots of different parts of the UI
load in rapid sucesssion, but not large enough to make the UI feel
sluggish. There's no perfect number, it's just a heuristic.
@acdlite acdlite force-pushed the lower-suspense-throttling-heuristic branch from 4184466 to 8759469 Compare May 16, 2023 19:38
@acdlite acdlite merged commit f8de255 into facebook:main May 16, 2023
github-actions bot pushed a commit that referenced this pull request May 16, 2023
Now that the throttling mechanism applies more often, we've decided to
lower this a tad to ensure it's not noticeable. The idea is it should be
just large enough to prevent jank when lots of different parts of the UI
load in rapid succession, but not large enough to make the UI feel
sluggish. There's no perfect number, it's just a heuristic.

DiffTrain build for [f8de255](f8de255)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Now that the throttling mechanism applies more often, we've decided to
lower this a tad to ensure it's not noticeable. The idea is it should be
just large enough to prevent jank when lots of different parts of the UI
load in rapid succession, but not large enough to make the UI feel
sluggish. There's no perfect number, it's just a heuristic.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Now that the throttling mechanism applies more often, we've decided to
lower this a tad to ensure it's not noticeable. The idea is it should be
just large enough to prevent jank when lots of different parts of the UI
load in rapid succession, but not large enough to make the UI feel
sluggish. There's no perfect number, it's just a heuristic.

DiffTrain build for commit f8de255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants