Insert temporary input node to polyfill submitter argument in FormData #26714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I moved the other part I broke out of this validation too early.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 2fa6323...1d7418a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
We also exclude the submitter if it's a function action. This ensures that we don't include the generated "name" when the action is a server action.
sebmarkbage
force-pushed
the
formdatasubmitter
branch
from
3469b8a to
6b56558
Compare
sophiebits
approved these changes
Apr 24, 2023
| @@ -53,6 +53,11 @@ function extractEvents( | |||
| if (submitterAction != null) { | |||
| // The submitter overrides the form action. | |||
| action = submitterAction; | |||
| if (typeof action === 'function') { | |||
There was a problem hiding this comment.
Since there is if (typeof action !== 'function') just below… skip this conditional?
There was a problem hiding this comment.
That's what I ended up doing in the replaying one. Not sure why I didn't see it here.
| // TODO: FormData takes a second argument that it's the submitter but this | ||
| // is fairly new so not all browsers support it yet. Switch to that technique | ||
| // when available. | ||
| const type = submitter.type; | ||
| submitter.type = 'hidden'; | ||
| const temp = submitter.ownerDocument.createElement('input'); |
There was a problem hiding this comment.
think adding .type = 'hidden' to the temp node is any more efficient?
There was a problem hiding this comment.
You mean because it won't invalidate layout or something? Not sure that's true since even hidden forms can be made to participate in layout.
There was a problem hiding this comment.
It's also invalid on button so wouldn't make any difference in most cases.
If this is false, we'll bail anyway.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
facebook#26714) Insert temporary input node to polyfill submitter argument in FormData. This works for buttons too and fixes a bug where the type attribute wasn't reset. I also exclude the submitter if it's a function action. This ensures that we don't include the generated "name" when the action is a server action. Conceptually that name doesn't exist.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
#26714) Insert temporary input node to polyfill submitter argument in FormData. This works for buttons too and fixes a bug where the type attribute wasn't reset. I also exclude the submitter if it's a function action. This ensures that we don't include the generated "name" when the action is a server action. Conceptually that name doesn't exist. DiffTrain build for commit 5e5342b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert temporary input node to polyfill submitter argument in FormData. This works for buttons too and fixes a bug where the type attribute wasn't reset.
I also exclude the submitter if it's a function action. This ensures that we don't include the generated "name" when the action is a server action. Conceptually that name doesn't exist.