Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-is download hack #26692

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Remove react-is download hack #26692

merged 1 commit into from
Apr 21, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 21, 2023 •
edited
Loading

This was added during an upgrade to Jest 24 in #15778

By now we're at Jest 29. I think if CI passes we might not need this hack anymore.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 21, 2023
@react-sizebot
Copy link

Comparing: c836952...f34b410

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 163.95 kB 163.95 kB = 51.67 kB 51.67 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 167.70 kB 167.70 kB = 52.81 kB 52.81 kB
facebook-www/ReactDOM-prod.classic.js = 566.07 kB 566.07 kB = 100.25 kB 100.25 kB
facebook-www/ReactDOM-prod.modern.js = 549.80 kB 549.80 kB = 97.57 kB 97.57 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f34b410

@kassens kassens marked this pull request as ready for review April 21, 2023 17:08
acdlite
acdlite approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@kassens kassens merged commit c57a0f6 into facebook:main Apr 21, 2023
@kassens kassens deleted the no-download-react-is branch April 21, 2023 17:11
kassens added a commit that referenced this pull request Apr 21, 2023
@kassens
Remove react-is download hack (#26692)
00f97f7 
This was added during an upgrade to Jest 24 in
#15778

By now we're at Jest 29. I think if CI passes we might not need this
hack anymore.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@kassens @AndyPengc12
Remove react-is download hack (facebook#26692)
ea33eb5 
This was added during an upgrade to Jest 24 in
facebook#15778

By now we're at Jest 29. I think if CI passes we might not need this
hack anymore.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@kassens
Remove react-is download hack (#26692)
58e0487 
This was added during an upgrade to Jest 24 in
#15778

By now we're at Jest 29. I think if CI passes we might not need this
hack anymore.

DiffTrain build for commit c57a0f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @acdlite @facebook-github-bot