Remove obsolete name property from client reference in Flight Node Register
#26322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: eb616a1...96b9eef Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
unstubbable
force-pushed
the
remove-leftover
branch
from
ce9aad7
to
3e1ebc7
Compare
This is a leftover from facebook#26300 where `name` was incorporated into `$$id`.
unstubbable
force-pushed
the
remove-leftover
branch
from
3e1ebc7
to
96b9eef
Compare
unstubbable
commented
Mar 6, 2023
| @@ -95,8 +97,6 @@ module.exports = function register() { | |||
| return target.$$id; | |||
| case '$$async': | |||
| return target.$$async; | |||
| case 'name': | |||
| return target.name; | |||
There was a problem hiding this comment.
This case was not covered by a unit test, but I think it's dead code and can not be reached.
| @@ -185,7 +185,6 @@ module.exports = function register() { | |||
| ); | |||
| }: any), | |||
| { | |||
| name: {value: name}, | |||
There was a problem hiding this comment.
If this was left in intentionally for convenience (i.e. reading it in deepProxyHandlers), feel free to just close the PR. But including the name here, but not in all the other branches, felt inconsistent and confusing to me.
|
This was intentionally left as a debug value for when the function is printed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a leftover from #26300 where
namewas incorporated into$$id.How did you test this change?
yarn testandyarn test --prod