Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchedulerMock.unstable_yieldValue -> SchedulerMock.log #26312

Merged
merged 2 commits into from
Mar 6, 2023

Commits on Mar 4, 2023

  1. Delete toFlushAndYield test helpers

    Now that the tests have been codemodded, we can delete toFlushAndYield
    et al from the codebase. See facebook#26285 for full context.
    
    The mock implementation of Scheduler still exposes some (unstable-
    prefixed) APIs that can be used for some edge cases, like when testing
    the mock Scheduler itself. There are only a few tests that do this, and
    even some of those could be rewritten to use `act` or `waitFor`.
    acdlite committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    0cba581 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. SchedulerMock.unstable_yieldValue -> SchedulerMock.log

    (This only affects our own internal repo; it's not a public API.)
    
    I think most of us agree this is a less confusing name. It's possible
    someone will confuse it with `console.log`. If that becomes a problem
    we can warn in dev or something.
    acdlite committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    e9b6832 View commit details
    Browse the repository at this point in the history