Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] improve troubleshooting in README #26235

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

mondaychen
Copy link
Contributor

@mondaychen mondaychen commented Feb 24, 2023

Summary

Improve the README when the elements are not loaded due to Chrome service worker malfunction


@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 24, 2023

**If you still have issues** please [report them](https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools). Don't forget to specify your OS, browser version, extension version, and the exact instructions to reproduce the issue with a screenshot.

### The Issue with Chrome v101 and earlier
As we migrate to a Chrome Extension Manifest V3, we start to use a new method to hook the DevTools with the inspected page. This new method is more secure, but relies on a new API that's only supported in Chrome v102+. For Chrome v101 or earlier, we use a fallback method, which can cause malfunctions (e.g. empty React component tab) if the JS resources on your page is loaded from cache. Please upgrade to Chrome v102+ to avoid this issue.
### The React Tab Shows Empty Tree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace "empty tree" with "no components" for a more user centric wording? (if you accept the suggestion, make sure to also update the # link above in the other file.

I think not using title case is also more in line with the majority of the rest of the document.

Suggested change
### The React Tab Shows Empty Tree
### The React tab shows no components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks!

@mondaychen mondaychen merged commit b073104 into facebook:main Mar 3, 2023
github-actions bot pushed a commit that referenced this pull request Mar 3, 2023
## Summary

Improve the README when the elements are not loaded due to Chrome
service worker malfunction

DiffTrain build for [b073104](b073104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants