Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and warn if use(promise) is wrapped with try/catch block #25543

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 23, 2022

The old (unstable) mechanism for suspending was to throw a promise. The purpose of throwing is to interrupt the component's execution, and also to signal to React that the interruption was caused by Suspense as opposed to some other error.

A flaw is that throwing is meant to be an implementation detail — if code in userspace catches the promise, it can lead to unexpected behavior.

With use, userspace code does not throw promises directly, but use itself still needs to throw something to interrupt the component and unwind the stack.

The solution is to throw an internal error. In development, we can detect whether the error was caught by a userspace try/catch block and log a warning — though it's not foolproof, since a clever user could catch the object and rethrow it later.

The error message includes advice to move use outside of the try/catch block.

I did not yet implement the warning in Flight.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 23, 2022
@sizebot
Copy link

sizebot commented Oct 23, 2022

Comparing: cf3932b...da38d04

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.04% 152.77 kB 152.84 kB +0.07% 48.73 kB 48.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.04% 154.69 kB 154.76 kB +0.14% 49.34 kB 49.41 kB
facebook-www/ReactDOM-prod.classic.js +0.16% 526.93 kB 527.75 kB +0.13% 94.15 kB 94.27 kB
facebook-www/ReactDOM-prod.modern.js +0.16% 512.19 kB 513.00 kB +0.13% 91.98 kB 92.10 kB
facebook-www/ReactDOMForked-prod.classic.js +0.16% 526.93 kB 527.75 kB +0.13% 94.15 kB 94.27 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js +4.78% 13.17 kB 13.80 kB +6.09% 4.85 kB 5.14 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.min.js +4.78% 13.17 kB 13.80 kB +6.09% 4.85 kB 5.14 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js +4.78% 13.17 kB 13.80 kB +6.09% 4.85 kB 5.14 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js +4.68% 54.52 kB 57.07 kB +5.27% 13.52 kB 14.23 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +4.21% 57.37 kB 59.79 kB +4.80% 13.99 kB 14.66 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +4.21% 57.37 kB 59.79 kB +4.80% 13.99 kB 14.66 kB
oss-stable/react-server/cjs/react-server-flight.development.js +4.21% 57.37 kB 59.79 kB +4.80% 13.99 kB 14.66 kB
facebook-relay/flight/ReactFlightNativeRelayServer-prod.js +3.93% 28.17 kB 29.28 kB +5.47% 6.70 kB 7.06 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +3.62% 70.47 kB 73.02 kB +4.22% 17.37 kB 18.11 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +3.62% 70.53 kB 73.08 kB +4.22% 17.39 kB 18.13 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js +3.29% 33.68 kB 34.79 kB +4.23% 8.48 kB 8.84 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js +3.28% 33.76 kB 34.87 kB +4.23% 8.51 kB 8.87 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +3.02% 80.12 kB 82.54 kB +3.35% 20.08 kB 20.75 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +3.02% 80.12 kB 82.54 kB +3.35% 20.08 kB 20.75 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +3.01% 80.18 kB 82.60 kB +3.34% 20.10 kB 20.77 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.97% 81.31 kB 83.73 kB +3.34% 20.14 kB 20.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.97% 81.31 kB 83.73 kB +3.34% 20.14 kB 20.81 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.97% 81.37 kB 83.78 kB +3.34% 20.16 kB 20.83 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.94% 84.20 kB 86.68 kB +3.36% 20.31 kB 21.00 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.94% 84.20 kB 86.68 kB +3.36% 20.31 kB 21.00 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.94% 84.27 kB 86.74 kB +3.36% 20.34 kB 21.02 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.90% 21.84 kB 22.48 kB +3.90% 7.71 kB 8.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.90% 21.84 kB 22.48 kB +3.90% 7.71 kB 8.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.89% 21.89 kB 22.52 kB +3.81% 7.74 kB 8.03 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +2.85% 22.22 kB 22.85 kB +3.79% 7.80 kB 8.10 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +2.85% 22.22 kB 22.85 kB +3.79% 7.80 kB 8.10 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +2.84% 22.26 kB 22.90 kB +3.67% 7.83 kB 8.12 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.81% 22.05 kB 22.67 kB +3.83% 7.81 kB 8.11 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.81% 22.05 kB 22.67 kB +3.83% 7.81 kB 8.11 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.81% 22.09 kB 22.71 kB +3.82% 7.83 kB 8.13 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js +2.65% 23.54 kB 24.16 kB +3.50% 8.01 kB 8.29 kB
oss-stable/react-server/cjs/react-server.production.min.js +2.65% 23.54 kB 24.16 kB +3.50% 8.01 kB 8.29 kB
oss-experimental/react-server/cjs/react-server.production.min.js +2.62% 23.78 kB 24.41 kB +3.63% 8.08 kB 8.38 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server-flight.production.min.js +4.78% 13.17 kB 13.80 kB +6.09% 4.85 kB 5.14 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.min.js +4.78% 13.17 kB 13.80 kB +6.09% 4.85 kB 5.14 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js +4.78% 13.17 kB 13.80 kB +6.09% 4.85 kB 5.14 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js +4.68% 54.52 kB 57.07 kB +5.27% 13.52 kB 14.23 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +4.21% 57.37 kB 59.79 kB +4.80% 13.99 kB 14.66 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +4.21% 57.37 kB 59.79 kB +4.80% 13.99 kB 14.66 kB
oss-stable/react-server/cjs/react-server-flight.development.js +4.21% 57.37 kB 59.79 kB +4.80% 13.99 kB 14.66 kB
facebook-relay/flight/ReactFlightNativeRelayServer-prod.js +3.93% 28.17 kB 29.28 kB +5.47% 6.70 kB 7.06 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +3.62% 70.47 kB 73.02 kB +4.22% 17.37 kB 18.11 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +3.62% 70.53 kB 73.08 kB +4.22% 17.39 kB 18.13 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js +3.29% 33.68 kB 34.79 kB +4.23% 8.48 kB 8.84 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js +3.28% 33.76 kB 34.87 kB +4.23% 8.51 kB 8.87 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +3.02% 80.12 kB 82.54 kB +3.35% 20.08 kB 20.75 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +3.02% 80.12 kB 82.54 kB +3.35% 20.08 kB 20.75 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +3.01% 80.18 kB 82.60 kB +3.34% 20.10 kB 20.77 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.97% 81.31 kB 83.73 kB +3.34% 20.14 kB 20.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.97% 81.31 kB 83.73 kB +3.34% 20.14 kB 20.81 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +2.97% 81.37 kB 83.78 kB +3.34% 20.16 kB 20.83 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.94% 84.20 kB 86.68 kB +3.36% 20.31 kB 21.00 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.94% 84.20 kB 86.68 kB +3.36% 20.31 kB 21.00 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +2.94% 84.27 kB 86.74 kB +3.36% 20.34 kB 21.02 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.90% 21.84 kB 22.48 kB +3.90% 7.71 kB 8.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.90% 21.84 kB 22.48 kB +3.90% 7.71 kB 8.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +2.89% 21.89 kB 22.52 kB +3.81% 7.74 kB 8.03 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +2.85% 22.22 kB 22.85 kB +3.79% 7.80 kB 8.10 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +2.85% 22.22 kB 22.85 kB +3.79% 7.80 kB 8.10 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +2.84% 22.26 kB 22.90 kB +3.67% 7.83 kB 8.12 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.81% 22.05 kB 22.67 kB +3.83% 7.81 kB 8.11 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.81% 22.05 kB 22.67 kB +3.83% 7.81 kB 8.11 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +2.81% 22.09 kB 22.71 kB +3.82% 7.83 kB 8.13 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js +2.65% 23.54 kB 24.16 kB +3.50% 8.01 kB 8.29 kB
oss-stable/react-server/cjs/react-server.production.min.js +2.65% 23.54 kB 24.16 kB +3.50% 8.01 kB 8.29 kB
oss-experimental/react-server/cjs/react-server.production.min.js +2.62% 23.78 kB 24.41 kB +3.63% 8.08 kB 8.38 kB
oss-stable-semver/react-server/cjs/react-server.development.js +1.71% 142.09 kB 144.52 kB +1.87% 35.39 kB 36.05 kB
oss-stable/react-server/cjs/react-server.development.js +1.71% 142.09 kB 144.52 kB +1.87% 35.39 kB 36.05 kB
oss-experimental/react-server/cjs/react-server.development.js +1.70% 142.71 kB 145.14 kB +1.84% 35.58 kB 36.24 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.min.js +1.14% 54.65 kB 55.27 kB +1.60% 16.74 kB 17.01 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.min.js +1.14% 54.67 kB 55.30 kB +1.60% 16.76 kB 17.03 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js +1.13% 55.06 kB 55.68 kB +1.63% 16.91 kB 17.19 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.min.js +1.13% 55.15 kB 55.77 kB +1.52% 17.45 kB 17.72 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.min.js +1.13% 55.17 kB 55.80 kB +1.51% 17.47 kB 17.74 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js +1.12% 55.56 kB 56.18 kB +1.54% 17.62 kB 17.89 kB
oss-experimental/react-dom/cjs/react-dom-static.node.production.min.js +1.12% 55.56 kB 56.19 kB +1.52% 17.62 kB 17.88 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.89% 120.43 kB 121.50 kB +1.48% 23.63 kB 23.98 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.81% 318.13 kB 320.70 kB +0.94% 71.48 kB 72.15 kB
facebook-www/ReactDOMServer-dev.modern.js +0.79% 322.65 kB 325.21 kB +0.94% 72.50 kB 73.18 kB
facebook-www/ReactDOMServer-dev.classic.js +0.78% 329.35 kB 331.91 kB +0.93% 73.93 kB 74.61 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.78% 312.76 kB 315.19 kB +0.92% 71.81 kB 72.47 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.78% 312.78 kB 315.21 kB +0.91% 71.83 kB 72.49 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.development.js +0.78% 313.38 kB 315.81 kB +0.91% 72.00 kB 72.66 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.78% 313.55 kB 315.98 kB +0.92% 71.61 kB 72.27 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.78% 313.57 kB 316.01 kB +0.91% 71.64 kB 72.29 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.78% 313.92 kB 316.35 kB +0.92% 71.74 kB 72.40 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.77% 313.95 kB 316.38 kB +0.92% 71.76 kB 72.42 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.77% 314.08 kB 316.51 kB +0.90% 72.20 kB 72.85 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.77% 314.87 kB 317.30 kB +0.91% 71.99 kB 72.65 kB
oss-experimental/react-dom/cjs/react-dom-static.node.development.js +0.77% 315.20 kB 317.63 kB +0.91% 72.22 kB 72.87 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.77% 315.24 kB 317.67 kB +0.91% 72.12 kB 72.78 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js +0.77% 315.26 kB 317.69 kB +0.92% 72.08 kB 72.74 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js +0.77% 315.28 kB 317.71 kB +0.92% 72.10 kB 72.76 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +0.77% 316.58 kB 319.01 kB +0.91% 72.46 kB 73.12 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js +0.76% 328.04 kB 330.54 kB +0.89% 72.57 kB 73.22 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js +0.76% 328.07 kB 330.56 kB +0.88% 72.60 kB 73.24 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js +0.76% 328.85 kB 331.34 kB +0.90% 72.38 kB 73.04 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js +0.76% 328.87 kB 331.37 kB +0.90% 72.41 kB 73.06 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js +0.76% 329.44 kB 331.94 kB +0.87% 72.95 kB 73.59 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js +0.76% 330.25 kB 332.74 kB +0.88% 72.77 kB 73.41 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js +0.55% 98.48 kB 99.02 kB +0.65% 30.29 kB 30.49 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js +0.55% 98.50 kB 99.05 kB +0.65% 30.29 kB 30.49 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js +0.55% 98.56 kB 99.11 kB +0.66% 30.33 kB 30.53 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js +0.55% 98.72 kB 99.26 kB +0.64% 30.71 kB 30.90 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js +0.55% 98.74 kB 99.29 kB +0.65% 30.71 kB 30.90 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js +0.55% 98.80 kB 99.35 kB +0.64% 30.74 kB 30.94 kB
facebook-www/ReactDOMServer-prod.modern.js +0.53% 116.20 kB 116.81 kB +0.52% 22.57 kB 22.69 kB
facebook-www/ReactDOMServer-prod.classic.js +0.51% 119.33 kB 119.94 kB +0.55% 23.21 kB 23.33 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.39% 746.15 kB 749.04 kB +0.49% 159.72 kB 160.51 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.38% 731.98 kB 734.79 kB +0.50% 158.13 kB 158.92 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.38% 732.00 kB 734.82 kB +0.50% 158.16 kB 158.95 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.38% 732.11 kB 734.92 kB +0.50% 158.19 kB 158.99 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.38% 753.84 kB 756.73 kB +0.49% 162.37 kB 163.17 kB
oss-stable/react-art/cjs/react-art.development.js +0.38% 753.87 kB 756.76 kB +0.49% 162.40 kB 163.19 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js +0.38% 766.89 kB 769.81 kB +0.48% 159.79 kB 160.56 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +0.38% 766.91 kB 769.84 kB +0.48% 159.81 kB 160.58 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +0.38% 767.02 kB 769.94 kB +0.48% 159.85 kB 160.62 kB
oss-experimental/react-art/cjs/react-art.development.js +0.38% 761.67 kB 764.56 kB +0.48% 163.85 kB 164.63 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.38% 762.39 kB 765.28 kB +0.48% 162.92 kB 163.71 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.38% 762.39 kB 765.28 kB +0.48% 162.92 kB 163.71 kB
react-native/implementations/ReactFabric-dev.js +0.36% 824.71 kB 827.65 kB +0.43% 178.69 kB 179.45 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.35% 834.25 kB 837.19 kB +0.42% 181.14 kB 181.91 kB
oss-stable-semver/react-art/umd/react-art.development.js +0.35% 860.59 kB 863.58 kB +0.43% 180.57 kB 181.35 kB
oss-stable/react-art/umd/react-art.development.js +0.35% 860.61 kB 863.61 kB +0.43% 180.59 kB 181.37 kB
facebook-www/ReactART-dev.modern.js +0.35% 854.61 kB 857.58 kB +0.42% 180.06 kB 180.82 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.35% 832.78 kB 835.67 kB +0.46% 176.56 kB 177.37 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.35% 832.80 kB 835.69 kB +0.46% 176.58 kB 177.39 kB
oss-experimental/react-art/umd/react-art.development.js +0.35% 868.86 kB 871.85 kB +0.44% 182.02 kB 182.82 kB
react-native/implementations/ReactFabric-dev.fb.js +0.34% 862.91 kB 865.88 kB +0.45% 185.97 kB 186.81 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.34% 840.61 kB 843.50 kB +0.45% 178.03 kB 178.82 kB
facebook-www/ReactART-dev.classic.js +0.34% 864.93 kB 867.90 kB +0.42% 182.12 kB 182.89 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.34% 872.43 kB 875.40 kB +0.43% 188.42 kB 189.23 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.production.min.js +0.28% 50.41 kB 50.55 kB +0.37% 15.49 kB 15.55 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.production.min.js +0.28% 50.43 kB 50.57 kB +0.36% 15.51 kB 15.57 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.min.js +0.28% 50.76 kB 50.90 kB +0.31% 15.67 kB 15.72 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.min.js +0.28% 51.33 kB 51.47 kB +0.38% 16.34 kB 16.40 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.min.js +0.28% 51.35 kB 51.49 kB +0.37% 16.36 kB 16.42 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.production.min.js +0.28% 51.56 kB 51.70 kB +0.36% 16.44 kB 16.50 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js +0.27% 51.68 kB 51.82 kB +0.35% 16.49 kB 16.55 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.production.min.js +0.27% 50.50 kB 50.64 kB +0.21% 15.76 kB 15.79 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.production.min.js +0.27% 50.53 kB 50.67 kB +0.20% 15.78 kB 15.81 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.production.min.js +0.26% 51.39 kB 51.53 kB +0.25% 16.58 kB 16.62 kB
oss-stable/react-dom/umd/react-dom-server.browser.production.min.js +0.26% 51.41 kB 51.55 kB +0.24% 16.60 kB 16.64 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.production.min.js +0.26% 50.86 kB 50.99 kB +0.30% 15.90 kB 15.95 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js +0.26% 51.74 kB 51.88 kB +0.26% 16.71 kB 16.76 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js +0.25% 1,178.38 kB 1,181.27 kB +0.32% 260.90 kB 261.73 kB
oss-stable/react-dom/cjs/react-dom.development.js +0.25% 1,178.41 kB 1,181.29 kB +0.32% 260.93 kB 261.75 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.24% 1,180.90 kB 1,183.79 kB +0.31% 261.01 kB 261.82 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.24% 1,188.45 kB 1,191.34 kB +0.31% 262.92 kB 263.72 kB
oss-stable-semver/react-dom/umd/react-dom.development.js +0.24% 1,235.87 kB 1,238.87 kB +0.31% 263.70 kB 264.51 kB
oss-stable/react-dom/umd/react-dom.development.js +0.24% 1,235.90 kB 1,238.90 kB +0.31% 263.73 kB 264.54 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.24% 1,180.71 kB 1,183.56 kB +0.30% 261.37 kB 262.16 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.24% 1,246.50 kB 1,249.50 kB +0.30% 265.73 kB 266.53 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.24% 1,210.78 kB 1,213.66 kB +0.31% 266.83 kB 267.66 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.24% 284.03 kB 284.70 kB +0.61% 50.43 kB 50.73 kB
facebook-www/ReactDOMForked-dev.modern.js +0.23% 1,307.82 kB 1,310.79 kB +0.28% 283.87 kB 284.66 kB
facebook-www/ReactDOM-dev.modern.js +0.23% 1,307.82 kB 1,310.79 kB +0.28% 283.87 kB 284.66 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.22% 299.62 kB 300.29 kB +0.55% 52.81 kB 53.10 kB
facebook-www/ReactDOMForked-dev.classic.js +0.22% 1,332.68 kB 1,335.64 kB +0.27% 288.40 kB 289.20 kB
facebook-www/ReactDOM-dev.classic.js +0.22% 1,332.68 kB 1,335.65 kB +0.27% 288.40 kB 289.20 kB
react-native/implementations/ReactFabric-prod.js +0.21% 311.92 kB 312.59 kB +0.50% 55.43 kB 55.71 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.21% 318.62 kB 319.29 kB +0.49% 56.49 kB 56.76 kB
react-native/implementations/ReactFabric-prod.fb.js +0.21% 322.66 kB 323.33 kB +0.47% 57.52 kB 57.79 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.20% 329.36 kB 330.03 kB +0.46% 58.56 kB 58.83 kB
react-native/implementations/ReactFabric-profiling.js +0.20% 331.02 kB 331.68 kB +0.50% 58.58 kB 58.87 kB

Generated by 🚫 dangerJS against da38d04

@acdlite acdlite marked this pull request as ready for review October 23, 2022 04:46
@acdlite acdlite force-pushed the opaque-suspense-exception branch 4 times, most recently from bbf867b to 4f8c2da Compare October 24, 2022 03:24
The old (unstable) mechanism for suspending was to throw a promise. The
purpose of throwing is to interrupt the component's execution, and also
to signal to React that the interruption was caused by Suspense as
opposed to some other error.

A flaw is that throwing is meant to be an implementation details — if
code in userspace catches the promise, it can lead to
unexpected behavior.

With `use`, userspace code does not throw promises directly, but `use`
itself still needs to throw something to interrupt the component and
unwind the stack.

The solution is to throw an internal error. In development, we can
detect whether the error was caught by a userspace try/catch block and
log a warning — though it's not foolproof, since a clever user could
catch the object and rethrow it later.

The error message includes advice to move `use` outside of the
try/catch block.

I did not yet implement the warning in Flight.
@acdlite acdlite merged commit d2a0176 into facebook:main Oct 28, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Nov 1, 2022
Summary:
This sync includes the following changes:
- **[ab075a232](facebook/react@ab075a232 )**: Do not unmount layout effects on initial Offscreen mount ([#25592](facebook/react#25592)) //<Samuel Susla>//
- **[765805bf8](facebook/react@765805bf8 )**: Fix type check for null ([#25595](facebook/react#25595)) //<Sebastian Markbåge>//
- **[2ac77aab9](facebook/react@2ac77aab9 )**: Clean up vestige of useOpaqueIdentifier ([#25587](facebook/react#25587)) //<Andrew Clark>//
- **[bdd3d0807](facebook/react@bdd3d0807 )**: Extract logic for detecting bad fallback to helper //<Andrew Clark>//
- **[952dfff3f](facebook/react@952dfff3f )**: Split suspended work loop logic into separate functions //<Andrew Clark>//
- **[d2c0ab10d](facebook/react@d2c0ab10d )**: In work loop, add enum of reasons for suspending //<Andrew Clark>//
- **[5450dd409](facebook/react@5450dd409 )**: Strict Mode: Reuse memoized result from first pass ([#25583](facebook/react#25583)) //<Andrew Clark>//
- **[d2a0176a1](facebook/react@d2a0176a1 )**: Detect and warn if use(promise) is wrapped with try/catch block ([#25543](facebook/react#25543)) //<Andrew Clark>//
- **[cf3932be5](facebook/react@cf3932be5 )**: Remove old react-fetch, react-fs and react-pg libraries ([#25577](facebook/react#25577)) //<Sebastian Markbåge>//
- **[28a574ea8](facebook/react@28a574ea8 )**: Try assigning fetch to globalThis if global assignment fails ([#25571](facebook/react#25571)) //<Sebastian Markbåge>//
- **[09def5990](facebook/react@09def5990 )**: [Float] handle noscript context for Resources ([#25559](facebook/react#25559)) //<Josh Story>//
- **[17204056d](facebook/react@17204056d )**: [Float] fix coordination of resource identity and hydration ([#25569](facebook/react#25569)) //<Josh Story>//
- **[d925a8d0b](facebook/react@d925a8d0b )**: Flight client error stack ([#25560](facebook/react#25560)) //<Josh Story>//
- **[996b00b78](facebook/react@996b00b78 )**: [Tiny] Fixed incorrect import in `react-server-dom-webpack` ([#25554](facebook/react#25554)) //<Leo Lamprecht>//
- **[e7c5af45c](facebook/react@e7c5af45c )**: Update cache() and use() to the canary aka next channel ([#25502](facebook/react#25502)) //<Sebastian Markbåge>//
- **[fa77f52e7](facebook/react@fa77f52e7 )**: Unify promise switch statements //<Andrew Clark>//
- **[7572e4931](facebook/react@7572e4931 )**: Track thenable state in work loop //<Andrew Clark>//
- **[7fc3eefd8](facebook/react@7fc3eefd8 )**: Revert yieldy behavior for non-use Suspense (in Flight, too) //<Andrew Clark>//
- **[61f9b5e97](facebook/react@61f9b5e97 )**: [Float] support <base> as Resource ([#25546](facebook/react#25546)) //<Josh Story>//
- **[1d3fc9c9c](facebook/react@1d3fc9c9c )**: Bug fix when resolving cache ([#25545](facebook/react#25545)) //<Sebastian Markbåge>//
- **[cce18e350](facebook/react@cce18e350 )**: [Flight] Use AsyncLocalStorage to extend the scope of the cache to micro tasks ([#25542](facebook/react#25542)) //<Sebastian Markbåge>//
- **[caa84c8da](facebook/react@caa84c8da )**: Revert fetch instrumentation to only RSC ([#25540](facebook/react#25540)) //<Sebastian Markbåge>//
- **[0c11baa6a](facebook/react@0c11baa6a )**: add warnings for non-resources rendered outside body or head ([#25532](facebook/react#25532)) //<Josh Story>//
- **[9236abdb5](facebook/react@9236abdb5 )**: when float is enabled only push title and script as a single unit ([#25536](facebook/react#25536)) //<Josh Story>//
- **[dd5c20825](facebook/react@dd5c20825 )**: Revert yieldy behavior for non-use Suspense ([#25537](facebook/react#25537)) //<Andrew Clark>//
- **[934177598](facebook/react@934177598 )**: fix transposed escape functions ([#25534](facebook/react#25534)) //<Josh Story>//
- **[d1ced9fd5](facebook/react@d1ced9fd5 )**: [Float] support all links as Resources ([#25515](facebook/react#25515)) //<Josh Story>//
- **[973b90bdf](facebook/react@973b90bdf )**: [Float] support meta tags as Resources ([#25514](facebook/react#25514)) //<Josh Story>//
- **[79c582981](facebook/react@79c582981 )**: Let ReactDOM initialize in RSC ([#25503](facebook/react#25503)) //<Sebastian Markbåge>//
- **[1f7a2f577](facebook/react@1f7a2f577 )**: [Float] support title tags as Resources ([#25508](facebook/react#25508)) //<Josh Story>//
- **[c63580787](facebook/react@c63580787 )**: Support `use` in `act` testing API ([#25523](facebook/react#25523)) //<Andrew Clark>//
- **[65e32e58b](facebook/react@65e32e58b )**: Add fetch Instrumentation to Dedupe Fetches ([#25516](facebook/react#25516)) //<Sebastian Markbåge>//
- **[9336e29d9](facebook/react@9336e29d9 )**: [useEvent] Lint for presence of useEvent functions in dependency lists ([#25512](facebook/react#25512)) //<lauren>//
- **[3cc792bfb](facebook/react@3cc792bfb )**: [useEvent] Non-stable function identity ([#25473](facebook/react#25473)) //<lauren>//
- **[987292815](facebook/react@987292815 )**: Remove feature flag enableStrictEffects ([#25387](facebook/react#25387)) //<Samuel Susla>//
- **[8e2bde6f2](facebook/react@8e2bde6f2 )**: Add cache() API ([#25506](facebook/react#25506)) //<Sebastian Markbåge>//
- **[9cdf8a99e](facebook/react@9cdf8a99e )**: [Codemod] Update copyright header to Meta ([#25315](facebook/react#25315)) //<Andrew Clark>//
- **[e54015e26](facebook/react@e54015e26 )**: Refactor: fill in the flow missing type ([#25496](facebook/react#25496)) //<c0dedance>//
- **[3b1fd5767](facebook/react@3b1fd5767 )**: refactor: Flow: typing of Scheduler ([#25485](facebook/react#25485)) //<bubucuo>//
- **[14072ce64](facebook/react@14072ce64 )**: Add detach to Offscreen component ([#25265](facebook/react#25265)) //<Samuel Susla>//
- **[3bb71dfd4](facebook/react@3bb71dfd4 )**: Rename react-server-dom-webpack entry points to /client and /server ([#25504](facebook/react#25504)) //<Sebastian Markbåge>//
- **[71f2c8cf1](facebook/react@71f2c8cf1 )**: move resource acquisition to mutation phase ([#25500](facebook/react#25500)) //<Josh Story>//
- **[500bea532](facebook/react@500bea532 )**: Add option to load Fizz runtime from external file ([#25499](facebook/react#25499)) //<Andrew Clark>//
- **[4494f2a86](facebook/react@4494f2a86 )**: [Float] add support for scripts and other enhancements ([#25480](facebook/react#25480)) //<Josh Story>//
- **[9ecf84ed7](facebook/react@9ecf84ed7 )**: Bugfix: Suspending in shell during discrete update ([#25495](facebook/react#25495)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 54f297a...ab075a2

jest_e2e[run_all_tests]

Reviewed By: kassens

Differential Revision: D40897093

fbshipit-source-id: 6a040315834dea5c0ab994ea94d91f5605b9d6b0
GrinZero added a commit to GrinZero/react that referenced this pull request Nov 7, 2022
* 'main' of ssh://github.com/GrinZero/react: (163 commits)
  Do not unmount layout effects if ancestor Offscreen is hidden (facebook#25628)
  Remove check in renderDidSuspendDelayIfPossible (facebook#25630)
  [ServerRenderer] Move fizz external runtime implementation to react-dom-bindings (facebook#25617)
  Unwrap sync resolved thenables without suspending  (facebook#25615)
  refactor isHostResourceType to not receive the context from reconciler and not leak types (facebook#25610)
  Make host context use null as empty and only error in dev (facebook#25609)
  [Float] handle resource Resource creation inside svg context (facebook#25599)
  Allow uncached IO to stablize (facebook#25561)
  [ServerRenderer] Setup for adding data attributes streaming format (facebook#25567)
  Do not unmount layout effects on initial Offscreen mount (facebook#25592)
  Fix type check for null (facebook#25595)
  Clean up vestige of useOpaqueIdentifier (facebook#25587)
  Extract logic for detecting bad fallback to helper
  Split suspended work loop logic into separate functions
  In work loop, add enum of reasons for suspending
  Strict Mode: Reuse memoized result from first pass (facebook#25583)
  Detect and warn if use(promise) is wrapped with try/catch block (facebook#25543)
  Remove old react-fetch, react-fs and react-pg libraries (facebook#25577)
  Try assigning fetch to globalThis if global assignment fails (facebook#25571)
  [Float] handle noscript context for Resources (facebook#25559)
  ...

# Conflicts:
#	scripts/rollup/build.js
rickhanlonii pushed a commit that referenced this pull request Dec 3, 2022
The old (unstable) mechanism for suspending was to throw a promise. The
purpose of throwing is to interrupt the component's execution, and also
to signal to React that the interruption was caused by Suspense as
opposed to some other error.

A flaw is that throwing is meant to be an implementation detail — if
code in userspace catches the promise, it can lead to unexpected
behavior.

With `use`, userspace code does not throw promises directly, but `use`
itself still needs to throw something to interrupt the component and
unwind the stack.

The solution is to throw an internal error. In development, we can
detect whether the error was caught by a userspace try/catch block and
log a warning — though it's not foolproof, since a clever user could
catch the object and rethrow it later.

The error message includes advice to move `use` outside of the try/catch
block.

I did not yet implement the warning in Flight.
acdlite added a commit to acdlite/react that referenced this pull request Dec 5, 2022
…ck (facebook#25543)"

This reverts commit d2a0176.

The old (unstable) mechanism for suspending was to throw a promise. The
purpose of throwing is to interrupt the component's execution, and also
to signal to React that the interruption was caused by Suspense as
opposed to some other error.

A flaw is that throwing is meant to be an implementation detail — if
code in userspace catches the promise, it can lead to unexpected
behavior.

With `use`, userspace code does not throw promises directly, but `use`
itself still needs to throw something to interrupt the component and
unwind the stack.

The solution is to throw an internal error. In development, we can
detect whether the error was caught by a userspace try/catch block and
log a warning — though it's not foolproof, since a clever user could
catch the object and rethrow it later.

The error message includes advice to move `use` outside of the try/catch
block.

I did not yet implement the warning in Flight.
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
This sync includes the following changes:
- **[ab075a232](facebook/react@ab075a232 )**: Do not unmount layout effects on initial Offscreen mount ([facebook#25592](facebook/react#25592)) //<Samuel Susla>//
- **[765805bf8](facebook/react@765805bf8 )**: Fix type check for null ([facebook#25595](facebook/react#25595)) //<Sebastian Markbåge>//
- **[2ac77aab9](facebook/react@2ac77aab9 )**: Clean up vestige of useOpaqueIdentifier ([facebook#25587](facebook/react#25587)) //<Andrew Clark>//
- **[bdd3d0807](facebook/react@bdd3d0807 )**: Extract logic for detecting bad fallback to helper //<Andrew Clark>//
- **[952dfff3f](facebook/react@952dfff3f )**: Split suspended work loop logic into separate functions //<Andrew Clark>//
- **[d2c0ab10d](facebook/react@d2c0ab10d )**: In work loop, add enum of reasons for suspending //<Andrew Clark>//
- **[5450dd409](facebook/react@5450dd409 )**: Strict Mode: Reuse memoized result from first pass ([facebook#25583](facebook/react#25583)) //<Andrew Clark>//
- **[d2a0176a1](facebook/react@d2a0176a1 )**: Detect and warn if use(promise) is wrapped with try/catch block ([facebook#25543](facebook/react#25543)) //<Andrew Clark>//
- **[cf3932be5](facebook/react@cf3932be5 )**: Remove old react-fetch, react-fs and react-pg libraries ([facebook#25577](facebook/react#25577)) //<Sebastian Markbåge>//
- **[28a574ea8](facebook/react@28a574ea8 )**: Try assigning fetch to globalThis if global assignment fails ([facebook#25571](facebook/react#25571)) //<Sebastian Markbåge>//
- **[09def5990](facebook/react@09def5990 )**: [Float] handle noscript context for Resources ([facebook#25559](facebook/react#25559)) //<Josh Story>//
- **[17204056d](facebook/react@17204056d )**: [Float] fix coordination of resource identity and hydration ([facebook#25569](facebook/react#25569)) //<Josh Story>//
- **[d925a8d0b](facebook/react@d925a8d0b )**: Flight client error stack ([facebook#25560](facebook/react#25560)) //<Josh Story>//
- **[996b00b78](facebook/react@996b00b78 )**: [Tiny] Fixed incorrect import in `react-server-dom-webpack` ([facebook#25554](facebook/react#25554)) //<Leo Lamprecht>//
- **[e7c5af45c](facebook/react@e7c5af45c )**: Update cache() and use() to the canary aka next channel ([facebook#25502](facebook/react#25502)) //<Sebastian Markbåge>//
- **[fa77f52e7](facebook/react@fa77f52e7 )**: Unify promise switch statements //<Andrew Clark>//
- **[7572e4931](facebook/react@7572e4931 )**: Track thenable state in work loop //<Andrew Clark>//
- **[7fc3eefd8](facebook/react@7fc3eefd8 )**: Revert yieldy behavior for non-use Suspense (in Flight, too) //<Andrew Clark>//
- **[61f9b5e97](facebook/react@61f9b5e97 )**: [Float] support <base> as Resource ([facebook#25546](facebook/react#25546)) //<Josh Story>//
- **[1d3fc9c9c](facebook/react@1d3fc9c9c )**: Bug fix when resolving cache ([facebook#25545](facebook/react#25545)) //<Sebastian Markbåge>//
- **[cce18e350](facebook/react@cce18e350 )**: [Flight] Use AsyncLocalStorage to extend the scope of the cache to micro tasks ([facebook#25542](facebook/react#25542)) //<Sebastian Markbåge>//
- **[caa84c8da](facebook/react@caa84c8da )**: Revert fetch instrumentation to only RSC ([facebook#25540](facebook/react#25540)) //<Sebastian Markbåge>//
- **[0c11baa6a](facebook/react@0c11baa6a )**: add warnings for non-resources rendered outside body or head ([facebook#25532](facebook/react#25532)) //<Josh Story>//
- **[9236abdb5](facebook/react@9236abdb5 )**: when float is enabled only push title and script as a single unit ([facebook#25536](facebook/react#25536)) //<Josh Story>//
- **[dd5c20825](facebook/react@dd5c20825 )**: Revert yieldy behavior for non-use Suspense ([facebook#25537](facebook/react#25537)) //<Andrew Clark>//
- **[934177598](facebook/react@934177598 )**: fix transposed escape functions ([facebook#25534](facebook/react#25534)) //<Josh Story>//
- **[d1ced9fd5](facebook/react@d1ced9fd5 )**: [Float] support all links as Resources ([facebook#25515](facebook/react#25515)) //<Josh Story>//
- **[973b90bdf](facebook/react@973b90bdf )**: [Float] support meta tags as Resources ([facebook#25514](facebook/react#25514)) //<Josh Story>//
- **[79c582981](facebook/react@79c582981 )**: Let ReactDOM initialize in RSC ([facebook#25503](facebook/react#25503)) //<Sebastian Markbåge>//
- **[1f7a2f577](facebook/react@1f7a2f577 )**: [Float] support title tags as Resources ([facebook#25508](facebook/react#25508)) //<Josh Story>//
- **[c63580787](facebook/react@c63580787 )**: Support `use` in `act` testing API ([facebook#25523](facebook/react#25523)) //<Andrew Clark>//
- **[65e32e58b](facebook/react@65e32e58b )**: Add fetch Instrumentation to Dedupe Fetches ([facebook#25516](facebook/react#25516)) //<Sebastian Markbåge>//
- **[9336e29d9](facebook/react@9336e29d9 )**: [useEvent] Lint for presence of useEvent functions in dependency lists ([facebook#25512](facebook/react#25512)) //<lauren>//
- **[3cc792bfb](facebook/react@3cc792bfb )**: [useEvent] Non-stable function identity ([facebook#25473](facebook/react#25473)) //<lauren>//
- **[987292815](facebook/react@987292815 )**: Remove feature flag enableStrictEffects ([facebook#25387](facebook/react#25387)) //<Samuel Susla>//
- **[8e2bde6f2](facebook/react@8e2bde6f2 )**: Add cache() API ([facebook#25506](facebook/react#25506)) //<Sebastian Markbåge>//
- **[9cdf8a99e](facebook/react@9cdf8a99e )**: [Codemod] Update copyright header to Meta ([facebook#25315](facebook/react#25315)) //<Andrew Clark>//
- **[e54015e26](facebook/react@e54015e26 )**: Refactor: fill in the flow missing type ([facebook#25496](facebook/react#25496)) //<c0dedance>//
- **[3b1fd5767](facebook/react@3b1fd5767 )**: refactor: Flow: typing of Scheduler ([facebook#25485](facebook/react#25485)) //<bubucuo>//
- **[14072ce64](facebook/react@14072ce64 )**: Add detach to Offscreen component ([facebook#25265](facebook/react#25265)) //<Samuel Susla>//
- **[3bb71dfd4](facebook/react@3bb71dfd4 )**: Rename react-server-dom-webpack entry points to /client and /server ([facebook#25504](facebook/react#25504)) //<Sebastian Markbåge>//
- **[71f2c8cf1](facebook/react@71f2c8cf1 )**: move resource acquisition to mutation phase ([facebook#25500](facebook/react#25500)) //<Josh Story>//
- **[500bea532](facebook/react@500bea532 )**: Add option to load Fizz runtime from external file ([facebook#25499](facebook/react#25499)) //<Andrew Clark>//
- **[4494f2a86](facebook/react@4494f2a86 )**: [Float] add support for scripts and other enhancements ([facebook#25480](facebook/react#25480)) //<Josh Story>//
- **[9ecf84ed7](facebook/react@9ecf84ed7 )**: Bugfix: Suspending in shell during discrete update ([facebook#25495](facebook/react#25495)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 54f297a...ab075a2

jest_e2e[run_all_tests]

Reviewed By: kassens

Differential Revision: D40897093

fbshipit-source-id: 6a040315834dea5c0ab994ea94d91f5605b9d6b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants