Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServerRenderer] Add option to send instructions as data attributes #25437

Merged
merged 13 commits into from
Nov 30, 2022

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Oct 5, 2022

Changes made:

  • Running with enableFizzExternalRuntime (feature flag) and unstable_externalRuntimeSrc (param) will generate html nodes with data attributes that encode Fizz instructions.
<div 
  hidden data-rxi=""
  data-bid="param0"
  data-dgst="param1"
></div>
  • Added an external runtime browser script ReactDOMServerExternalRuntime, which processes and removes these nodes
    • This runtime should be passed as to renderInto[...] via unstable_externalRuntimeSrc
    • Since this runtime is render blocking (for all streamed suspense boundaries and segments), we want this to reach the client as early as possible. By default, Fizz will send this script at the end of the shell when it detects dynamic content (e.g. suspenseful pending tasks), but it can be sent even earlier by calling preinit(...) inside a component.
  • The current implementation relies on Float to dedupe sending unstable_externalRuntimeSrc, so enableFizzExternalRuntime is only valid when enableFloat is also set.

What's left (done)

  • Add enableFizzExternalRuntime as an entrypoint parameter
  • Add a MutationObserver implementation
  • Add ^ to test setup (when using Meta's feature flags)

Summary

How did you test this change?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 5, 2022
@sizebot
Copy link

sizebot commented Oct 5, 2022

Comparing: e982254...f35926f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.55 kB 154.55 kB = 49.05 kB 49.04 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.47 kB 156.47 kB = 49.67 kB 49.67 kB
facebook-www/ReactDOM-prod.classic.js = 533.67 kB 533.67 kB = 94.54 kB 94.54 kB
facebook-www/ReactDOM-prod.modern.js = 518.77 kB 518.77 kB = 92.35 kB 92.35 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.67 kB 533.67 kB = 94.54 kB 94.54 kB
oss-experimental/react-dom/unstable_server-external-runtime.js +65.66% 1.52 kB 2.51 kB +55.60% 0.73 kB 1.14 kB
oss-stable-semver/react-dom/unstable_server-external-runtime.js +65.66% 1.52 kB 2.51 kB +55.60% 0.73 kB 1.14 kB
oss-stable/react-dom/unstable_server-external-runtime.js +65.66% 1.52 kB 2.51 kB +55.60% 0.73 kB 1.14 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +5.57% 121.77 kB 128.56 kB +2.84% 24.02 kB 24.70 kB
facebook-www/ReactDOMServer-prod.modern.js +5.43% 117.08 kB 123.43 kB +2.87% 22.73 kB 23.39 kB
facebook-www/ReactDOMServer-prod.classic.js +5.29% 120.22 kB 126.57 kB +2.73% 23.37 kB 24.01 kB
facebook-www/ReactDOMServer-dev.modern.js +3.19% 326.42 kB 336.82 kB +2.15% 73.39 kB 74.96 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +3.16% 321.90 kB 332.07 kB +2.10% 72.36 kB 73.88 kB
facebook-www/ReactDOMServer-dev.classic.js +3.12% 333.11 kB 343.52 kB +2.10% 74.82 kB 76.39 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/unstable_server-external-runtime.js +65.66% 1.52 kB 2.51 kB +55.60% 0.73 kB 1.14 kB
oss-stable-semver/react-dom/unstable_server-external-runtime.js +65.66% 1.52 kB 2.51 kB +55.60% 0.73 kB 1.14 kB
oss-stable/react-dom/unstable_server-external-runtime.js +65.66% 1.52 kB 2.51 kB +55.60% 0.73 kB 1.14 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +5.57% 121.77 kB 128.56 kB +2.84% 24.02 kB 24.70 kB
facebook-www/ReactDOMServer-prod.modern.js +5.43% 117.08 kB 123.43 kB +2.87% 22.73 kB 23.39 kB
facebook-www/ReactDOMServer-prod.classic.js +5.29% 120.22 kB 126.57 kB +2.73% 23.37 kB 24.01 kB
facebook-www/ReactDOMServer-dev.modern.js +3.19% 326.42 kB 336.82 kB +2.15% 73.39 kB 74.96 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +3.16% 321.90 kB 332.07 kB +2.10% 72.36 kB 73.88 kB
facebook-www/ReactDOMServer-dev.classic.js +3.12% 333.11 kB 343.52 kB +2.10% 74.82 kB 76.39 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +1.25% 22.56 kB 22.84 kB +0.82% 8.02 kB 8.09 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +1.25% 22.56 kB 22.84 kB +0.82% 8.02 kB 8.09 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +1.25% 22.60 kB 22.89 kB +0.85% 8.04 kB 8.11 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +1.24% 22.75 kB 23.03 kB +0.79% 8.12 kB 8.19 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +1.24% 22.75 kB 23.03 kB +0.79% 8.12 kB 8.19 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +1.24% 22.79 kB 23.07 kB +0.79% 8.14 kB 8.20 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.23% 22.93 kB 23.22 kB +0.83% 8.11 kB 8.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.23% 22.93 kB 23.22 kB +0.83% 8.11 kB 8.17 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +1.23% 22.98 kB 23.26 kB +0.81% 8.12 kB 8.19 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +1.11% 83.57 kB 84.50 kB +0.69% 20.99 kB 21.14 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +1.11% 83.57 kB 84.50 kB +0.69% 20.99 kB 21.14 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +1.11% 83.63 kB 84.56 kB +0.69% 21.01 kB 21.16 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +1.09% 84.82 kB 85.75 kB +0.67% 21.07 kB 21.21 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +1.09% 84.82 kB 85.75 kB +0.67% 21.07 kB 21.21 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +1.09% 84.88 kB 85.81 kB +0.66% 21.09 kB 21.23 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +1.08% 87.76 kB 88.71 kB +0.70% 21.24 kB 21.39 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +1.08% 87.76 kB 88.71 kB +0.70% 21.24 kB 21.39 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +1.08% 87.82 kB 88.77 kB +0.69% 21.27 kB 21.41 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.87% 317.01 kB 319.77 kB +1.06% 72.88 kB 73.65 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.87% 317.03 kB 319.79 kB +1.05% 72.90 kB 73.67 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.development.js +0.87% 317.63 kB 320.39 kB +1.04% 73.07 kB 73.83 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js +0.87% 332.42 kB 335.31 kB +1.05% 73.63 kB 74.41 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js +0.87% 332.44 kB 335.34 kB +1.05% 73.66 kB 74.43 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.87% 318.23 kB 321.00 kB +1.06% 72.82 kB 73.59 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.87% 318.26 kB 321.02 kB +1.05% 72.85 kB 73.61 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.87% 318.32 kB 321.09 kB +1.05% 73.25 kB 74.02 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js +0.87% 333.82 kB 336.71 kB +1.05% 74.00 kB 74.78 kB
oss-experimental/react-dom/cjs/react-dom-static.node.development.js +0.87% 319.51 kB 322.27 kB +1.04% 73.29 kB 74.05 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.87% 319.55 kB 322.31 kB +1.04% 73.20 kB 73.96 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.production.min.js +0.71% 51.66 kB 52.02 kB +1.10% 16.67 kB 16.85 kB
oss-stable/react-dom/umd/react-dom-server.browser.production.min.js +0.71% 51.68 kB 52.05 kB +1.11% 16.69 kB 16.87 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js +0.71% 52.00 kB 52.37 kB +1.11% 16.80 kB 16.99 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.min.js +0.69% 51.60 kB 51.95 kB +0.69% 16.42 kB 16.54 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.min.js +0.69% 51.62 kB 51.98 kB +0.69% 16.45 kB 16.56 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.production.min.js +0.68% 51.83 kB 52.18 kB +0.68% 16.53 kB 16.64 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js +0.68% 51.95 kB 52.30 kB +0.69% 16.58 kB 16.69 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js +0.67% 332.55 kB 334.78 kB +0.96% 73.26 kB 73.96 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js +0.67% 332.57 kB 334.80 kB +0.96% 73.28 kB 73.98 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.67% 317.14 kB 319.26 kB +0.95% 72.48 kB 73.17 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.67% 317.16 kB 319.28 kB +0.95% 72.51 kB 73.20 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js +0.67% 333.95 kB 336.18 kB +0.96% 73.63 kB 74.33 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.67% 318.46 kB 320.58 kB +0.95% 72.86 kB 73.55 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js +0.66% 318.85 kB 320.97 kB +0.94% 72.95 kB 73.64 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js +0.66% 318.87 kB 320.99 kB +0.94% 72.97 kB 73.66 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +0.66% 320.17 kB 322.29 kB +0.94% 73.33 kB 74.01 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.min.js +0.64% 55.90 kB 56.26 kB +0.66% 17.75 kB 17.86 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.min.js +0.63% 55.92 kB 56.28 kB +0.65% 17.77 kB 17.88 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js +0.63% 56.31 kB 56.67 kB +0.59% 17.92 kB 18.03 kB
oss-experimental/react-dom/cjs/react-dom-static.node.production.min.js +0.63% 56.32 kB 56.67 kB +0.57% 17.92 kB 18.02 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js +0.61% 314.66 kB 316.58 kB +0.87% 72.14 kB 72.76 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js +0.61% 314.69 kB 316.61 kB +0.86% 72.16 kB 72.78 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js +0.61% 315.98 kB 317.90 kB +0.87% 72.51 kB 73.14 kB

Generated by 🚫 dangerJS against f35926f

@mofeiZ mofeiZ requested review from sebmarkbage and acdlite October 5, 2022 22:13
@@ -135,14 +168,15 @@ describe('ReactDOMFizzServer', () => {
while (fakeBody.firstChild) {
const node = fakeBody.firstChild;
if (
node.nodeName === 'SCRIPT' &&
(node.nodeName === 'SCRIPT' || node.nodeName === 'script') &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the lower case needed? These always get uppercased by the DOM, right?

script.textContent = node.textContent;
fakeBody.removeChild(node);
parent.appendChild(script);
} else {
replaceScripts(node);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this doing? It looks like it's just doing the same thing as above but recursively?

We can kind of assume that the script tags are always inserted in the body since that what we do.

(CSPnonce === null || node.getAttribute('nonce') === CSPnonce)
) {
const script = document.createElement('script');
const script = document.createElement('SCRIPT');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch here is really just assuming that these are inline scripts and to get them to execute, we need to reinsert them because (for security reasons innerHTML doesn't).

What you can do is check if .src is specified and if so, fake reading the source file as source, and then injecting it as a script tag with textContent instead. That would simulate more what the browser would do here.

window.__init_instruction_observer__ = () => {
global.testDocument = document;
global.MutationObserver = jsdom.window.MutationObserver;
reactInstructionObserver = ReactDOMFizzServer.getReactDOMClientMutationObserver();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned below, we should simulate what would happen when we inject this as a <script src="..."> tag. Not getting an already initialized version of this file.

Once you add the new bundle you can read it with fs.readFileSync(require.resolve(script.src)).

writeChunk(destination, completeSegmentScript1Partial);
// <div data-attr='["$RS", "
(writerState: ScriptDataWriterState);
writeChunk(destination, dataElementStart);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting for myself and others...

Originally I was hoping that we could attach these attributes to the node added by writeStartSegment. However, I don't think that would work.

<div hidden data-attr="...">
  <div>first</div>
  <div>second</div>
</div>

In this case the mutation observer would fire when the first div was added to the tree. Whether or not the second two divs have been streamed in yet. There's also no signal when it is done.

Therefore, unfortunately I think the best we can do is emit an extra node after - like this.

Copy link
Collaborator

@sebmarkbage sebmarkbage Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For segments completing, I think we could maybe listen to any element being added to the segment and just move them as they come in. Since they're just getting added to something hidden anyway.

For boundaries completing, we'd still need a separate element regardless to know when it's safe to do the reveal.

Probably not worth the complexity to special case segments completing.

acdlite added a commit to acdlite/react that referenced this pull request Oct 10, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see facebook#25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to maintain a single source of
truth, in preparation for the new option, this commit moves the
instruction set to a separate file that is injected by the build system,
similar to a macro.

In the future, we could improve this further by running Closure on the
instruction set instead of hardcoding the output. This isn't an urgent
improvement, though, because we rarely modify the instruction set.
acdlite added a commit to acdlite/react that referenced this pull request Oct 10, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see facebook#25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to maintain a single source of
truth, in preparation for the new option, this commit moves the
instruction set to a separate file that is injected by the build system,
similar to a macro.

In the future, we could improve this further by running Closure on the
instruction set instead of hardcoding the output. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>
acdlite added a commit to acdlite/react that referenced this pull request Oct 14, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see facebook#25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to make this a bit more maintainable,
and eventually have a single source of truth, in preparation for the new option,
this commit moves the instruction set to a separate files that are imported.

In the future, we could improve this further by running Closure on the
instruction set and generating it at build time. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>
acdlite added a commit to acdlite/react that referenced this pull request Oct 14, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see facebook#25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to make this a bit more maintainable,
and eventually have a single source of truth, in preparation for the new option,
this commit moves the instruction set to a separate files that are imported.

In the future, we could improve this further by running Closure on the
instruction set and generating it at build time. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>
acdlite added a commit to acdlite/react that referenced this pull request Oct 14, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see facebook#25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to make this a bit more maintainable,
and eventually have a single source of truth, in preparation for the new option,
this commit moves the instruction set to a separate files that are imported.

In the future, we could improve this further by running Closure on the
instruction set and generating it at build time. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>
acdlite added a commit that referenced this pull request Oct 14, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see #25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to make this a bit more maintainable,
and eventually have a single source of truth, in preparation for the new option,
this commit moves the instruction set to a separate files that are imported.

In the future, we could improve this further by running Closure on the
instruction set and generating it at build time. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>

Co-authored-by: Mofei Zhang <[email protected]>
@mofeiZ mofeiZ force-pushed the fizz-add-non-execution-format branch from 8002669 to 0881b4b Compare October 19, 2022 21:51
Copy link
Contributor Author

@mofeiZ mofeiZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this up for review again (thanks @acdlite for helping me with the infra / bundling changes!)

Sorry this is such a large PR. I split out the renaming / trivial changes to the first commit, so ReactDOMFizzServer-test should be easier to review if you click past that.

Changes since last review:

  • rebased on @acdlite 's changes (mostly renaming)
  • data attribute format changed from JSON list to be unrolled strings
    data-instr="$INSTR" data-arg0="param0" data-arg1="param1" ...
    • We ultimately still are calling JSON.parse for (1) unescaping added characters and (2) style resources, whose types are lists of strings
  • Fix in ExternalRuntime: since this script may execute after some instruction tags have already arrived, we now process existing document elements

@@ -25,11 +25,14 @@ let textCache;
let window;
let document;
let writable;
let CSPnonce = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since it looks like we weren't really using this variable, but happy to add it back


renderOptions = {};
if (gate(flags => flags.enableFizzExternalRuntime)) {
renderOptions.bootstrapScriptContent =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty hacky

Since the external runtime is a standalone script (not a module), jest needs to do one of these.

  1. fork the source code (ReactDOMServerExternalRuntime.test.js)
  2. manually strip import ... from ... and inject those imported declarations as globals

I chose (2) for now, but would love to change it if there is a cleaner alternative

} else {
for (let i = 0; i < node.childNodes.length; i++) {
const inner = node.childNodes[i];
replaceScriptsAndMove(inner, null);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, we need this to be recursive since some tests stream into containers (divs inside of body). As a result, there are non top level scripts.

@mofeiZ mofeiZ force-pushed the fizz-add-non-execution-format branch 2 times, most recently from 2d1b1ce to 6facdf9 Compare October 31, 2022 21:21
@@ -355,7 +355,7 @@ const bundles = [

/******* React DOM Fizz Server External Runtime *******/
{
bundleTypes: [BROWSER_SCRIPT],
bundleTypes: [BROWSER_SCRIPT, FB_WWW_DEV, FB_WWW_PROD],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for? We shouldn't need it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need this because Comet infra will statically require this file in their bootstrap module + pass an empty string as externalRuntimeSrc (see internal diff + React sync). The external runtime then should be added into Meta's React build and synced into our repo.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I was thinking we would update the internal sync script to copy over the one used by npm. That's how we sync the ESLint plugin, for example. We're trying to trend in the direction of less FB-specific infra in the open source repo.

}

/// Typechecking code, follows from above functions
function isSuspenseBoundaryID(s) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced all these dev-only runtime type checking code is worth it. We don't even have a dev build of this module. The only time it runs is when we run our Jest tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we could enable this for dev mode internally, but happy to remove (I'm sure debugging $R instructions, should anything go wrong, probably falls on us too).

switch (instr) {
case '$RX':
clientRenderBoundaryImpl(
node.getAttribute('data-rarg0'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way we access these in the other runtime is slightly different:

const dataset = node.data
dataset["rarg0"]

See:

That would compress slightly better. But also we might as well be consistent.

Also, maybe these should use the $ prefix convention? And instead of rarg1 make it as short as possible to avoid clashes.

3-4 characters seems like enough, like $ra1, $ra2, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out dataset, will change my code to use that!

I had originally used $r. However, reading through the html spec for data attribute names (link), I think the name may need to be XML compatible. If this is the case, that would rule out $.

Happy to defer to you here though - I'm not at all familiar with specs + browser implementations

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right. I remember now that useId generates ids with : for this reason. The convention for useId is :r1: so we can do something like that:

:a0, :a1 and so on.

In a follow up, what we should do is support the identifierPrefix option. Then prepend that to all of these attributes. We can send down prefix as an attribute early in the stream. So that the external runtime knows which attributes to look for. We wanted to do that anyway so that users don't have to manually pass the prefix to hydrateRoot.

// This runtime may be sent to the client multiple times (if FizzServer.render
// is called more than once). Here, we check whether the mutation observer
// was already created / installed
if (!window.reactInstructionObserver && window.MutationObserver) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to check for the existence of MutationObserver. There's no fallback behavior so it should just hard error if it doesn't exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you're totally right, this can be moved to Meta's internal infra. Thanks for calling out the Meta-specific code in this PR

// ReactDOMFizzInstructionSet
window.$RC = completeBoundary;
window.$RM = new Map();
window.reactInstructionObserver = new MutationObserver(mutations => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reactInstructionObserver needs to be obscure, too. It's essentially a private field; should only be accessed by this module. Use the $ naming convention.

@mofeiZ mofeiZ force-pushed the fizz-add-non-execution-format branch from e0e1809 to df858fe Compare November 29, 2022 22:36
@mofeiZ mofeiZ requested a review from gnoff November 29, 2022 22:46
@mofeiZ
Copy link
Contributor Author

mofeiZ commented Nov 29, 2022

@gnoff @sebmarkbage
ping for review 🙂

const domBodyObserver = new MutationObserver(() => {
// We expect the body node to be stable once parsed / created
if (document.body) {
if (document.readyState === 'loading') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the order of DOM parsing / changing readyState - this could totally be a redundant check

Added just in case readyState gets set loading -> interactive before mutation observer listeners are triggered.

(experimented with inline scripts on my laptop's version of Chrome, but wary about other browser implementations)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know off the top of my head. seems safe enough to leave in

Copy link
Collaborator

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. i just found one new thing that I'm pretty sure is a bug or i just don't understand how mutation observers work... :)

} else {
// body may not exist yet if the fizz runtime is sent in <head>
// (e.g. as a preinit resource)
const domBodyObserver = new MutationObserver(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I am missing something but does this observer ever observe anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I can't believe I didn't call observe, thanks so much for catching this - definitely a problem.

const domBodyObserver = new MutationObserver(() => {
// We expect the body node to be stable once parsed / created
if (document.body) {
if (document.readyState === 'loading') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know off the top of my head. seems safe enough to leave in

@mofeiZ mofeiZ requested a review from gnoff November 30, 2022 03:56
@mofeiZ
Copy link
Contributor Author

mofeiZ commented Nov 30, 2022

(Sorry for the back and forth, and thanks again for the review! Once again putting this back on your queue @gnoff )

1 similar comment
@mofeiZ
Copy link
Contributor Author

mofeiZ commented Nov 30, 2022

(Sorry for the back and forth, and thanks again for the review! Once again putting this back on your queue @gnoff )

@mofeiZ mofeiZ merged commit fa11bd6 into facebook:main Nov 30, 2022
@@ -120,4 +140,59 @@ function mergeOptions(options: Object, defaultOptions: Object): Object {
};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't really need to exist. The function name is longer than the syntax to write this out. This is strictly worse since it made me look up this definition, thinking it was something more involved, but it also drops the types because it's effectively "any" typed.

}
return nodes.filter(
n =>
(n.tagName !== 'SCRIPT' && n.tagName !== 'script') ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the lower case? SVG?

#25437 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebmarkbage
I'm not sure why this is needed, but I see that tagName is sometimes lowercase. I saw some existing code like this, and didn't think too much of it.

Can look into it if it seems suggestive of a larger issue!

mofeiZ added a commit to mofeiZ/react that referenced this pull request Dec 2, 2022
…acebook#25437)

### Changes made:
- Running with enableFizzExternalRuntime (feature flag) and
unstable_externalRuntimeSrc (param) will generate html nodes with data
attributes that encode Fizz instructions.
```
<div 
  hidden data-rxi=""
  data-bid="param0"
  data-dgst="param1"
></div>
```
- Added an external runtime browser script
`ReactDOMServerExternalRuntime`, which processes and removes these nodes
- This runtime should be passed as to renderInto[...] via
`unstable_externalRuntimeSrc`
- Since this runtime is render blocking (for all streamed suspense
boundaries and segments), we want this to reach the client as early as
possible. By default, Fizz will send this script at the end of the shell
when it detects dynamic content (e.g. suspenseful pending tasks), but it
can be sent even earlier by calling `preinit(...)` inside a component.
- The current implementation relies on Float to dedupe sending
`unstable_externalRuntimeSrc`, so `enableFizzExternalRuntime` is only
valid when `enableFloat` is also set.
rickhanlonii pushed a commit that referenced this pull request Dec 3, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see #25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to make this a bit more maintainable,
and eventually have a single source of truth, in preparation for the new option,
this commit moves the instruction set to a separate files that are imported.

In the future, we could improve this further by running Closure on the
instruction set and generating it at build time. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>

Co-authored-by: Mofei Zhang <[email protected]>
rickhanlonii pushed a commit that referenced this pull request Dec 3, 2022
…om-bindings (#25617)

<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open
`chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

Following
[comment](#25437 (comment))
in #25437 , the external runtime implementation should be moved from
`react-dom` to `react-dom-bindings`.

I did have a question here:
I set the entrypoint to `react-dom/unstable_server-external-runtime.js`,
since a.) I was following #25436 as an example and b.)
`react-dom-bindings` was missing a `README.md` and `npm/`. This also
involved adding the external runtime to `package.json`.
However, the external runtime isn't really a `react-dom` entrypoint. Is
this change alright, or should I change the bundling code instead?
## How did you test this change?

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->
mofeiZ added a commit to mofeiZ/react that referenced this pull request Dec 5, 2022
We're adding an option to Fizz to support an alternate output format
that doesn't rely on inline script tags (see facebook#25437). The two outputs
will share the same "instruction set" of functions. These functions are
currently inlined into the source file; to make this a bit more maintainable,
and eventually have a single source of truth, in preparation for the new option,
this commit moves the instruction set to a separate files that are imported.

In the future, we could improve this further by running Closure on the
instruction set and generating it at build time. This isn't an urgent
improvement, though, because we rarely modify the instruction set.

Co-authored-by: Mofei Zhang <[email protected]>

Co-authored-by: Mofei Zhang <[email protected]>
mofeiZ added a commit to mofeiZ/react that referenced this pull request Dec 5, 2022
…om-bindings (facebook#25617)

<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open
`chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

Following
[comment](facebook#25437 (comment))
in facebook#25437 , the external runtime implementation should be moved from
`react-dom` to `react-dom-bindings`.

I did have a question here:
I set the entrypoint to `react-dom/unstable_server-external-runtime.js`,
since a.) I was following facebook#25436 as an example and b.)
`react-dom-bindings` was missing a `README.md` and `npm/`. This also
involved adding the external runtime to `package.json`.
However, the external runtime isn't really a `react-dom` entrypoint. Is
this change alright, or should I change the bundling code instead?

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->
mofeiZ added a commit to mofeiZ/react that referenced this pull request Dec 5, 2022
…acebook#25437)

### Changes made:
- Running with enableFizzExternalRuntime (feature flag) and
unstable_externalRuntimeSrc (param) will generate html nodes with data
attributes that encode Fizz instructions.
```
<div 
  hidden data-rxi=""
  data-bid="param0"
  data-dgst="param1"
></div>
```
- Added an external runtime browser script
`ReactDOMServerExternalRuntime`, which processes and removes these nodes
- This runtime should be passed as to renderInto[...] via
`unstable_externalRuntimeSrc`
- Since this runtime is render blocking (for all streamed suspense
boundaries and segments), we want this to reach the client as early as
possible. By default, Fizz will send this script at the end of the shell
when it detects dynamic content (e.g. suspenseful pending tasks), but it
can be sent even earlier by calling `preinit(...)` inside a component.
- The current implementation relies on Float to dedupe sending
`unstable_externalRuntimeSrc`, so `enableFizzExternalRuntime` is only
valid when `enableFloat` is also set.
mofeiZ added a commit to mofeiZ/react that referenced this pull request Dec 9, 2022
mofeiZ added a commit that referenced this pull request Jan 6, 2023
…me (#25862)

~~[Fizz] Duplicate completeBoundaryWithStyles to not reference globals~~

## Summary

Follow-up / cleanup PR to #25437 

- `completeBoundaryWithStylesInlineLocals` is used by the Fizz external
runtime, which bundles together all Fizz instruction functions (and is
able to reference / rename `completeBoundary` and `resourceMap` as
locals).
- `completeBoundaryWithStylesInlineGlobals` is used by the Fizz inline
script writer, which sends Fizz instruction functions on an as-needed
basis. This version needs to reference `completeBoundary($RC)` and
`resourceMap($RM)` as globals.

Ideally, Closure would take care of inlining a shared implementation,
but I couldn't figure out a zero-overhead inline due to lack of an
`@inline` compiler directive. It seems that Closure thinks that a shared
`completeBoundaryWithStyles` is too large and will always keep it as a
separate function. I've also tried currying / writing a higher order
function (`getCompleteBoundaryWithStyles`) with no luck



## How did you test this change?
- generated Fizz inline instructions should be unchanged
- bundle size for unstable_external_runtime should be slightly smaller
(due to lack of globals)
- `ReactDOMFizzServer-test.js` and `ReactDOMFloat-test.js` should be
unaffected
github-actions bot pushed a commit that referenced this pull request Jan 6, 2023
…me (#25862)

~~[Fizz] Duplicate completeBoundaryWithStyles to not reference globals~~

## Summary

Follow-up / cleanup PR to #25437

- `completeBoundaryWithStylesInlineLocals` is used by the Fizz external
runtime, which bundles together all Fizz instruction functions (and is
able to reference / rename `completeBoundary` and `resourceMap` as
locals).
- `completeBoundaryWithStylesInlineGlobals` is used by the Fizz inline
script writer, which sends Fizz instruction functions on an as-needed
basis. This version needs to reference `completeBoundary($RC)` and
`resourceMap($RM)` as globals.

Ideally, Closure would take care of inlining a shared implementation,
but I couldn't figure out a zero-overhead inline due to lack of an
`@inline` compiler directive. It seems that Closure thinks that a shared
`completeBoundaryWithStyles` is too large and will always keep it as a
separate function. I've also tried currying / writing a higher order
function (`getCompleteBoundaryWithStyles`) with no luck

## How did you test this change?
- generated Fizz inline instructions should be unchanged
- bundle size for unstable_external_runtime should be slightly smaller
(due to lack of globals)
- `ReactDOMFizzServer-test.js` and `ReactDOMFloat-test.js` should be
unaffected

DiffTrain build for [0b97441](0b97441)
[View git log for this commit](https://github.com/facebook/react/commits/0b974418c9a56f6c560298560265dcf4b65784bc)
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jan 30, 2023
Summary:
Three problems popped up during the sync:
- facebook/react@07f46ecf2 breaks breaks tests
- facebook/react@6fb8133ed breaks fbsource tests. I added a workaround and created a test for the team that owns the test.
- https://fb.workplace.com/groups/flowlang/permalink/1198137807458547/ enables local type interference in fbsource but not in github React repo and some code breaks. Addressed in facebook/react#26064

This sync includes the following changes:
- **[17f6912a4](facebook/react@17f6912a4 )**: Add flow types to ReactFiberHooks ([#25752](facebook/react#25752)) //<Samuel Susla>//
- **[f101c2d0d](facebook/react@f101c2d0d )**: Remove Reconciler fork (2/2) ([#25775](facebook/react#25775)) //<Jan Kassens>//
- **[420f0b7fa](facebook/react@420f0b7fa )**: Remove Reconciler fork (1/2) ([#25774](facebook/react#25774)) //<Jan Kassens>//
- **[3ba7add60](facebook/react@3ba7add60 )**: Allow async blocks in `to(Error|Warn)Dev` ([#25338](facebook/react#25338)) //<Sebastian Silbermann>//
- **[fa11bd6ec](facebook/react@fa11bd6ec )**: [ServerRenderer] Add option to send instructions as data attributes ([#25437](facebook/react#25437)) //<mofeiZ>//
- **[e98225485](facebook/react@e98225485 )**: Add ref cleanup function ([#25686](facebook/react#25686)) //<Samuel Susla>//
- **[15557fa67](facebook/react@15557fa67 )**: [Fix] properly track `useId` use in StrictMode in development ([#25713](facebook/react#25713)) //<Josh Story>//
- **[8a23def32](facebook/react@8a23def32 )**: Resubmit Add HydrationSyncLane ([#25711](facebook/react#25711)) //<Tianyu Yao>//
- **[2655c9354](facebook/react@2655c9354 )**: Fizz Browser: fix precomputed chunk being cleared on Node 18 ([#25645](facebook/react#25645)) //<Jimmy Lai>//
- **[c08d8b804](facebook/react@c08d8b804 )**: Revert "Add SyncHydrationLane" ([#25708](facebook/react#25708)) //<Tianyu Yao>//
- **[56ffca8b9](facebook/react@56ffca8b9 )**: Add Bun streaming server renderer ([#25597](facebook/react#25597)) //<Colin McDonnell>//
- **[f31005d6a](facebook/react@f31005d6a )**: Add SyncHydrationLane ([#25698](facebook/react#25698)) //<Tianyu Yao>//
- **[f284d9faf](facebook/react@f284d9faf )**: Track ThenableState alongside other hooks //<Andrew Clark>//
- **[6b4c0314e](facebook/react@6b4c0314e )**: Check thenable instead of thenableState //<Andrew Clark>//
- **[33e3d2878](facebook/react@33e3d2878 )**: Reuse hooks when replaying a suspended component //<Andrew Clark>//
- **[4387d752d](facebook/react@4387d752d )**: Allow more hooks to be added when replaying mount //<Andrew Clark>//
- **[5eb78d0a0](facebook/react@5eb78d0a0 )**: Pass ThenableState to replaySuspendedUnitOfWork //<Andrew Clark>//
- **[4a2d86bdd](facebook/react@4a2d86bdd )**: Don't reset work loop until stack is unwound //<Andrew Clark>//
- **[9dfbd9fa9](facebook/react@9dfbd9fa9 )**: use: Don't suspend if there are pending updates //<Andrew Clark>//
- **[44c4e6f4d](facebook/react@44c4e6f4d )**: Force unwind work loop during selective hydration ([#25695](facebook/react#25695)) //<Andrew Clark>//
- **[7b17f7bbf](facebook/react@7b17f7bbf )**: Enable warning for defaultProps on function components for everyone ([#25699](facebook/react#25699)) //<Sebastian Markbåge>//
- **[6fb8133ed](facebook/react@6fb8133ed )**: Turn on string ref deprecation warning for everybody (not codemoddable) ([#25383](facebook/react#25383)) //<Sebastian Silbermann>//
- **[07f46ecf2](facebook/react@07f46ecf2 )**: Turn on key spread warning in jsx-runtime for everyone ([#25697](facebook/react#25697)) //<Sebastian Markbåge>//
- **[d65b88d03](facebook/react@d65b88d03 )**: Eagerly initialize an mutable object for instance.refs ([#25696](facebook/react#25696)) //<Sebastian Markbåge>//
- **[c343f8025](facebook/react@c343f8025 )**: [react-float] feature detect getRootNode ([#25689](facebook/react#25689)) //<Jan Kassens>//
- **[e1dd0a2f5](facebook/react@e1dd0a2f5 )**: Remove recoverable error when a sync update flows into a dehydrated boundary ([#25692](facebook/react#25692)) //<Sebastian Markbåge>//
- **[c54e3541b](facebook/react@c54e3541b )**: [DevTools] bug fix for Hydrating fibers ([#25663](facebook/react#25663)) //<Mengdi Chen>//

Changelog:
[General][Changed] - React Native sync for revisions d1e35c7...17f6912

jest_e2e[run_all_tests]

Reviewed By: makovkastar

Differential Revision: D42804802

fbshipit-source-id: 6a9f00724cc73378025bbd04edb2d17760a87280
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Three problems popped up during the sync:
- facebook/react@07f46ecf2 breaks breaks tests
- facebook/react@6fb8133ed breaks fbsource tests. I added a workaround and created a test for the team that owns the test.
- https://fb.workplace.com/groups/flowlang/permalink/1198137807458547/ enables local type interference in fbsource but not in github React repo and some code breaks. Addressed in facebook/react#26064

This sync includes the following changes:
- **[17f6912a4](facebook/react@17f6912a4 )**: Add flow types to ReactFiberHooks ([facebook#25752](facebook/react#25752)) //<Samuel Susla>//
- **[f101c2d0d](facebook/react@f101c2d0d )**: Remove Reconciler fork (2/2) ([facebook#25775](facebook/react#25775)) //<Jan Kassens>//
- **[420f0b7fa](facebook/react@420f0b7fa )**: Remove Reconciler fork (1/2) ([facebook#25774](facebook/react#25774)) //<Jan Kassens>//
- **[3ba7add60](facebook/react@3ba7add60 )**: Allow async blocks in `to(Error|Warn)Dev` ([facebook#25338](facebook/react#25338)) //<Sebastian Silbermann>//
- **[fa11bd6ec](facebook/react@fa11bd6ec )**: [ServerRenderer] Add option to send instructions as data attributes ([facebook#25437](facebook/react#25437)) //<mofeiZ>//
- **[e98225485](facebook/react@e98225485 )**: Add ref cleanup function ([facebook#25686](facebook/react#25686)) //<Samuel Susla>//
- **[15557fa67](facebook/react@15557fa67 )**: [Fix] properly track `useId` use in StrictMode in development ([facebook#25713](facebook/react#25713)) //<Josh Story>//
- **[8a23def32](facebook/react@8a23def32 )**: Resubmit Add HydrationSyncLane ([facebook#25711](facebook/react#25711)) //<Tianyu Yao>//
- **[2655c9354](facebook/react@2655c9354 )**: Fizz Browser: fix precomputed chunk being cleared on Node 18 ([facebook#25645](facebook/react#25645)) //<Jimmy Lai>//
- **[c08d8b804](facebook/react@c08d8b804 )**: Revert "Add SyncHydrationLane" ([facebook#25708](facebook/react#25708)) //<Tianyu Yao>//
- **[56ffca8b9](facebook/react@56ffca8b9 )**: Add Bun streaming server renderer ([facebook#25597](facebook/react#25597)) //<Colin McDonnell>//
- **[f31005d6a](facebook/react@f31005d6a )**: Add SyncHydrationLane ([facebook#25698](facebook/react#25698)) //<Tianyu Yao>//
- **[f284d9faf](facebook/react@f284d9faf )**: Track ThenableState alongside other hooks //<Andrew Clark>//
- **[6b4c0314e](facebook/react@6b4c0314e )**: Check thenable instead of thenableState //<Andrew Clark>//
- **[33e3d2878](facebook/react@33e3d2878 )**: Reuse hooks when replaying a suspended component //<Andrew Clark>//
- **[4387d752d](facebook/react@4387d752d )**: Allow more hooks to be added when replaying mount //<Andrew Clark>//
- **[5eb78d0a0](facebook/react@5eb78d0a0 )**: Pass ThenableState to replaySuspendedUnitOfWork //<Andrew Clark>//
- **[4a2d86bdd](facebook/react@4a2d86bdd )**: Don't reset work loop until stack is unwound //<Andrew Clark>//
- **[9dfbd9fa9](facebook/react@9dfbd9fa9 )**: use: Don't suspend if there are pending updates //<Andrew Clark>//
- **[44c4e6f4d](facebook/react@44c4e6f4d )**: Force unwind work loop during selective hydration ([facebook#25695](facebook/react#25695)) //<Andrew Clark>//
- **[7b17f7bbf](facebook/react@7b17f7bbf )**: Enable warning for defaultProps on function components for everyone ([facebook#25699](facebook/react#25699)) //<Sebastian Markbåge>//
- **[6fb8133ed](facebook/react@6fb8133ed )**: Turn on string ref deprecation warning for everybody (not codemoddable) ([facebook#25383](facebook/react#25383)) //<Sebastian Silbermann>//
- **[07f46ecf2](facebook/react@07f46ecf2 )**: Turn on key spread warning in jsx-runtime for everyone ([facebook#25697](facebook/react#25697)) //<Sebastian Markbåge>//
- **[d65b88d03](facebook/react@d65b88d03 )**: Eagerly initialize an mutable object for instance.refs ([facebook#25696](facebook/react#25696)) //<Sebastian Markbåge>//
- **[c343f8025](facebook/react@c343f8025 )**: [react-float] feature detect getRootNode ([facebook#25689](facebook/react#25689)) //<Jan Kassens>//
- **[e1dd0a2f5](facebook/react@e1dd0a2f5 )**: Remove recoverable error when a sync update flows into a dehydrated boundary ([facebook#25692](facebook/react#25692)) //<Sebastian Markbåge>//
- **[c54e3541b](facebook/react@c54e3541b )**: [DevTools] bug fix for Hydrating fibers ([facebook#25663](facebook/react#25663)) //<Mengdi Chen>//

Changelog:
[General][Changed] - React Native sync for revisions d1e35c7...17f6912

jest_e2e[run_all_tests]

Reviewed By: makovkastar

Differential Revision: D42804802

fbshipit-source-id: 6a9f00724cc73378025bbd04edb2d17760a87280
jerrydev0927 added a commit to jerrydev0927/react that referenced this pull request Jan 5, 2024
…om-bindings (#25617)

<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open
`chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

Following
[comment](facebook/react#25437 (comment))
in #25437 , the external runtime implementation should be moved from
`react-dom` to `react-dom-bindings`.

I did have a question here:
I set the entrypoint to `react-dom/unstable_server-external-runtime.js`,
since a.) I was following #25436 as an example and b.)
`react-dom-bindings` was missing a `README.md` and `npm/`. This also
involved adding the external runtime to `package.json`.
However, the external runtime isn't really a `react-dom` entrypoint. Is
this change alright, or should I change the bundling code instead?
## How did you test this change?

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->
alexandresoro pushed a commit to alexandresoro/ouca-web that referenced this pull request Jan 17, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | devDependencies | major | [`18.3.18` -> `19.0.7`](https://renovatebot.com/diffs/npm/@types%2freact/18.3.18/19.0.7) |
| [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom)) | devDependencies | major | [`18.3.5` -> `19.0.3`](https://renovatebot.com/diffs/npm/@types%2freact-dom/18.3.5/19.0.3) |
| [react](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/react)) | dependencies | major | [`18.3.1` -> `19.0.0`](https://renovatebot.com/diffs/npm/react/18.3.1/19.0.0) |
| [react-dom](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/react-dom)) | dependencies | major | [`18.3.1` -> `19.0.0`](https://renovatebot.com/diffs/npm/react-dom/18.3.1/19.0.0) |

---

### Release Notes

<details>
<summary>facebook/react (react)</summary>

### [`v19.0.0`](https://github.com/facebook/react/blob/HEAD/CHANGELOG.md#1900-December-5-2024)

[Compare Source](https://github.com/facebook/react/compare/v18.3.1...v19.0.0)

Below is a list of all new features, APIs, deprecations, and breaking changes. Read [React 19 release post](https://react.dev/blog/2024/04/25/react-19) and [React 19 upgrade guide](https://react.dev/blog/2024/04/25/react-19-upgrade-guide) for more information.

> Note: To help make the upgrade to React 19 easier, we’ve published a [email protected] release that is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19. We recommend upgrading to React 18.3.1 first to help identify any issues before upgrading to React 19.

##### New Features

##### React

-   Actions: `startTransition` can now accept async functions. Functions passed to `startTransition` are called “Actions”. A given Transition can include one or more Actions which update state in the background and update the UI with one commit. In addition to updating state, Actions can now perform side effects including async requests, and the Action will wait for the work to finish before finishing the Transition. This feature allows Transitions to include side effects like `fetch()` in the pending state, and provides support for error handling, and optimistic updates.
-   `useActionState`: is a new hook to order Actions inside of a Transition with access to the state of the action, and the pending state. It accepts a reducer that can call Actions, and the initial state used for first render. It also accepts an optional string that is used if the action is passed to a form `action` prop to support progressive enhancement in forms.
-   `useOptimistic`: is a new hook to update state while a Transition is in progress. It returns the state, and a set function that can be called inside a transition to “optimistically” update the state to expected final value immediately while the Transition completes in the background. When the transition finishes, the state is updated to the new value.
-   `use`: is a new API that allows reading resources in render. In React 19, `use` accepts a promise or Context. If provided a promise, `use` will suspend until a value is resolved. `use` can only be used in render but can be called conditionally.
-   `ref` as a prop: Refs can now be used as props, removing the need for `forwardRef`.
-   **Suspense sibling pre-warming**: When a component suspends, React will immediately commit the fallback of the nearest Suspense boundary, without waiting for the entire sibling tree to render. After the fallback commits, React will schedule another render for the suspended siblings to “pre-warm” lazy requests.

##### React DOM Client

-   `<form> action` prop: Form Actions allow you to manage forms automatically and integrate with `useFormStatus`. When a `<form> action` succeeds, React will automatically reset the form for uncontrolled components. The form can be reset manually with the new `requestFormReset` API.
-   `<button> and <input> formAction` prop: Actions can be passed to the `formAction` prop to configure form submission behavior. This allows using different Actions depending on the input.
-   `useFormStatus`: is a new hook that provides the status of the parent `<form> action`, as if the form was a Context provider. The hook returns the values: `pending`, `data`, `method`, and `action`.
-   Support for Document Metadata: We’ve added support for rendering document metadata tags in components natively. React will automatically hoist them into the `<head>` section of the document.
-   Support for Stylesheets: React 19 will ensure stylesheets are inserted into the `<head>` on the client before revealing the content of a Suspense boundary that depends on that stylesheet.
-   Support for async scripts: Async scripts can be rendered anywhere in the component tree and React will handle ordering and deduplication.
-   Support for preloading resources: React 19 ships with `preinit`, `preload`, `prefetchDNS`, and `preconnect` APIs to optimize initial page loads by moving discovery of additional resources like fonts out of stylesheet loading. They can also be used to prefetch resources used by an anticipated navigation.

##### React DOM Server

-   Added `prerender` and `prerenderToNodeStream` APIs for static site generation. They are designed to work with streaming environments like Node.js Streams and Web Streams. Unlike `renderToString`, they wait for data to load for HTML generation.

##### React Server Components

-   RSC features such as directives, server components, and server functions are now stable. This means libraries that ship with Server Components can now target React 19 as a peer dependency with a react-server export condition for use in frameworks that support the Full-stack React Architecture. The underlying APIs used to implement a React Server Components bundler or framework do not follow semver and may break between minors in React 19.x. See [docs](https://19.react.dev/reference/rsc/server-components) for how to support React Server Components.

##### Deprecations

-   Deprecated: `element.ref` access: React 19 supports ref as a prop, so we’re deprecating `element.ref` in favor of `element.props.ref`. Accessing will result in a warning.
-   `react-test-renderer`: In React 19, react-test-renderer logs a deprecation warning and has switched to concurrent rendering for web usage. We recommend migrating your tests to  [@&#8203;testing-library/react](https://testing-library.com/docs/react-testing-library/intro/) or [@&#8203;testing-library/react-native](https://testing-library.com/docs/react-native-testing-library/intro)

##### Breaking Changes

React 19 brings in a number of breaking changes, including the removals of long-deprecated APIs. We recommend first upgrading to `18.3.1`, where we've added additional deprecation warnings. Check out the [upgrade guide](https://19.react.dev/blog/2024/04/25/react-19-upgrade-guide) for more details and guidance on codemodding.

##### React

-   New JSX Transform is now required: We introduced [a new JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) in 2020 to improve bundle size and use JSX without importing React. In React 19, we’re adding additional improvements like using ref as a prop and JSX speed improvements that require the new transform.
-   Errors in render are not re-thrown: Errors that are not caught by an Error Boundary are now reported to window.reportError. Errors that are caught by an Error Boundary are reported to console.error. We’ve introduced `onUncaughtError` and `onCaughtError` methods to `createRoot` and `hydrateRoot` to customize this error handling.
-   Removed: `propTypes`: Using `propTypes` will now be silently ignored. If required, we recommend migrating to TypeScript or another type-checking solution.
-   Removed: `defaultProps` for functions: ES6 default parameters can be used in place. Class components continue to support `defaultProps` since there is no ES6 alternative.
-   Removed: `contextTypes` and `getChildContext`: Legacy Context for class components has been removed in favor of the `contextType` API.
-   Removed: string refs: Any usage of string refs need to be migrated to ref callbacks.
-   Removed: Module pattern factories: A rarely used pattern that can be migrated to regular functions.
-   Removed: `React.createFactory`: Now that JSX is broadly supported, all `createFactory` usage can be migrated to JSX components.
-   Removed: `react-test-renderer/shallow`: This has been a re-export of [react-shallow-renderer](https://github.com/enzymejs/react-shallow-renderer) since React 18. If needed, you can continue to use the third-party package directly. We recommend using [@&#8203;testing-library/react](https://testing-library.com/docs/react-testing-library/intro/) or [@&#8203;testing-library/react-native](https://testing-library.com/docs/react-native-testing-library/intro) instead.

##### React DOM

-   Removed: `react-dom/test-utils`: We’ve moved `act` from `react-dom/test-utils` to react. All other utilities have been removed.
-   Removed: `ReactDOM`.`render`, `ReactDOM`.`hydrate`: These have been removed in favor of the concurrent equivalents: `ReactDOM`.`createRoot` and `ReactDOM.hydrateRoot`.
-   Removed: `unmountComponentAtNode`: Removed in favor of `root.unmount()`.
-   Removed: `ReactDOM`.`findDOMNode`: You can replace `ReactDOM`.`findDOMNode` with DOM Refs.

##### Notable Changes

##### React

-   `<Context>` as a provider: You can now render `<Context>` as a provider instead of `<Context.Provider>`.
-   Cleanup functions for refs: When the component unmounts, React will call the cleanup function returned from the ref callback.
-   `useDeferredValue` initial value argument: When provided, `useDeferredValue` will return the initial value for the initial render of a component, then schedule a re-render in the background with the `deferredValue` returned.
-   Support for Custom Elements: React 19 now passes all tests on [Custom Elements Everywhere](https://custom-elements-everywhere.com/).
-   StrictMode changes: `useMemo` and `useCallback` will now reuse the memoized results from the first render, during the second render. Additionally, StrictMode will now double-invoke ref callback functions on initial mount.
-   UMD builds removed: To load React 19 with a script tag, we recommend using an ESM-based CDN such as [esm.sh](http://esm.sh).

##### React DOM

-   Diffs for hydration errors: In the case of a mismatch, React 19 logs a single error with a diff of the mismatched content.
-   Compatibility with third-party scripts and extensions: React will now force a client re-render to fix up any mismatched content caused by elements inserted by third-party JS.

##### TypeScript Changes

The most common changes can be codemodded with `npx types-react-codemod@latest preset-19 ./path-to-your-react-ts-files`.

-   Removed deprecated TypeScript types:
    -   `ReactChild` (replacement: `React.ReactElement | number | string)`
    -   `ReactFragment` (replacement: `Iterable<React.ReactNode>`)
    -   `ReactNodeArray` (replacement: `ReadonlyArray<React.ReactNode>`)
    -   `ReactText` (replacement: `number | string`)
    -   `VoidFunctionComponent` (replacement: `FunctionComponent`)
    -   `VFC` (replacement: `FC`)
    -   Moved to `prop-types`: `Requireable`, `ValidationMap`, `Validator`, `WeakValidationMap`
    -   Moved to `create-react-class`: `ClassicComponentClass`, `ClassicComponent`, `ClassicElement`, `ComponentSpec`, `Mixin`, `ReactChildren`, `ReactHTML`, `ReactSVG`, `SFCFactory`
-   Disallow implicit return in refs: refs can now accept cleanup functions. When you return something else, we can’t tell if you intentionally returned something not meant to clean up or returned the wrong value. Implicit returns of anything but functions will now error.
-   Require initial argument to `useRef`: The initial argument is now required to match `useState`, `createContext` etc
-   Refs are mutable by default: Ref objects returned from `useRef()` are now always mutable instead of sometimes being immutable. This feature was too confusing for users and conflicted with legit cases where refs were managed by React and manually written to.
-   Strict `ReactElement` typing: The props of React elements now default to `unknown` instead of `any` if the element is typed as `ReactElement`
-   JSX namespace in TypeScript: The global `JSX` namespace is removed to improve interoperability with other libraries using JSX. Instead, the JSX namespace is available from the React package: `import { JSX } from 'react'`
-   Better `useReducer` typings: Most `useReducer` usage should not require explicit type arguments.\
    For example,
    ```diff
    -useReducer<React.Reducer<State, Action>>(reducer)
    +useReducer(reducer)
    ```
    or
    ```diff
    -useReducer<React.Reducer<State, Action>>(reducer)
    +useReducer<State, Action>(reducer)
    ```

##### All Changes

##### React

-   Add support for async Actions ([#&#8203;26621](https://github.com/facebook/react/pull/26621), [#&#8203;26726](https://github.com/facebook/react/pull/26726), [#&#8203;28078](https://github.com/facebook/react/pull/28078), [#&#8203;28097](https://github.com/facebook/react/pull/28097), [#&#8203;29226](https://github.com/facebook/react/pull/29226), [#&#8203;29618](https://github.com/facebook/react/pull/29618), [#&#8203;29670](https://github.com/facebook/react/pull/29670), [#&#8203;26716](https://github.com/facebook/react/pull/26716) by [@&#8203;acdlite](https://github.com/acdlite) and [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
-   Add `useActionState()` hook to update state based on the result of a Form Action ([#&#8203;27270](https://github.com/facebook/react/pull/27270), [#&#8203;27278](https://github.com/facebook/react/pull/27278), [#&#8203;27309](https://github.com/facebook/react/pull/27309), [#&#8203;27302](https://github.com/facebook/react/pull/27302), [#&#8203;27307](https://github.com/facebook/react/pull/27307), [#&#8203;27366](https://github.com/facebook/react/pull/27366), [#&#8203;27370](https://github.com/facebook/react/pull/27370), [#&#8203;27321](https://github.com/facebook/react/pull/27321), [#&#8203;27374](https://github.com/facebook/react/pull/27374), [#&#8203;27372](https://github.com/facebook/react/pull/27372), [#&#8203;27397](https://github.com/facebook/react/pull/27397), [#&#8203;27399](https://github.com/facebook/react/pull/27399), [#&#8203;27460](https://github.com/facebook/react/pull/27460), [#&#8203;28557](https://github.com/facebook/react/pull/28557), [#&#8203;27570](https://github.com/facebook/react/pull/27570), [#&#8203;27571](https://github.com/facebook/react/pull/27571), [#&#8203;28631](https://github.com/facebook/react/pull/28631), [#&#8203;28788](https://github.com/facebook/react/pull/28788), [#&#8203;29694](https://github.com/facebook/react/pull/29694), [#&#8203;29695](https://github.com/facebook/react/pull/29695), [#&#8203;29694](https://github.com/facebook/react/pull/29694), [#&#8203;29665](https://github.com/facebook/react/pull/29665), [#&#8203;28232](https://github.com/facebook/react/pull/28232), [#&#8203;28319](https://github.com/facebook/react/pull/28319) by [@&#8203;acdlite](https://github.com/acdlite), [@&#8203;eps1lon](https://github.com/eps1lon), and [@&#8203;rickhanlonii](https://github.com/rickhanlonii))
-   Add `use()` API to read resources in render ([#&#8203;25084](https://github.com/facebook/react/pull/25084), [#&#8203;25202](https://github.com/facebook/react/pull/25202), [#&#8203;25207](https://github.com/facebook/react/pull/25207), [#&#8203;25214](https://github.com/facebook/react/pull/25214), [#&#8203;25226](https://github.com/facebook/react/pull/25226), [#&#8203;25247](https://github.com/facebook/react/pull/25247), [#&#8203;25539](https://github.com/facebook/react/pull/25539), [#&#8203;25538](https://github.com/facebook/react/pull/25538), [#&#8203;25537](https://github.com/facebook/react/pull/25537), [#&#8203;25543](https://github.com/facebook/react/pull/25543), [#&#8203;25561](https://github.com/facebook/react/pull/25561), [#&#8203;25620](https://github.com/facebook/react/pull/25620), [#&#8203;25615](https://github.com/facebook/react/pull/25615), [#&#8203;25922](https://github.com/facebook/react/pull/25922), [#&#8203;25641](https://github.com/facebook/react/pull/25641), [#&#8203;25634](https://github.com/facebook/react/pull/25634), [#&#8203;26232](https://github.com/facebook/react/pull/26232), [#&#8203;26536](https://github.com/facebook/react/pull/26535), [#&#8203;26739](https://github.com/facebook/react/pull/26739), [#&#8203;28233](https://github.com/facebook/react/pull/28233) by [@&#8203;acdlite](https://github.com/acdlite), [@&#8203;MofeiZ](https://github.com/mofeiZ), [@&#8203;sebmarkbage](https://github.com/sebmarkbage), [@&#8203;sophiebits](https://github.com/sophiebits), [@&#8203;eps1lon](https://github.com/eps1lon), and [@&#8203;hansottowirtz](https://github.com/hansottowirtz))
-   Add `useOptimistic()` hook to display mutated state optimistically during an async mutation ([#&#8203;26740](https://github.com/facebook/react/pull/26740), [#&#8203;26772](https://github.com/facebook/react/pull/26772), [#&#8203;27277](https://github.com/facebook/react/pull/27277), [#&#8203;27453](https://github.com/facebook/react/pull/27453), [#&#8203;27454](https://github.com/facebook/react/pull/27454), [#&#8203;27936](https://github.com/facebook/react/pull/27936) by [@&#8203;acdlite](https://github.com/acdlite))
-   Added an `initialValue` argument to `useDeferredValue()` hook ([#&#8203;27500](https://github.com/facebook/react/pull/27500), [#&#8203;27509](https://github.com/facebook/react/pull/27509), [#&#8203;27512](https://github.com/facebook/react/pull/27512), [#&#8203;27888](https://github.com/facebook/react/pull/27888), [#&#8203;27550](https://github.com/facebook/react/pull/27550) by [@&#8203;acdlite](https://github.com/acdlite))
-   Support refs as props, warn on `element.ref` access ([#&#8203;28348](https://github.com/facebook/react/pull/28348), [#&#8203;28464](https://github.com/facebook/react/pull/28464), [#&#8203;28731](https://github.com/facebook/react/pull/28731) by [@&#8203;acdlite](https://github.com/acdlite))
-   Support Custom Elements ([#&#8203;22184](https://github.com/facebook/react/pull/22184), [#&#8203;26524](https://github.com/facebook/react/pull/26524), [#&#8203;26523](https://github.com/facebook/react/pull/26523), [#&#8203;27511](https://github.com/facebook/react/pull/27511), [#&#8203;24541](https://github.com/facebook/react/pull/24541) by [@&#8203;josepharhar](https://github.com/josepharhar), [@&#8203;sebmarkbage](https://github.com/sebmarkbage), [@&#8203;gnoff](https://github.com/gnoff) and [@&#8203;eps1lon](https://github.com/eps1lon))
-   Add ref cleanup function ([#&#8203;25686](https://github.com/facebook/react/pull/25686), [#&#8203;28883](https://github.com/facebook/react/pull/28883), [#&#8203;28910](https://github.com/facebook/react/pull/28910)  by [@&#8203;sammy-SC](https://github.com/sammy-SC), [@&#8203;jackpope](https://github.com/jackpope), and [@&#8203;kassens](https://github.com/kassens))
-   Sibling pre-rendering replaced by sibling pre-warming ([#&#8203;26380](https://github.com/facebook/react/pull/26380), [#&#8203;26549](https://github.com/facebook/react/pull/26549), [#&#8203;30761](https://github.com/facebook/react/pull/30761), [#&#8203;30800](https://github.com/facebook/react/pull/30800), [#&#8203;30762](https://github.com/facebook/react/pull/30762), [#&#8203;30879](https://github.com/facebook/react/pull/30879), [#&#8203;30934](https://github.com/facebook/react/pull/30934), [#&#8203;30952](https://github.com/facebook/react/pull/30952), [#&#8203;31056](https://github.com/facebook/react/pull/31056), [#&#8203;31452](https://github.com/facebook/react/pull/31452) by [@&#8203;sammy-SC](https://github.com/sammy-SC), [@&#8203;acdlite](https://github.com/acdlite), [@&#8203;gnoff](https://github.com/gnoff), [@&#8203;jackpope](https://github.com/jackpope), [@&#8203;rickhanlonii](https://github.com/rickhanlonii))
-   Don’t rethrow errors at the root ([#&#8203;28627](https://github.com/facebook/react/pull/28627), [#&#8203;28641](https://github.com/facebook/react/pull/28641) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
-   Batch sync discrete, continuous, and default lanes ([#&#8203;25700](https://github.com/facebook/react/pull/25700) by [@&#8203;tyao1](https://github.com/tyao1))
-   Switch `<Context>` to mean `<Context.Provider>` ([#&#8203;28226](https://github.com/facebook/react/pull/28226) by [@&#8203;gaearon](https://github.com/gaearon))
-   Changes to *StrictMode*
    -   Handle `info`, `group`, and `groupCollapsed` in *StrictMode* logging ([#&#8203;25172](https://github.com/facebook/react/pull/25172) by [@&#8203;timneutkens](https://github.com/timneutkens))
    -   Refs are now attached/detached/attached in *StrictMode* ([#&#8203;25049](https://github.com/facebook/react/pull/25049) by [@&#8203;sammy-SC](https://github.com/sammy-SC))
    -   Fix `useSyncExternalStore()` hydration in *StrictMode* ([#&#8203;26791](https://github.com/facebook/react/pull/26791) by [@&#8203;sophiebits](https://github.com/sophiebits))
    -   Always trigger `componentWillUnmount()` in *StrictMode* ([#&#8203;26842](https://github.com/facebook/react/pull/26842) by [@&#8203;tyao1](https://github.com/tyao1))
    -   Restore double invoking `useState()` and `useReducer()` initializer functions in *StrictMode* ([#&#8203;28248](https://github.com/facebook/react/pull/28248) by [@&#8203;eps1lon](https://github.com/eps1lon))
    -   Reuse memoized result from first pass ([#&#8203;25583](https://github.com/facebook/react/pull/25583) by [@&#8203;acdlite](https://github.com/acdlite))
    -   Fix `useId()` in *StrictMode* ([#&#8203;25713](https://github.com/facebook/react/pull/25713) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Add component name to *StrictMode* error messages ([#&#8203;25718](https://github.com/facebook/react/pull/25718) by [@&#8203;sammy-SC](https://github.com/sammy-SC))
-   Add support for rendering BigInt ([#&#8203;24580](https://github.com/facebook/react/pull/24580) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   `act()` no longer checks `shouldYield` which can be inaccurate in test environments ([#&#8203;26317](https://github.com/facebook/react/pull/26317) by [@&#8203;acdlite](https://github.com/acdlite))
-   Warn when keys are spread with props ([#&#8203;25697](https://github.com/facebook/react/pull/25697), [#&#8203;26080](https://github.com/facebook/react/pull/26080) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage) and [@&#8203;kassens](https://github.com/kassens))
-   Generate sourcemaps for production build artifacts ([#&#8203;26446](https://github.com/facebook/react/pull/26446) by [@&#8203;markerikson](https://github.com/markerikson))
-   Improve stack diffing algorithm ([#&#8203;27132](https://github.com/facebook/react/pull/27132) by [@&#8203;KarimP](https://github.com/KarimP))
-   Suspense throttling lowered from 500ms to 300ms ([#&#8203;26803](https://github.com/facebook/react/pull/26803) by [@&#8203;acdlite](https://github.com/acdlite))
-   Lazily propagate context changes ([#&#8203;20890](https://github.com/facebook/react/pull/20890) by [@&#8203;acdlite](https://github.com/acdlite) and [@&#8203;gnoff](https://github.com/gnoff))
-   Immediately rerender pinged fiber ([#&#8203;25074](https://github.com/facebook/react/pull/25074) by [@&#8203;acdlite](https://github.com/acdlite))
-   Move update scheduling to microtask ([#&#8203;26512](https://github.com/facebook/react/pull/26512) by [@&#8203;acdlite](https://github.com/acdlite))
-   Consistently apply throttled retries ([#&#8203;26611](https://github.com/facebook/react/pull/26611), [#&#8203;26802](https://github.com/facebook/react/pull/26802) by [@&#8203;acdlite](https://github.com/acdlite))
-   Suspend Thenable/Lazy if it's used in React.Children ([#&#8203;28284](https://github.com/facebook/react/pull/28284) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
-   Detect infinite update loops caused by render phase updates ([#&#8203;26625](https://github.com/facebook/react/pull/26625) by [@&#8203;acdlite](https://github.com/acdlite))
-   Update conditional hooks warning ([#&#8203;29626](https://github.com/facebook/react/pull/29626) by [@&#8203;sophiebits](https://github.com/sophiebits))
-   Update error URLs to go to new docs ([#&#8203;27240](https://github.com/facebook/react/pull/27240) by [@&#8203;rickhanlonii](https://github.com/rickhanlonii))
-   Rename the `react.element` symbol to `react.transitional.element` ([#&#8203;28813](https://github.com/facebook/react/pull/28813) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
-   Fix crash when suspending in shell during `useSyncExternalStore()` re-render ([#&#8203;27199](https://github.com/facebook/react/pull/27199) by [@&#8203;acdlite](https://github.com/acdlite))
-   Fix incorrect “detected multiple renderers" error in tests ([#&#8203;22797](https://github.com/facebook/react/pull/22797) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   Fix bug where effect cleanup may be called twice after bailout ([#&#8203;26561](https://github.com/facebook/react/pull/26561) by [@&#8203;acdlite](https://github.com/acdlite))
-   Fix suspending in shell during discrete update ([#&#8203;25495](https://github.com/facebook/react/pull/25495) by [@&#8203;acdlite](https://github.com/acdlite))
-   Fix memory leak after repeated setState bailouts ([#&#8203;25309](https://github.com/facebook/react/pull/25309) by [@&#8203;acdlite](https://github.com/acdlite))
-   Fix `useSyncExternalStore()` dropped update when state is dispatched in render phase ([#&#8203;25578](https://github.com/facebook/react/pull/25578) by [@&#8203;pandaiolo](https://github.com/pandaiolo))
-   Fix logging when rendering a lazy fragment ([#&#8203;30372](https://github.com/facebook/react/pull/30372) by [@&#8203;tom-sherman](https://github.com/tom-sherman))
-   Remove string refs ([#&#8203;25383](https://github.com/facebook/react/pull/25383), [#&#8203;28322](https://github.com/facebook/react/pull/28322) by [@&#8203;eps1lon](https://github.com/eps1lon) and [@&#8203;acdlite](https://github.com/acdlite))
-   Remove Legacy Context ([#&#8203;30319](https://github.com/facebook/react/issues/30319) by [@&#8203;kassens](https://github.com/kassens))
-   Remove `RefreshRuntime.findAffectedHostInstances` ([#&#8203;30538](https://github.com/facebook/react/pull/30538) by [@&#8203;gaearon](https://github.com/gaearon))
-   Remove client caching from `cache()` API ([#&#8203;27977](https://github.com/facebook/react/pull/27977), [#&#8203;28250](https://github.com/facebook/react/pull/28250) by [@&#8203;acdlite](https://github.com/acdlite) and [@&#8203;gnoff](https://github.com/gnoff))
-   Remove `propTypes` ([#&#8203;28324](https://github.com/facebook/react/pull/28324), [#&#8203;28326](https://github.com/facebook/react/pull/28326) by [@&#8203;gaearon](https://github.com/gaearon))
-   Remove `defaultProps` support, except for classes ([#&#8203;28733](https://github.com/facebook/react/pull/28733) by [@&#8203;acdlite](https://github.com/acdlite))
-   Remove UMD builds ([#&#8203;28735](https://github.com/facebook/react/pull/28735) by [@&#8203;gnoff](https://github.com/gnoff))
-   Remove delay for non-transition updates ([#&#8203;26597](https://github.com/facebook/react/pull/26597) by [@&#8203;acdlite](https://github.com/acdlite))
-   Remove `createFactory` ([#&#8203;27798](https://github.com/facebook/react/pull/27798) by [@&#8203;kassens](https://github.com/kassens))

##### React DOM

-   Adds Form Actions to handle form submission ([#&#8203;26379](https://github.com/facebook/react/pull/26379), [#&#8203;26674](https://github.com/facebook/react/pull/26674), [#&#8203;26689](https://github.com/facebook/react/pull/26689), [#&#8203;26708](https://github.com/facebook/react/pull/26708), [#&#8203;26714](https://github.com/facebook/react/pull/26714),  [#&#8203;26735](https://github.com/facebook/react/pull/26735), [#&#8203;26846](https://github.com/facebook/react/pull/26846), [#&#8203;27358](https://github.com/facebook/react/pull/27358),  [#&#8203;28056](https://github.com/facebook/react/pull/28056) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage), [@&#8203;acdlite](https://github.com/acdlite), and [@&#8203;jupapios](https://github.com/jupapios))
-   Add `useFormStatus()` hook to provide status information of the last form submission ([#&#8203;26719](https://github.com/facebook/react/pull/26719), [#&#8203;26722](https://github.com/facebook/react/pull/26722), [#&#8203;26788](https://github.com/facebook/react/pull/26788),  [#&#8203;29019](https://github.com/facebook/react/pull/29019), [#&#8203;28728](https://github.com/facebook/react/pull/28728), [#&#8203;28413](https://github.com/facebook/react/pull/28413) by [@&#8203;acdlite](https://github.com/acdlite) and [@&#8203;eps1lon](https://github.com/eps1lon))
-   Support for Document Metadata. Adds `preinit`, `preinitModule`, `preconnect`, `prefetchDNS`, `preload`, and `preloadModule` APIs.
    -   [#&#8203;25060](https://github.com/facebook/react/pull/25060), [#&#8203;25243](https://github.com/facebook/react/pull/25243), [#&#8203;25388](https://github.com/facebook/react/pull/25388), [#&#8203;25432](https://github.com/facebook/react/pull/25432), [#&#8203;25436](https://github.com/facebook/react/pull/25436), [#&#8203;25426](https://github.com/facebook/react/pull/25426), [#&#8203;25500](https://github.com/facebook/react/pull/25500), [#&#8203;25480](https://github.com/facebook/react/pull/25480), [#&#8203;25508](https://github.com/facebook/react/pull/25508), [#&#8203;25515](https://github.com/facebook/react/pull/25515), [#&#8203;25514](https://github.com/facebook/react/pull/25514), [#&#8203;25532](https://github.com/facebook/react/pull/25532), [#&#8203;25536](https://github.com/facebook/react/pull/25536), [#&#8203;25534](https://github.com/facebook/react/pull/25534), [#&#8203;25546](https://github.com/facebook/react/pull/25546), [#&#8203;25559](https://github.com/facebook/react/pull/25559), [#&#8203;25569](https://github.com/facebook/react/pull/25569), [#&#8203;25599](https://github.com/facebook/react/pull/25599), [#&#8203;25689](https://github.com/facebook/react/pull/25689), [#&#8203;26106](https://github.com/facebook/react/pull/26106), [#&#8203;26152](https://github.com/facebook/react/pull/26152), [#&#8203;26239](https://github.com/facebook/react/pull/26239), [#&#8203;26237](https://github.com/facebook/react/pull/26237), [#&#8203;26280](https://github.com/facebook/react/pull/26280), [#&#8203;26154](https://github.com/facebook/react/pull/26154), [#&#8203;26256](https://github.com/facebook/react/pull/26256), [#&#8203;26353](https://github.com/facebook/react/pull/26353), [#&#8203;26427](https://github.com/facebook/react/pull/26427), [#&#8203;26450](https://github.com/facebook/react/pull/26450), [#&#8203;26502](https://github.com/facebook/react/pull/26502),  [#&#8203;26514](https://github.com/facebook/react/pull/26514), [#&#8203;26531](https://github.com/facebook/react/pull/26531), [#&#8203;26532](https://github.com/facebook/react/pull/26532), [#&#8203;26557](https://github.com/facebook/react/pull/26557), [#&#8203;26871](https://github.com/facebook/react/pull/26871), [#&#8203;26881](https://github.com/facebook/react/pull/26881), [#&#8203;26877](https://github.com/facebook/react/pull/26877), [#&#8203;26873](https://github.com/facebook/react/pull/26873), [#&#8203;26880](https://github.com/facebook/react/pull/26880), [#&#8203;26942](https://github.com/facebook/react/pull/26942), [#&#8203;26938](https://github.com/facebook/react/pull/26938), [#&#8203;26940](https://github.com/facebook/react/pull/26940), [#&#8203;26939](https://github.com/facebook/react/pull/26939), [#&#8203;27030](https://github.com/facebook/react/pull/27030), [#&#8203;27201](https://github.com/facebook/react/pull/27201), [#&#8203;27212](https://github.com/facebook/react/pull/27212), [#&#8203;27217](https://github.com/facebook/react/pull/27217), [#&#8203;27218](https://github.com/facebook/react/pull/27218), [#&#8203;27220](https://github.com/facebook/react/pull/27220), [#&#8203;27224](https://github.com/facebook/react/pull/27224), [#&#8203;27223](https://github.com/facebook/react/pull/27223), [#&#8203;27269](https://github.com/facebook/react/pull/27269), [#&#8203;27260](https://github.com/facebook/react/pull/27260), [#&#8203;27347](https://github.com/facebook/react/pull/27347), [#&#8203;27346](https://github.com/facebook/react/pull/27346), [#&#8203;27361](https://github.com/facebook/react/pull/27361), [#&#8203;27400](https://github.com/facebook/react/pull/27400), [#&#8203;27541](https://github.com/facebook/react/pull/27541), [#&#8203;27610](https://github.com/facebook/react/pull/27610), [#&#8203;28110](https://github.com/facebook/react/pull/28110), [#&#8203;29693](https://github.com/facebook/react/pull/29693), [#&#8203;29732](https://github.com/facebook/react/pull/29732), [#&#8203;29811](https://github.com/facebook/react/pull/29811), [#&#8203;27586](https://github.com/facebook/react/pull/27586), [#&#8203;28069](https://github.com/facebook/react/pull/28069) by [@&#8203;gnoff](https://github.com/gnoff), [@&#8203;sebmarkbage](https://github.com/sebmarkbage), [@&#8203;acdlite](https://github.com/acdlite), [@&#8203;kassens](https://github.com/kassens), [@&#8203;sokra](https://github.com/sokra), [@&#8203;sweetliquid](https://github.com/sweetliquid)
-   Add `fetchPriority` to `<img>` and `<link>` ([#&#8203;25927](https://github.com/facebook/react/pull/25927) by [@&#8203;styfle](https://github.com/styfle))
-   Add support for SVG `transformOrigin` prop ([#&#8203;26130](https://github.com/facebook/react/pull/26130) by [@&#8203;arav-ind](https://github.com/arav-ind))
-   Add support for `onScrollEnd` event ([#&#8203;26789](https://github.com/facebook/react/pull/26789) by [@&#8203;devongovett](https://github.com/devongovett))
-   Allow `<hr>` as child of `<select>` ([#&#8203;27632](https://github.com/facebook/react/pull/27632) by [@&#8203;SouSingh](https://github.com/SouSingh))
-   Add support for Popover API ([#&#8203;27981](https://github.com/facebook/react/pull/27981) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   Add support for `inert` ([#&#8203;24730](https://github.com/facebook/react/pull/24730) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   Add support for `imageSizes` and `imageSrcSet` ([#&#8203;22550](https://github.com/facebook/react/pull/22550) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   Synchronously flush transitions in popstate events ([#&#8203;26025](https://github.com/facebook/react/pull/26025), [#&#8203;27559](https://github.com/facebook/react/pull/27559), [#&#8203;27505](https://github.com/facebook/react/pull/27505), [#&#8203;30759](https://github.com/facebook/react/pull/30759) by [@&#8203;tyao1](https://github.com/tyao1) and [@&#8203;acdlite](https://github.com/acdlite))
-   `flushSync` exhausts queue even if something throws ([#&#8203;26366](https://github.com/facebook/react/pull/26366) by [@&#8203;acdlite](https://github.com/acdlite))
-   Throw error if `react` and `react-dom` versions don’t match ([#&#8203;29236](https://github.com/facebook/react/pull/29236) by [@&#8203;acdlite](https://github.com/acdlite))
-   Ensure `srcset` and `src` are assigned last on `<img>` instances ([#&#8203;30340](https://github.com/facebook/react/pull/30340) by [@&#8203;gnoff](https://github.com/gnoff))
-   Javascript URLs are replaced with functions that throw errors ([#&#8203;26507](https://github.com/facebook/react/pull/26507), [#&#8203;29808](https://github.com/facebook/react/pull/29808) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage) and [@&#8203;kassens](https://github.com/kassens))
-   Treat toggle and beforetoggle as discrete events ([#&#8203;29176](https://github.com/facebook/react/pull/29176) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   Filter out empty `src` and `href` attributes (unless for `<a href=”” />`) ([#&#8203;18513](https://github.com/facebook/react/pull/18513), [#&#8203;28124](https://github.com/facebook/react/pull/28124) by [@&#8203;bvaughn](https://github.com/bvaughn) and [@&#8203;eps1lon](https://github.com/eps1lon))
-   Fix unitless `scale` style property ([#&#8203;25601](https://github.com/facebook/react/pull/25601) by [@&#8203;JonnyBurger](https://github.com/JonnyBurger))
-   Fix `onChange` error message for controlled `<select>` ([#&#8203;27740](https://github.com/facebook/react/pull/27740) by [@&#8203;Biki-das](https://github.com/Biki-das))
-   Fix focus restore in child windows after element reorder ([#&#8203;30951](https://github.com/facebook/react/pull/30951) by [@&#8203;ling1726](https://github.com/ling1726))
-   Remove `render`, `hydrate`, `findDOMNode`, `unmountComponentAtNode`, `unstable_createEventHandle`, `unstable_renderSubtreeIntoContainer`, and `unstable_runWithPriority`. Move `createRoot` and `hydrateRoot` to `react-dom/client`. ([#&#8203;28271](https://github.com/facebook/react/pull/28271) by [@&#8203;gnoff](https://github.com/gnoff))
-   Remove `test-utils` ([#&#8203;28541](https://github.com/facebook/react/pull/28541) by [@&#8203;eps1lon](https://github.com/eps1lon))
-   Remove `unstable_flushControlled` ([#&#8203;26397](https://github.com/facebook/react/pull/26397) by [@&#8203;kassens](https://github.com/kassens))
-   Remove legacy mode ([#&#8203;28468](https://github.com/facebook/react/pull/28468) by [@&#8203;gnoff](https://github.com/gnoff))
-   Remove `renderToStaticNodeStream()` ([#&#8203;28873](https://github.com/facebook/react/pull/28873) by [@&#8203;gnoff](https://github.com/gnoff))
-   Remove `unstable_renderSubtreeIntoContainer` ([#&#8203;29771](https://github.com/facebook/react/pull/29771) by [@&#8203;kassens](https://github.com/kassens))

##### React DOM Server

-   Stable release of React Server Components ([Many, many PRs](https://github.com/facebook/react/pulls?q=is%3Apr+is%3Aclosed+%5BFlight%5D+in%3Atitle+created%3A%3C2024-12-01+) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage), [@&#8203;acdlite](https://github.com/acdlite), [@&#8203;gnoff](https://github.com/gnoff), [@&#8203;sammy-SC](https://github.com/sammy-SC), [@&#8203;gaearon](https://github.com/gaearon), [@&#8203;sophiebits](https://github.com/sophiebits), [@&#8203;unstubbable](https://github.com/unstubbable), [@&#8203;lubieowoce](https://github.com/lubieowoce))
-   Support Server Actions ([#&#8203;26124](https://github.com/facebook/react/pull/26124), [#&#8203;26632](https://github.com/facebook/react/pull/26632), [#&#8203;27459](https://github.com/facebook/react/pull/27459) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage) and [@&#8203;acdlite](https://github.com/acdlite))
-   Changes to SSR
    -   Add external runtime which bootstraps hydration on the client for binary transparency ([#&#8203;25437](https://github.com/facebook/react/pull/25437), [#&#8203;26169](https://github.com/facebook/react/pull/26169), [#&#8203;25499](https://github.com/facebook/react/pull/25499) by [@&#8203;MofeiZ](https://github.com/mofeiZ) and [@&#8203;acdlite](https://github.com/acdlite))
    -   Support subresource integrity for `bootstrapScripts` and `bootstrapModules` ([#&#8203;25104](https://github.com/facebook/react/pull/25104) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Fix null bytes written at text chunk boundaries ([#&#8203;26228](https://github.com/facebook/react/pull/26228) by [@&#8203;sophiebits](https://github.com/sophiebits))
    -   Fix logic around attribute serialization ([#&#8203;26526](https://github.com/facebook/react/pull/26526) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Fix precomputed chunk cleared on Node 18 ([#&#8203;25645](https://github.com/facebook/react/pull/25645) by [@&#8203;feedthejim](https://github.com/feedthejim))
    -   Optimize end tag chunks ([#&#8203;27522](https://github.com/facebook/react/pull/27522) by [@&#8203;yujunjung](https://github.com/yujunjung))
    -   Gracefully handle suspending in DOM configs ([#&#8203;26768](https://github.com/facebook/react/pull/26768) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Check for nullish values on ReactCustomFormAction ([#&#8203;26770](https://github.com/facebook/react/pull/26770) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Preload `bootstrapModules`, `bootstrapScripts`, and update priority queue ([#&#8203;26754](https://github.com/facebook/react/pull/26754), [#&#8203;26753](https://github.com/facebook/react/pull/26753), [#&#8203;27190](https://github.com/facebook/react/pull/27190), [#&#8203;27189](https://github.com/facebook/react/pull/27189) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Client render the nearest child or parent suspense boundary if replay errors or is aborted ([#&#8203;27386](https://github.com/facebook/react/pull/27386) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Don't bail out of flushing if we still have pending root tasks ([#&#8203;27385](https://github.com/facebook/react/pull/27385) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Ensure Resumable State is Serializable ([#&#8203;27388](https://github.com/facebook/react/pull/27388) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Remove extra render pass when reverting to client render ([#&#8203;26445](https://github.com/facebook/react/pull/26445) by [@&#8203;acdlite](https://github.com/acdlite))
    -   Fix unwinding context during selective hydration ([#&#8203;25876](https://github.com/facebook/react/pull/25876) by [@&#8203;tyao1](https://github.com/tyao1))
    -   Stop flowing and then abort if a stream is cancelled ([#&#8203;27405](https://github.com/facebook/react/pull/27405) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Pass cancellation reason to abort ([#&#8203;27536](https://github.com/facebook/react/pull/27536) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Add `onHeaders` entrypoint option ([#&#8203;27641](https://github.com/facebook/react/pull/27641), [#&#8203;27712](https://github.com/facebook/react/pull/27712) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Escape `<style>` and `<script>` textContent to enable rendering inner content without dangerouslySetInnerHTML ([#&#8203;28870](https://github.com/facebook/react/pull/28870), [#&#8203;28871](https://github.com/facebook/react/pull/28871) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Fallback to client replaying actions for Blob serialization ([#&#8203;28987](https://github.com/facebook/react/pull/28987) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Render Suspense fallback if boundary contains new stylesheet during sync update ([#&#8203;28965](https://github.com/facebook/react/pull/28965) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Fix header length tracking ([#&#8203;30327](https://github.com/facebook/react/issues/30327) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Use `srcset` to trigger load event on mount ([#&#8203;30351](https://github.com/facebook/react/issues/30351) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Don't perform work when closing stream ([#&#8203;30497](https://github.com/facebook/react/issues/30497) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Allow aborting during render ([#&#8203;30488](https://github.com/facebook/react/issues/30488), [#&#8203;30730](https://github.com/facebook/react/pull/30730) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Start initial work immediately ([#&#8203;31079](https://github.com/facebook/react/issues/31079) by [@&#8203;gnoff](https://github.com/gnoff))
    -   A transition flowing into a dehydrated boundary no longer suspends when showing fallback ([#&#8203;27230](https://github.com/facebook/react/pull/27230) by [@&#8203;acdlite](https://github.com/acdlite))
    -   Fix selective hydration triggers false update loop error ([#&#8203;27439](https://github.com/facebook/react/pull/27439) by [@&#8203;acdlite](https://github.com/acdlite))
    -   Warn for Child Iterator of all types but allow Generator Components ([#&#8203;28853](https://github.com/facebook/react/pull/28853) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Include regular stack trace in serialized errors ([#&#8203;28684](https://github.com/facebook/react/pull/28684), [#&#8203;28738](https://github.com/facebook/react/pull/28738) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Aborting early no longer infinitely suspends ([#&#8203;24751](https://github.com/facebook/react/pull/24751) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
    -   Fix hydration warning suppression in text comparisons ([#&#8203;24784](https://github.com/facebook/react/pull/24784) by [@&#8203;gnoff](https://github.com/gnoff))
    -   Changes to error handling in SSR
        -   Add diffs to hydration warnings ([#&#8203;28502](https://github.com/facebook/react/pull/28502), [#&#8203;28512](https://github.com/facebook/react/pull/28512) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
        -   Make Error creation lazy ([#&#8203;24728](https://github.com/facebook/react/pull/24728) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
        -   Remove recoverable error when a sync update flows into a dehydrated boundary ([#&#8203;25692](https://github.com/facebook/react/pull/25692) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
        -   Don't "fix up" mismatched text content with suppressedHydrationWarning ([#&#8203;26391](https://github.com/facebook/react/pull/26391) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
        -   Fix component stacks in errors ([#&#8203;27456](https://github.com/facebook/react/pull/27456) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
        -   Add component stacks to `onError` ([#&#8203;27761](https://github.com/facebook/react/pull/27761), [#&#8203;27850](https://github.com/facebook/react/pull/27850) by [@&#8203;gnoff](https://github.com/gnoff) and [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
        -   Throw hydration mismatch errors once ([#&#8203;28502](https://github.com/facebook/react/pull/28502) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
-   Add Bun streaming server renderer ([#&#8203;25597](https://github.com/facebook/react/pull/25597) by [@&#8203;colinhacks](https://github.com/colinhacks))
-   Add nonce support to bootstrap scripts ([#&#8203;26738](https://github.com/facebook/react/pull/26738) by [@&#8203;danieltott](https://github.com/danieltott))
-   Add `crossorigin` support to bootstrap scripts ([#&#8203;26844](https://github.com/facebook/react/pull/26844) by [@&#8203;HenriqueLimas](https://github.com/HenriqueLimas))
-   Support `nonce` and `fetchpriority` in preload links ([#&#8203;26826](https://github.com/facebook/react/pull/26826) by [@&#8203;liuyenwei](https://github.com/liuyenwei))
-   Add `referrerPolicy` to `ReactDOM.preload()` ([#&#8203;27096](https://github.com/facebook/react/pull/27096) by [@&#8203;styfle](https://github.com/styfle))
-   Add server condition for `react/jsx-dev-runtime` ([#&#8203;28921](https://github.com/facebook/react/pull/28921) by [@&#8203;himself65](https://github.com/himself65))
-   Export version ([#&#8203;29596](https://github.com/facebook/react/pull/29596) by [@&#8203;unstubbable](https://github.com/unstubbable))
-   Rename the secret export of Client and Server internals ([#&#8203;28786](https://github.com/facebook/react/pull/28786), [#&#8203;28789](https://github.com/facebook/react/pull/28789) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage))
-   Remove layout effect warning on server ([#&#8203;26395](https://github.com/facebook/react/pull/26395) by [@&#8203;rickhanlonii](https://github.com/rickhanlonii))
-   Remove `errorInfo.digest` from `onRecoverableError` ([#&#8203;28222](https://github.com/facebook/react/pull/28222) by [@&#8203;gnoff](https://github.com/gnoff))

##### ReactTestRenderer

-   Add deprecation error to `react-test-renderer` on web ([#&#8203;27903](https://github.com/facebook/react/pull/27903), [#&#8203;28904](https://github.com/facebook/react/pull/28904) by [@&#8203;jackpope](https://github.com/jackpope) and [@&#8203;acdlite](https://github.com/acdlite))
-   Render with ConcurrentRoot on web ([#&#8203;28498](https://github.com/facebook/react/pull/28498) by [@&#8203;jackpope](https://github.com/jackpope))
-   Remove `react-test-renderer/shallow` export ([#&#8203;25475](https://github.com/facebook/react/pull/25475), [#&#8203;28497](https://github.com/facebook/react/pull/28497) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage) and [@&#8203;jackpope](https://github.com/jackpope))

##### React Reconciler

-   Enable suspending commits without blocking render ([#&#8203;26398](https://github.com/facebook/react/pull/26398), [#&#8203;26427](https://github.com/facebook/react/pull/26427) by [@&#8203;acdlite](https://github.com/acdlite))
-   Remove `prepareUpdate` ([#&#8203;26583](https://github.com/facebook/react/pull/26583), [#&#8203;27409](http://github.com/facebook/react/pull/27409) by [@&#8203;sebmarkbage](https://github.com/sebmarkbage) and [@&#8203;sophiebits](https://github.com/sophiebits))

##### React-Is

-   Enable tree shaking ([#&#8203;27701](https://github.com/facebook/react/pull/27701) by [@&#8203;markerikson](https://github.com/markerikson))
-   Remove `isConcurrentMode` and `isAsyncMode` methods ([#&#8203;28224](https://github.com/facebook/react/pull/28224) by [@&#8203;gaearon](https://github.com/gaearon))

##### useSyncExternalStore

-   Remove React internals access ([#&#8203;29868](https://github.com/facebook/react/pull/29868) by [@&#8203;phryneas](https://github.com/phryneas))
-   Fix stale selectors keeping previous store references ([#&#8203;25969](https://github.com/facebook/react/pull/25968) by [@&#8203;jellevoost](https://github.com/jellevoost))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45OS4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTEzLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca-web/pulls/6
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants