Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for infinite update loops even if unmounted #24697

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Check for infinite update loops even if unmounted #24697

merged 2 commits into from
Jun 9, 2022

Commits on Jun 8, 2022

  1. [FORKED] Check for infinite update loops even if unmounted 

    The infinite update loop check doesn't need to run if the component
already unmounted, because an update to an unmounted component can't
cause a re-render. But because we used to run the check in this case,
anyway, I found one test in www that happens to "rely on" this behavior
(accidentally). The test is a pretty messy snapshot thing that I have no
interest fixing so to unblock the sync I'm just going to switch this
back to how it was.
    @acdlite
    acdlite committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    58bb117 View commit details
    Browse the repository at this point in the history

  2. Add previous commit to forked revisions

    @acdlite
    acdlite committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d6feb23 View commit details
    Browse the repository at this point in the history