Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NoLanes to replace zero for consistency #24326

Closed

Conversation

wtlin1228
Copy link
Contributor

Summary

Use NoLanes to replace zero for consistency with the surrounding code.

How did you test this change?

This PR shouldn't break anything since NoLanes is equal to 0.

@gaearon
Copy link
Collaborator

gaearon commented Apr 9, 2022

I've noticed you're sending many PRs with small cleanups. They're appreciated but let's put it all in a single PR? Since each is trivial and we'd like not to pollute the commit history with too many cosmetic changes.

@sizebot
Copy link

sizebot commented Apr 9, 2022

Comparing: e0160d5...a398457

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.28 kB 131.28 kB = 41.94 kB 41.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.55 kB 136.55 kB = 43.53 kB 43.53 kB
facebook-www/ReactDOM-prod.classic.js = 435.21 kB 435.21 kB = 79.86 kB 79.86 kB
facebook-www/ReactDOM-prod.modern.js = 420.20 kB 420.20 kB = 77.49 kB 77.49 kB
facebook-www/ReactDOMForked-prod.classic.js = 435.21 kB 435.21 kB = 79.86 kB 79.86 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a398457

@wtlin1228 wtlin1228 closed this Apr 9, 2022
@wtlin1228
Copy link
Contributor Author

Close as duplicate #24327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants