Ship merge, mergeInto, copyProperties to npm #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason we can't add a deprecation warning on import? |
|
Yea, we could. I can move the files so it's obvious they diverged (maybe put them in src/vendor_deprecated or something). |
|
👍 This is just a courtesy for those who reached into |
|
The warnings would be nice. |
|
Added deprecation warnings and READMEs for the people who venture into those vendor dirs. |
|
|
||
| // deprecation notice | ||
| console.warn( | ||
| 'react/lib/merge has been deprecated and will be removed in the ' + |
People may have a bad time if they're depending on these but we can delay that a little bit. Unless they're using directly and not polyfilling Object.assign.
zpao
added a commit
that referenced
this pull request
Oct 14, 2014
Ship merge, mergeInto, copyProperties to npm
doctyper
pushed a commit
to nfl/react-helmet
that referenced
this pull request
Jun 28, 2015
React’s official policy on these helpers is “use at your own risk”: - facebook/react#1906 (comment) - facebook/react#2251 (comment) - facebook/react#2317
power1220
added a commit
to power1220/react-helmet
that referenced
this pull request
Apr 4, 2023
React’s official policy on these helpers is “use at your own risk”: - facebook/react#1906 (comment) - facebook/react#2251 (comment) - facebook/react#2317
LucSPI
added a commit
to LucSPI/React-Helmet
that referenced
this pull request
Feb 12, 2024
React’s official policy on these helpers is “use at your own risk”: - facebook/react#1906 (comment) - facebook/react#2251 (comment) - facebook/react#2317
AMagicHarry
added a commit
to AMagicHarry/react-helmet
that referenced
this pull request
Mar 11, 2024
React’s official policy on these helpers is “use at your own risk”: - facebook/react#1906 (comment) - facebook/react#2251 (comment) - facebook/react#2317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure
merge,mergeInto,copyPropertiesend up in build/modules which then gets packaged up for npm. Is there anything we're missing?Ideally we should have deprecation notices. But we've never officially supported these. Also,
mergenow usesObject.assignso anybody using these without polyfills will have a Bad Time™.Reviewers: @spicyj @sebmarkbage @syranide
Test Plan:
grunt buildand make sure files are inbuild/modules/npm-react/lib(before: they weren't)