Move unstable_scheduleHydration to ReactDOMHydrationRoot #22455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
|
Comparing: 96ca8d9...8523528 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
reviewed
Sep 30, 2021
salazarm
commented
Oct 1, 2021
packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
Outdated
Show resolved
Hide resolved
salazarm
commented
Nov 15, 2021
packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
Outdated
Show resolved
Hide resolved
gaearon
approved these changes
Nov 15, 2021
|
do you do a sync right after so we don't miss the change internally? |
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
) * move unstable_scheduleHydration to ReactDOMHydrationRoot * move definition of schedule hydration * fix test? * prototype * fix test * remove gating because unstable_scheduleHydration is no longer gated through index.stable.js because its exposed through ReactDOMHydrationRoot instead of the ReactDOM package * remove another gating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving
unstable_scheduleHydrationtoReactDOMHydrationRootto ensure that a root is created first before callingunstable_scheduleHydrationHow did you test this change?
Updated jest tests