Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Don't hide/unhide unless visibility changes #21875

Merged
merged 2 commits into from
Jul 14, 2021
Merged

[Bugfix] Don't hide/unhide unless visibility changes #21875

merged 2 commits into from
Jul 14, 2021

Commits on Jul 14, 2021

  1. Use Visibility flag to schedule a hide/show effect 

    Instead of the Update flag, which is also used for other side-effects,
like refs.

I originally added the Visibility flag for this purpose in facebook#20043 but
it got reverted last winter when we were bisecting the effects refactor.
    @acdlite
    acdlite committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    2537142 View commit details
    Browse the repository at this point in the history

  2. Added failing test case

    @acdlite
    Brian Vaughn authored and acdlite committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ca72f59 View commit details
    Browse the repository at this point in the history