Suspense layout effects: Failing test case #21853
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key components to this are:
ref
setter.This causes a cycle:
useState
)The reason
enableSuspenseLayoutEffectSemantics
is related to this issue is because React doesn't otherwise reset refs tonull
when an update suspends. (Note that React does eventually set the ref to null when the component unmounts, but since the component doesn't render again after, there's no render-phase update to cycle.)