Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtreeFlag warning: Fix legacy suspense false positive #21388

Merged

Commits on Apr 29, 2021

  1. subtreeFlag warning: Fix legacy suspense false positive

    Legacy Suspense is weird. We intentionally commit a suspended fiber in
    an inconsistent state. If the fiber suspended before it mounted any
    effects, then the fiber won't have a PassiveStatic effect flag, which
    will trigger the "missing expected subtreeFlag" warning.
    
    To avoid the false positive, we'd need to mark fibers that commit in an
    incomplete state, somehow. For now I'll disable the warning in legacy
    mode, with the assumption that most of the bugs that would trigger it
    are either exclusive to concurrent mode or exist in both.
    acdlite committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4456ace View commit details
    Browse the repository at this point in the history