Make enterleave plugin not depend on window level listener #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordwalke Can you take a quick look. This seems fine but you may have some other cases you had considered somewhere in your brain. |
| return null; | ||
| } | ||
|
|
||
| if (topLevelType === topLevelTypes.topMouseOver) { | ||
| // Mouse event fromElement/toElement for IE. |
There was a problem hiding this comment.
What does this comment mean?
|
Does this work properly if you have non-React children in a React root (perhaps from dangerouslySetInnerHTML)? |
chenglou
force-pushed
the
enterleave-small-not-top
branch
from
a18629e
to
7abb995
Compare
Preventively fixing this independently. Tested on both that branch (works) and master (works, except for the case of moving into Comp from `html`, in which case this will have a duplicate `enter`, since one extra mouseout is captured from `html`).
chenglou
force-pushed
the
enterleave-small-not-top
branch
from
7abb995
to
8f96334
Compare
|
Good catch, thanks. Updated. |
|
Tentatively accepted, assuming we also do the other change. Not sure we will yet. |
|
We're not doing the other change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming #2050 Will break this, so preventively fixing this independently. Tested on both that branch (works) and master (works, except for the case of moving into Comp from
html, in which case this will have a duplicateenter, since one extra mouseout is captured fromhtml).