Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for non-passive event handlers for events affected by the browsers' intervention #19658

Merged

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Aug 20, 2020

Summary

This adds a test @trueadm has commented at #19654 (comment).
The test ensures that unstable_createEventHandle isn't affected by browsers' intervention #19654 mentioned.

Test Plan

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7044514:

Sandbox Source
React Configuration

@koba04 koba04 force-pushed the add-test-for-non-passive-event-handlers branch 3 times, most recently from 05a0986 to 60bfae7 Compare August 20, 2020 02:28
@koba04
Copy link
Contributor Author

koba04 commented Aug 20, 2020

My CircleCI builds are blocked and didn't run all builds I expect.. I'm not sure why this happens, so I have to investigate it.
https://app.circleci.com/pipelines/github/koba04/react?branch=add-test-for-non-passive-event-handlers

@koba04
Copy link
Contributor Author

koba04 commented Aug 20, 2020

image

@koba04
Copy link
Contributor Author

koba04 commented Aug 20, 2020

@koba04 koba04 force-pushed the add-test-for-non-passive-event-handlers branch from 60bfae7 to c14ed86 Compare August 20, 2020 10:09
@koba04
Copy link
Contributor Author

koba04 commented Aug 20, 2020

OK, I've fixed the problem, so this PR is ready for review.

@sizebot
Copy link

sizebot commented Aug 20, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 7044514

@sizebot
Copy link

sizebot commented Aug 20, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 7044514

@koba04 koba04 force-pushed the add-test-for-non-passive-event-handlers branch from c14ed86 to 7044514 Compare August 20, 2020 11:17
@gaearon gaearon merged commit 2ada4bd into facebook:master Aug 24, 2020
@gaearon
Copy link
Collaborator

gaearon commented Aug 24, 2020

thx

@koba04 koba04 deleted the add-test-for-non-passive-event-handlers branch August 24, 2020 14:04
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants