Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move MS Windows build to CircleCI" #18302

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 13, 2020

I'm reverting this because it slowed our CI times from ~6 minutes to ~23 minutes. That's because it runs the build command without concurrency.

I don't remember why the Windows jobs exist. I can see why testing on a Windows machine is useful, but I don't think we should have to build the artifacts on Windows. We could re-use the artifacts from the normal build job.

Let's figure it out then re-land.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 13, 2020
@acdlite
Copy link
Collaborator Author

acdlite commented Mar 13, 2020

cc: @wittgenst

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7f8ffe:

Sandbox Source
cranky-hodgkin-znf3q Configuration

@sizebot
Copy link

sizebot commented Mar 13, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against b7f8ffe

@sizebot
Copy link

sizebot commented Mar 13, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against b7f8ffe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants