Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ReactVersion from CJS to ES module #18181

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Change ReactVersion from CJS to ES module #18181

merged 1 commit into from
Feb 28, 2020

Conversation

sebmarkbage
Copy link
Collaborator

We need this to get rid of CJS in the build tool chain.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 28, 2020
threepointone
threepointone approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2easy4me

gaearon
gaearon approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there some place where we did a CJS require or JSON parse to it? I thought there was.

@bvaughn
Copy link
Contributor

bvaughn commented Feb 28, 2020 •
edited
Loading

scripts/tasks/version-check.js requires this file, yes. It's used by scripts/release/utils.js, which is used by scripts/release/ci-update-package-versions so...presumably this PR will fail?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 28, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e51d205:

Sandbox Source
eloquent-kowalevski-2dhw1 Configuration

@sizebot
Copy link

sizebot commented Feb 28, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against e51d205

@sizebot
Copy link

sizebot commented Feb 28, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against e51d205

@sebmarkbage
Copy link
Collaborator Author

That script doesn't work on master because /package.json doesn't have a version. Fixed it.

@sebmarkbage sebmarkbage merged commit 4469700 into facebook:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@threepointone threepointone threepointone approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebmarkbage @bvaughn @sizebot @threepointone @gaearon @facebook-github-bot