Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warnings #18135

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Remove unnecessary warnings #18135

merged 1 commit into from
Feb 27, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 26, 2020

These don't seem particularly useful anymore.

  • Shady DOM: too niche
  • setState in getChildContext: too niche and lets us simplify some spread out code
  • maxDuration: gone, never stable

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 26, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 602cb74:

Sandbox Source
musing-minsky-tzywk Configuration

@sizebot
Copy link

sizebot commented Feb 26, 2020

Details of bundled changes.

Comparing: 60016c4...602cb74

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.7 KB 123.7 KB 38.58 KB 38.56 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.61 KB 3.61 KB 1.37 KB 1.37 KB UMD_DEV
ReactDOM-dev.js -0.2% -0.1% 894.37 KB 892.91 KB 199.61 KB 199.43 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 53.69 KB 53.69 KB 14.01 KB 14.01 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.25 KB 121.25 KB 38.11 KB 38.11 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 138.16 KB 138.16 KB 35.19 KB 35.19 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.22 KB 11.22 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 127.45 KB 127.45 KB 33.83 KB 33.83 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.36 KB 20.36 KB 7.45 KB 7.45 KB NODE_PROD
react-dom.development.js -0.2% -0.1% 914.29 KB 912.78 KB 200.19 KB 199.95 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.75 KB 119.75 KB 38.22 KB 38.22 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.28 KB 10.28 KB 3.49 KB 3.49 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 123.4 KB 123.4 KB 39.38 KB 39.39 KB UMD_PROFILING
react-dom.development.js -0.2% -0.1% 866.69 KB 865.26 KB 196.52 KB 196.32 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.9 KB 119.9 KB 37.45 KB 37.45 KB NODE_PROD
ReactDOM-prod.js 0.0% 🔺+0.1% 370.74 KB 370.74 KB 67.45 KB 67.51 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% +0.1% 381.95 KB 381.95 KB 69.57 KB 69.63 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.21 KB 3.21 KB 1.3 KB 1.3 KB NODE_DEV
react-dom-testing.development.js -0.2% -0.1% 887.91 KB 886.4 KB 195.74 KB 195.52 KB UMD_DEV
react-dom-testing.production.min.js 0.0% -0.1% 117.41 KB 117.41 KB 37.72 KB 37.69 KB UMD_PROD
ReactDOMTesting-dev.js -0.2% -0.1% 869.57 KB 868.12 KB 194.5 KB 194.32 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.94 KB 120.94 KB 38.9 KB 38.89 KB UMD_PROFILING
ReactDOMTesting-prod.js 0.0% 🔺+0.1% 368.76 KB 368.76 KB 67.35 KB 67.41 KB FB_WWW_PROD
react-dom-testing.development.js -0.2% -0.1% 841.37 KB 839.94 KB 192.18 KB 192 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% +0.1% 368.76 KB 368.76 KB 67.35 KB 67.41 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.57 KB 117.57 KB 37.05 KB 37.04 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.77 KB 20.77 KB 7.6 KB 7.6 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -0.2% -0.1% 539.01 KB 538.18 KB 112.86 KB 112.7 KB FB_WWW_DEV
react-art.development.js -0.1% -0.1% 636.01 KB 635.08 KB 133.68 KB 133.5 KB UMD_DEV
react-art.development.js -0.2% -0.1% 536.49 KB 535.62 KB 114.99 KB 114.83 KB NODE_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.2% -0.1% 554.6 KB 553.68 KB 115.42 KB 115.26 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.14 KB 71.14 KB 21.62 KB 21.62 KB UMD_PROD
react-test-renderer.development.js -0.2% -0.1% 524.92 KB 524.05 KB 113.1 KB 112.94 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 70.95 KB 70.95 KB 21.3 KB 21.3 KB NODE_PROD
ReactTestRenderer-dev.js -0.2% -0.1% 551.81 KB 550.9 KB 116.23 KB 116.07 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.27 KB 39.27 KB 9.86 KB 9.86 KB UMD_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js -0.1% -0.1% 615.82 KB 614.91 KB 132.76 KB 132.6 KB RN_FB_DEV
ReactNativeRenderer-dev.js -0.1% -0.1% 630.69 KB 629.77 KB 136.53 KB 136.37 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% -0.0% 264.41 KB 264.41 KB 46.03 KB 46.03 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.1% -0.1% 633.66 KB 632.75 KB 136.92 KB 136.76 KB RN_FB_DEV
ReactFabric-dev.js -0.1% -0.1% 612.94 KB 612.03 KB 132.38 KB 132.22 KB RN_OSS_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js -0.2% -0.1% 553.05 KB 552.18 KB 116.97 KB 116.82 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% 🔺+0.1% 2.81 KB 2.81 KB 1.21 KB 1.21 KB NODE_PROD
react-reconciler.development.js -0.2% -0.1% 575.12 KB 574.25 KB 121.02 KB 120.84 KB NODE_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against 602cb74

@sizebot
Copy link

sizebot commented Feb 26, 2020

Details of bundled changes.

Comparing: 60016c4...602cb74

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js 0.0% +0.1% 405.88 KB 405.88 KB 73.83 KB 73.87 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.01 KB 117.01 KB 36.92 KB 36.91 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.07 KB 59.07 KB 14.75 KB 14.75 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.7 KB 120.7 KB 37.97 KB 37.97 KB NODE_PROFILING
react-dom.development.js -0.2% -0.1% 885.6 KB 884.1 KB 195.2 KB 194.99 KB UMD_DEV
react-dom-server.browser.development.js 0.0% 0.0% 136.57 KB 136.57 KB 34.98 KB 34.98 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.17 KB 1.17 KB 676 B 677 B NODE_PROD
react-dom.production.min.js 0.0% -0.0% 115.85 KB 115.85 KB 37.08 KB 37.07 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 119.38 KB 119.38 KB 38.28 KB 38.29 KB UMD_PROFILING
ReactDOMTesting-dev.js -0.2% -0.1% 895.79 KB 894.24 KB 199.82 KB 199.59 KB FB_WWW_DEV
react-dom.development.js -0.2% -0.1% 839.19 KB 837.76 KB 191.61 KB 191.42 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 🔺+0.1% 381.65 KB 381.65 KB 69.4 KB 69.44 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 125.94 KB 125.94 KB 33.61 KB 33.61 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.93 KB 115.93 KB 36.45 KB 36.44 KB NODE_PROD
react-dom-testing.development.js -0.2% -0.1% 885.56 KB 884.05 KB 195.47 KB 195.25 KB UMD_DEV
ReactDOMTesting-profiling.js 0.0% +0.1% 381.65 KB 381.65 KB 69.4 KB 69.44 KB FB_WWW_PROFILING
react-dom.profiling.min.js 0.0% -0.0% 119.61 KB 119.61 KB 37.51 KB 37.5 KB NODE_PROFILING
react-dom-testing.production.min.js 0.0% -0.1% 116.89 KB 116.89 KB 37.59 KB 37.56 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.19 KB 1.19 KB 699 B 700 B UMD_PROD
ReactDOM-dev.js -0.2% -0.1% 936.45 KB 934.9 KB 208.25 KB 208.04 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% 0.0% 120.42 KB 120.42 KB 38.76 KB 38.76 KB UMD_PROFILING
ReactDOM-prod.js 0.0% 🔺+0.1% 394.59 KB 394.59 KB 71.68 KB 71.72 KB FB_WWW_PROD
react-dom-testing.development.js -0.2% -0.1% 839.13 KB 837.69 KB 191.92 KB 191.73 KB NODE_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.8 KB 48.8 KB 11.14 KB 11.14 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.68 KB 53.68 KB 14 KB 14 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.2 KB 11.2 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.31 KB 20.31 KB 7.52 KB 7.53 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js -0.1% -0.1% 612.93 KB 612.01 KB 132.37 KB 132.21 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% -0.0% 264.05 KB 264.05 KB 45.95 KB 45.95 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js -0.1% -0.1% 630.67 KB 629.76 KB 136.53 KB 136.36 KB RN_OSS_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js -0.2% -0.1% 553.04 KB 552.17 KB 116.97 KB 116.81 KB NODE_DEV
react-reconciler.development.js -0.2% -0.1% 554.36 KB 553.49 KB 117.1 KB 116.95 KB NODE_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.1% 616.83 KB 615.91 KB 130.26 KB 130.1 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 104.06 KB 104.06 KB 31.5 KB 31.49 KB UMD_PROD
react-art.development.js -0.2% -0.1% 518.06 KB 517.2 KB 111.54 KB 111.38 KB NODE_DEV
ReactART-dev.js -0.2% -0.2% 565.6 KB 564.68 KB 118.35 KB 118.16 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.production.min.js 0.0% -0.0% 70.92 KB 70.92 KB 21.28 KB 21.28 KB NODE_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 32.11 KB 32.11 KB 8.41 KB 8.4 KB NODE_DEV
react-test-renderer.development.js -0.2% -0.1% 554.58 KB 553.65 KB 115.41 KB 115.25 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.11 KB 71.11 KB 21.61 KB 21.61 KB UMD_PROD
react-test-renderer.development.js -0.2% -0.1% 524.89 KB 524.03 KB 113.09 KB 112.93 KB NODE_DEV
ReactTestRenderer-dev.js -0.2% -0.1% 551.8 KB 550.89 KB 116.23 KB 116.06 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.26 KB 39.26 KB 9.85 KB 9.85 KB UMD_DEV

Size changes (stable)

Generated by 🚫 dangerJS against 602cb74

@gaearon gaearon merged commit 849e832 into facebook:master Feb 27, 2020
acdlite pushed a commit to acdlite/react that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants