Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further pre-requisite changes to plugin event system #18083

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Further pre-requisite changes to plugin event system #18083

merged 1 commit into from
Feb 20, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Feb 20, 2020 •
edited
Loading

This PR contains the following changes:

  • Adds some changes requested in comments from follow ups in Add container to event listener signature #18075, specifcally repositioning the argument container.
  • Adds support for SelectEventPlugin.js to take an eventual container
  • Rename dispatchEventForPluginEventSystem to dispatchEventForLegacyPluginEventSystem
  • Tweaked SyntheticEvent types
  • Refactored some logic in event replaying to allow for both container and document to be passed through, enabling further code paths for the modern event system

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 20, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 20, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trueadm trueadm force-pushed the react-roots-phase3 branch 2 times, most recently from 6c8bbdf to d4876e6 Compare February 20, 2020 00:22
@sizebot
Copy link

sizebot commented Feb 20, 2020 •
edited
Loading

Details of bundled changes.

Comparing: b6c94d6...8405460

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js +0.1% +0.1% 408.56 KB 408.86 KB 74.28 KB 74.33 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.15 KB 117.16 KB 37.05 KB 37.04 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.72 KB 58.72 KB 15.35 KB 15.35 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.83 KB 120.83 KB 38.13 KB 38.12 KB NODE_PROFILING
react-dom.development.js 0.0% 0.0% 969.96 KB 970.13 KB 217.89 KB 217.92 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 116.04 KB 116.04 KB 37.24 KB 37.24 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 20 KB 20 KB 7.4 KB 7.4 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.56 KB 119.57 KB 38.4 KB 38.4 KB UMD_PROFILING
ReactDOMTesting-dev.js 0.0% 0.0% 989.76 KB 989.95 KB 218.15 KB 218.17 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 964.04 KB 964.21 KB 216.25 KB 216.28 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 383.81 KB 384.1 KB 69.73 KB 69.77 KB FB_WWW_PROD
react-dom.production.min.js 0.0% -0.0% 116.08 KB 116.08 KB 36.56 KB 36.56 KB NODE_PROD
react-dom-testing.development.js 0.0% 0.0% 966.79 KB 966.96 KB 216.73 KB 216.76 KB UMD_DEV
ReactDOMTesting-profiling.js +0.1% +0.1% 383.81 KB 384.1 KB 69.73 KB 69.77 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.93 KB 19.93 KB 7.39 KB 7.39 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 119.75 KB 119.75 KB 37.66 KB 37.65 KB NODE_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.07 KB 117.08 KB 37.72 KB 37.72 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 702 B 703 B UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 991.21 KB 991.4 KB 218.6 KB 218.62 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.6 KB 120.6 KB 38.88 KB 38.88 KB UMD_PROFILING
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 397.23 KB 397.53 KB 72.18 KB 72.23 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% 0.0% 960.87 KB 961.05 KB 215.09 KB 215.12 KB NODE_DEV
react-dom-test-utils.development.js 0.0% 0.0% 55.98 KB 55.98 KB 15.78 KB 15.78 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.21 KB 11.21 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.25 KB 54.25 KB 15.46 KB 15.47 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 8405460

@sizebot
Copy link

sizebot commented Feb 20, 2020 •
edited
Loading

Details of bundled changes.

Comparing: b6c94d6...8405460

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 123.81 KB 123.81 KB 38.73 KB 38.73 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 990.26 KB 990.46 KB 218.29 KB 218.31 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.36 KB 121.36 KB 38.26 KB 38.26 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 11.23 KB 11.23 KB 4.17 KB 4.17 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.1% 11 KB 11 KB 4.11 KB 4.1 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 969.98 KB 970.15 KB 217.9 KB 217.93 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.96 KB 119.96 KB 38.34 KB 38.34 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 123.59 KB 123.59 KB 39.52 KB 39.51 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 964.06 KB 964.23 KB 216.27 KB 216.3 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.43 KB 58.43 KB 15.28 KB 15.28 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 120.02 KB 120.03 KB 37.58 KB 37.58 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.99 KB 9.99 KB 3.38 KB 3.38 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 373.6 KB 373.9 KB 67.86 KB 67.9 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 384.9 KB 385.2 KB 69.92 KB 69.96 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 641 B 642 B NODE_PROD
react-dom-testing.development.js 0.0% 0.0% 966.82 KB 966.99 KB 216.74 KB 216.77 KB UMD_DEV
react-dom-testing.production.min.js 0.0% -0.0% 117.6 KB 117.61 KB 37.88 KB 37.88 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 989.77 KB 989.96 KB 218.16 KB 218.18 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.13 KB 121.13 KB 39.03 KB 39.02 KB UMD_PROFILING
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 371.5 KB 371.8 KB 67.65 KB 67.69 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% 0.0% 960.9 KB 961.07 KB 215.11 KB 215.13 KB NODE_DEV
ReactDOMTesting-profiling.js +0.1% +0.1% 371.5 KB 371.8 KB 67.65 KB 67.69 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.68 KB 117.69 KB 37.18 KB 37.17 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.79 KB 20.79 KB 7.62 KB 7.62 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 8405460

@trueadm trueadm merged commit 3f85d53 into facebook:master Feb 20, 2020
@trueadm trueadm deleted the react-roots-phase3 branch February 20, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@gaearon gaearon Awaiting requested review from gaearon

@bvaughn bvaughn Awaiting requested review from bvaughn

@threepointone threepointone Awaiting requested review from threepointone

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trueadm @sizebot @sebmarkbage @necolas @facebook-github-bot