Disable classic features in the modern WWW build #18013

gaearon · 2020-02-10T20:36:09Z

Builds on #18009 + #18012

This drops a bunch of features from the WWW modern builds. I set it to pretty aggressive so we can try that and see what we have to revert.

No more forked entry point. Same ReactDOM as the rest of the world.
No user timings.
No EventListener wrapping.
No legacy context.
No textarea children.
No renderSubtree.
No unstable_ prefix for createPortal.
No maps as children.
No findDOMNode, render, hydrate, unmountComponentAtNode.

See individual commits for closer details.

For example, ReactDOM rather than ReactDOMFB.

This doesn't change any of them yet.

codesandbox-ci · 2020-02-10T20:39:04Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a11ab3:

Sandbox	Source
delicate-dew-3t5dn	Configuration

sizebot · 2020-02-10T20:42:37Z

Details of bundled changes.

Comparing: ab7b83a...0a11ab3

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.profiling.min.js	+0.1%	0.0%	123.58 KB	123.67 KB	39.57 KB	39.58 KB	UMD_PROFILING
react-dom-test-utils.production.min.js	0.0%	-0.0%	10.99 KB	10.99 KB	4.1 KB	4.1 KB	NODE_PROD
react-dom.development.js	0.0%	0.0%	959.23 KB	959.55 KB	215.41 KB	215.47 KB	NODE_DEV
ReactDOMTesting-dev.js	0.0%	0.0%	985.25 KB	985.58 KB	217.47 KB	217.53 KB	FB_WWW_DEV
ReactDOMModern-dev.js	n/a	n/a	0 B	985.69 KB	0 B	217.55 KB	FB_WWW_MODERN_DEV
react-dom-unstable-native-dependencies.development.js	0.0%	-0.0%	60.93 KB	60.93 KB	16.08 KB	16.08 KB	UMD_DEV
ReactDOMModern-prod.js	n/a	n/a	0 B	369.59 KB	0 B	67.15 KB	FB_WWW_MODERN_PROD
react-dom-unstable-native-dependencies.production.min.js	0.0%	-0.0%	10.25 KB	10.25 KB	3.47 KB	3.47 KB	UMD_PROD
react-dom-server.browser.development.js	0.0%	0.0%	135.26 KB	135.26 KB	35.92 KB	35.92 KB	NODE_DEV
ReactDOMModern-profiling.js	n/a	n/a	0 B	380.82 KB	0 B	69.15 KB	FB_WWW_MODERN_PROFILING
react-dom-server.browser.production.min.js	0.0%	-0.0%	20.39 KB	20.39 KB	7.47 KB	7.47 KB	NODE_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	-0.0%	60.63 KB	60.63 KB	16 KB	16 KB	NODE_DEV
react-dom-testing.development.js	0.0%	0.0%	962.56 KB	962.89 KB	216.09 KB	216.16 KB	UMD_DEV
react-dom-unstable-native-dependencies.production.min.js	0.0%	-0.0%	9.99 KB	9.99 KB	3.38 KB	3.38 KB	NODE_PROD
react-dom-testing.production.min.js	🔺+0.1%	0.0%	117.6 KB	117.69 KB	37.9 KB	37.92 KB	UMD_PROD
react-dom-test-utils.development.js	0.0%	-0.0%	55.39 KB	55.39 KB	15.59 KB	15.59 KB	UMD_DEV
react-dom-testing.profiling.min.js	+0.1%	+0.1%	121.12 KB	121.21 KB	39.04 KB	39.07 KB	UMD_PROFILING
react-dom-test-utils.production.min.js	0.0%	-0.0%	11.21 KB	11.21 KB	4.17 KB	4.16 KB	UMD_PROD
react-dom-testing.development.js	0.0%	0.0%	956.65 KB	956.97 KB	214.4 KB	214.46 KB	NODE_DEV
react-dom.development.js	0.0%	0.0%	965.14 KB	965.47 KB	217.07 KB	217.13 KB	UMD_DEV
react-dom-testing.production.min.js	🔺+0.1%	0.0%	117.69 KB	117.78 KB	37.25 KB	37.26 KB	NODE_PROD
ReactDOMServer-prod.js	0.0%	-0.0%	48.99 KB	48.99 KB	11.18 KB	11.18 KB	FB_WWW_PROD
react-dom.production.min.js	🔺+0.1%	0.0%	119.94 KB	120.03 KB	38.42 KB	38.43 KB	UMD_PROD
react-dom-test-utils.development.js	0.0%	-0.0%	53.66 KB	53.66 KB	15.27 KB	15.27 KB	NODE_DEV
react-dom-testing.profiling.min.js	+0.1%	0.0%	121.37 KB	121.46 KB	38.36 KB	38.37 KB	NODE_PROFILING
react-dom.production.min.js	🔺+0.1%	🔺+0.1%	120.03 KB	120.12 KB	37.66 KB	37.68 KB	NODE_PROD
ReactDOMTesting-prod.js	0.0%	0.0%	340.91 KB	341.02 KB	62.23 KB	62.25 KB	FB_WWW_PROD
react-dom.profiling.min.js	+0.1%	+0.1%	123.81 KB	123.9 KB	38.77 KB	38.79 KB	NODE_PROFILING
ReactDOMTesting-profiling.js	0.0%	0.0%	351.69 KB	351.8 KB	64.18 KB	64.19 KB	FB_WWW_PROFILING
react-dom-unstable-fizz.browser.production.min.js	0.0%	-0.1%	1.21 KB	1.21 KB	711 B	710 B	UMD_PROD
react-dom-unstable-fizz.node.development.js	0.0%	+0.1%	4.42 KB	4.42 KB	1.65 KB	1.65 KB	NODE_DEV
ReactDOM-dev.js	0.0%	-0.2%	986.59 KB	986.89 KB	218.32 KB	217.95 KB	FB_WWW_DEV
ReactDOM-prod.js	-0.0%	-0.5%	393.39 KB	393.36 KB	71.92 KB	71.53 KB	FB_WWW_PROD
react-dom-server.browser.development.js	0.0%	0.0%	139.32 KB	139.32 KB	36.94 KB	36.94 KB	UMD_DEV
react-dom-unstable-fizz.browser.production.min.js	0.0%	-0.2%	1.05 KB	1.05 KB	642 B	641 B	NODE_PROD
ReactDOM-profiling.js	-0.0%	-0.6%	404.64 KB	404.61 KB	74.08 KB	73.64 KB	FB_WWW_PROFILING
react-dom-server.browser.production.min.js	0.0%	-0.0%	20.46 KB	20.46 KB	7.5 KB	7.5 KB	UMD_PROD
react-dom-server.node.development.js	0.0%	0.0%	136.37 KB	136.37 KB	36.14 KB	36.15 KB	NODE_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 0a11ab3

sizebot · 2020-02-10T20:42:45Z

Details of bundled changes.

Comparing: ab7b83a...0a11ab3

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom-test-utils.development.js	0.0%	-0.0%	53.65 KB	53.65 KB	15.27 KB	15.27 KB	NODE_DEV
react-dom.production.min.js	0.0%	0.0%	116.03 KB	116.03 KB	37.29 KB	37.29 KB	UMD_PROD
react-dom-testing.development.js	0.0%	0.0%	956.62 KB	956.95 KB	214.39 KB	214.45 KB	NODE_DEV
react-dom.profiling.min.js	0.0%	0.0%	119.55 KB	119.55 KB	38.45 KB	38.45 KB	UMD_PROFILING
react-dom-testing.production.min.js	0.0%	-0.0%	117.16 KB	117.16 KB	37.11 KB	37.11 KB	NODE_PROD
react-dom.development.js	0.0%	0.0%	959.2 KB	959.53 KB	215.39 KB	215.45 KB	NODE_DEV
react-dom-testing.profiling.min.js	0.0%	-0.0%	120.84 KB	120.84 KB	38.21 KB	38.21 KB	NODE_PROFILING
react-dom.production.min.js	0.0%	-0.0%	116.09 KB	116.09 KB	36.63 KB	36.63 KB	NODE_PROD
react-dom-unstable-fizz.browser.production.min.js	0.0%	-0.1%	1.2 KB	1.2 KB	703 B	702 B	UMD_PROD
react-dom.profiling.min.js	0.0%	-0.0%	119.76 KB	119.76 KB	37.74 KB	37.74 KB	NODE_PROFILING
react-dom-server.browser.development.js	0.0%	0.0%	139.3 KB	139.3 KB	36.94 KB	36.94 KB	UMD_DEV
react-dom-server.browser.production.min.js	0.0%	-0.0%	20 KB	20 KB	7.4 KB	7.4 KB	UMD_PROD
react-dom-unstable-fizz.browser.production.min.js	0.0%	-0.2%	1.04 KB	1.04 KB	634 B	633 B	NODE_PROD
react-dom-server.browser.development.js	0.0%	0.0%	135.23 KB	135.23 KB	35.91 KB	35.91 KB	NODE_DEV
react-dom-test-utils.development.js	0.0%	0.0%	55.38 KB	55.38 KB	15.59 KB	15.59 KB	UMD_DEV
react-dom-test-utils.production.min.js	0.0%	-0.0%	11.2 KB	11.2 KB	4.16 KB	4.16 KB	UMD_PROD
react-dom-test-utils.production.min.js	0.0%	-0.0%	10.97 KB	10.97 KB	4.09 KB	4.09 KB	NODE_PROD
react-dom-unstable-fizz.node.development.js	0.0%	+0.1%	4.4 KB	4.4 KB	1.64 KB	1.64 KB	NODE_DEV
react-dom-unstable-native-dependencies.development.js	0.0%	-0.0%	60.92 KB	60.92 KB	16.07 KB	16.07 KB	UMD_DEV
react-dom-server.node.development.js	0.0%	0.0%	136.34 KB	136.34 KB	36.14 KB	36.14 KB	NODE_DEV
react-dom-testing.development.js	0.0%	0.0%	962.54 KB	962.87 KB	216.08 KB	216.14 KB	UMD_DEV
react-dom-testing.production.min.js	0.0%	-0.0%	117.06 KB	117.06 KB	37.75 KB	37.75 KB	UMD_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	-0.0%	60.62 KB	60.62 KB	15.99 KB	15.99 KB	NODE_DEV
react-dom.development.js	0.0%	0.0%	965.12 KB	965.45 KB	217.05 KB	217.11 KB	UMD_DEV
react-dom-testing.profiling.min.js	0.0%	0.0%	120.59 KB	120.59 KB	38.93 KB	38.94 KB	UMD_PROFILING

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 0a11ab3

trueadm · 2020-02-10T20:59:18Z

packages/shared/forks/ReactFeatureFlags.www-modern.js

+  throw new Error('Not implemented.');
+}
+
+export const enableDeprecatedFlareAPI = true;


Can we add a comment to group the two sets up more? I’m worried people will add to the bottom of this list and it will get muddled up otherwise.

This is 100% copy paste from the other file. I agree we should clean it up but let's do this separately from this PR.

Sounds good.

This field doesn't exist without User Timing.

gaearon · 2020-02-25T14:47:23Z

We did this differently.

gaearon added 6 commits February 10, 2020 19:52

Move getIsHydrating from FB fork to Experimental flag

a73fbc3

Add FB_WWW_MODERN bundle types

cef433b

Use unforked entry points for modern builds

6b32ea0

For example, ReactDOM rather than ReactDOMFB.

Only use EventListener shim in classic WWW builds

b390105

Fork feature flags for modern and classic WWW

3899446

This doesn't change any of them yet.

Disable a bunch of classic features for modern builds

c3d4f6a

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 10, 2020

Add a flag to disable legacy ReactDOM APIs and set it for modern builds

4c8e018

gaearon force-pushed the such-modern branch from a238d04 to 4c8e018 Compare February 10, 2020 20:55

trueadm reviewed Feb 10, 2020

View reviewed changes

Put field assignment behind a condition

0a11ab3

This field doesn't exist without User Timing.

trueadm approved these changes Feb 10, 2020

View reviewed changes

gaearon mentioned this pull request Feb 12, 2020

Add Modern WWW build #18028

Merged

gaearon closed this Feb 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable classic features in the modern WWW build #18013

Disable classic features in the modern WWW build #18013

gaearon commented Feb 10, 2020 •

edited

Loading

codesandbox-ci bot commented Feb 10, 2020 •

edited

Loading

sizebot commented Feb 10, 2020 •

edited

Loading

react-dom

sizebot commented Feb 10, 2020 •

edited

Loading

react-dom

trueadm Feb 10, 2020

gaearon Feb 10, 2020

trueadm Feb 10, 2020

gaearon commented Feb 25, 2020

Disable classic features in the modern WWW build #18013

Disable classic features in the modern WWW build #18013

Conversation

gaearon commented Feb 10, 2020 • edited Loading

Builds on #18009 + #18012

codesandbox-ci bot commented Feb 10, 2020 • edited Loading

sizebot commented Feb 10, 2020 • edited Loading

react-dom

Size changes (experimental)

sizebot commented Feb 10, 2020 • edited Loading

react-dom

Size changes (stable)

trueadm Feb 10, 2020

Choose a reason for hiding this comment

gaearon Feb 10, 2020

Choose a reason for hiding this comment

trueadm Feb 10, 2020

Choose a reason for hiding this comment

gaearon commented Feb 25, 2020

gaearon commented Feb 10, 2020 •

edited

Loading

codesandbox-ci bot commented Feb 10, 2020 •

edited

Loading

sizebot commented Feb 10, 2020 •

edited

Loading

sizebot commented Feb 10, 2020 •

edited

Loading