Remove renderPhaseUpdates Map #17484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b384dd1:
|
Details of bundled changes.Comparing: be603f5...b384dd1 react-reconciler
react-dom
react-art
react-test-renderer
react-native-renderer
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.2% Size changes (stable) |
Details of bundled changes.Comparing: be603f5...b384dd1 react-native-renderer
react-test-renderer
react-dom
react-art
react-reconciler
Size changes (experimental) |
sebmarkbage
force-pushed
the
hook-rerender
branch
from
e2a1384
to
3f3c8b4
Compare
|
I should also make the infinite loop error use a dispatcher: #17480 (comment) |
sebmarkbage
force-pushed
the
hook-rerender
branch
from
3f3c8b4
to
0f85d01
Compare
Inside |
acdlite
force-pushed
the
hook-rerender
branch
from
0f85d01
to
6388040
Compare
When aborting a render, we also need to throw out render phase updates. Remove the updates from the queues so they do not persist to the next render. We already did a single pass through the whole list of hooks, so we know that any pending updates must have been dispatched during the render phase. The ones that were dispatched before we started rendering were already transferred to the current hook's queue.
|
Fixed the todo and merged after discussing out of band. |
gaearon
added a commit
that referenced
this pull request
Dec 16, 2019
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Dec 16, 2019
Follow up to facebook#17484, which was reverted due to a bug found in www.
sebmarkbage
commented
Dec 16, 2019
| // It's also called inside mountIndeterminateComponent if we determine the | ||
| // component is a module-style component. | ||
| if (didScheduleRenderPhaseUpdate) { | ||
| const current = (currentlyRenderingFiber: any).alternate; |
There was a problem hiding this comment.
@acdlite What if this is render phase updates during initial mount?
There was a problem hiding this comment.
It doesn't matter then because either the whole fiber will get thrown out or it will be cloned again. Except in legacy mode goddamn it. I'll add a test in the other PR.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Dec 19, 2019
Follow up to facebook#17484, which was reverted due to a bug found in www.
smagill
pushed a commit
to smagill/react
that referenced
this pull request
Dec 20, 2019
Follow up to facebook#17484, which was reverted due to a bug found in www.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jan 9, 2020
Follow up to facebook#17484, which was reverted due to a bug found in www.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jan 9, 2020
Follow up to facebook#17484, which was reverted due to a bug found in www.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jan 17, 2020
Follow up to facebook#17484, which was reverted due to a bug found in www.
acdlite
added a commit
that referenced
this pull request
Jan 17, 2020
* Remove renderPhaseUpdates Map Follow up to #17484, which was reverted due to a bug found in www. * Failing test: Dropped updates When resetting render phase updates after a throw, we should only clear the pending queue of hooks that were already processed. * Fix non-render-phase updates being dropped Detects if a queue has been processed by whether the hook was cloned. If we change the implementation to an array instead of a list, we'll need some other mechanism to determine whether the hook was processed. * Regression test: startTransition in render phase useTransition uses the state hook as part of its implementation, so we need to fork it in the dispatcher used for re-renders, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #17483
Now that we have a separate queue for recently added updates, we can use this queue to pick up the render phase updates. As long as we clear them before committing.
TODO: I believe this might have a bug if you suspend during the second update but before we get to process this particular Hook. Since the update would remain in the queue in this case.