Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scheduler] Delete old rAF implementation #17252

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Nov 1, 2019

We've been using the message loop version for a while. Time to delete.

We've been using the message loop version for a while. Time to delete.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 1, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b8b5b8:

Sandbox Source
hidden-tree-dkq11 Configuration

@sizebot
Copy link

sizebot commented Nov 1, 2019

Size changes (experimental)

React: size: -0.1%, gzip: -0.4%

Details of bundled changes.

Comparing: 6dc2734...0b8b5b8

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -3.9% -3.9% 117.69 KB 113.05 KB 29.88 KB 28.7 KB UMD_DEV
react.production.min.js -0.1% -0.4% 12.54 KB 12.52 KB 4.92 KB 4.9 KB UMD_PROD
React-prod.js 0.0% 0.0% 17.75 KB 17.75 KB 4.62 KB 4.62 KB FB_WWW_PROD
React-profiling.js 0.0% 0.0% 17.75 KB 17.75 KB 4.62 KB 4.62 KB FB_WWW_PROFILING
react.profiling.min.js -0.0% -0.1% 16.05 KB 16.05 KB 6.01 KB 6.01 KB UMD_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js -15.7% -16.0% 29.72 KB 25.06 KB 7.67 KB 6.45 KB NODE_DEV
scheduler.production.min.js -0.1% -0.1% 5.02 KB 5.01 KB 2.01 KB 2.01 KB NODE_PROD
Scheduler-dev.js -15.8% -16.0% 30.26 KB 25.49 KB 7.77 KB 6.53 KB FB_WWW_DEV
Scheduler-prod.js -0.6% -0.3% 12.61 KB 12.53 KB 3.06 KB 3.05 KB FB_WWW_PROD
Scheduler-profiling.js -0.4% -0.1% 17.19 KB 17.12 KB 3.96 KB 3.95 KB FB_WWW_PROFILING
scheduler-tracing.production.min.js 0.0% -1.3% 741 B 741 B 395 B 390 B NODE_PROD
scheduler-unstable_mock.development.js -0.0% -0.0% 22.67 KB 22.67 KB 5.39 KB 5.39 KB UMD_DEV
scheduler-tracing.profiling.min.js 0.0% -0.1% 3.26 KB 3.26 KB 1002 B 1001 B NODE_PROFILING
scheduler-unstable_mock.production.min.js 0.0% -0.0% 4.75 KB 4.75 KB 1.99 KB 1.99 KB UMD_PROD
scheduler-unstable_mock.development.js -0.0% -0.0% 22.48 KB 22.48 KB 5.33 KB 5.33 KB NODE_DEV
scheduler-unstable_mock.production.min.js 0.0% -0.1% 4.74 KB 4.74 KB 1.93 KB 1.93 KB NODE_PROD

Generated by 🚫 dangerJS against 0b8b5b8

@sizebot
Copy link

sizebot commented Nov 1, 2019

Size changes (stable)

React: size: -0.1%, gzip: -0.4%

Details of bundled changes.

Comparing: 6dc2734...0b8b5b8

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -3.9% -3.9% 117.67 KB 113.02 KB 29.87 KB 28.69 KB UMD_DEV
react.production.min.js -0.1% -0.4% 12.32 KB 12.31 KB 4.85 KB 4.83 KB UMD_PROD
react.profiling.min.js -0.0% -0.1% 15.83 KB 15.83 KB 5.94 KB 5.94 KB UMD_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler-unstable_mock.development.js -0.0% -0.1% 22.66 KB 22.66 KB 5.39 KB 5.38 KB UMD_DEV
scheduler-unstable_mock.production.min.js 0.0% -0.0% 4.73 KB 4.73 KB 1.98 KB 1.98 KB UMD_PROD
scheduler.development.js -15.7% -16.0% 29.71 KB 25.05 KB 7.67 KB 6.44 KB NODE_DEV
scheduler.production.min.js -0.1% -0.2% 5 KB 5 KB 2 KB 2 KB NODE_PROD
scheduler-unstable_mock.development.js -0.0% -0.0% 22.47 KB 22.47 KB 5.33 KB 5.33 KB NODE_DEV
scheduler-tracing.development.js 0.0% 0.0% 11.32 KB 11.32 KB 2.85 KB 2.86 KB NODE_DEV
scheduler-unstable_mock.production.min.js 0.0% -0.1% 4.72 KB 4.72 KB 1.92 KB 1.92 KB NODE_PROD
scheduler-tracing.production.min.js 0.0% -0.3% 728 B 728 B 383 B 382 B NODE_PROD
scheduler-tracing.profiling.min.js 0.0% -0.1% 3.25 KB 3.25 KB 993 B 992 B NODE_PROFILING

Generated by 🚫 dangerJS against 0b8b5b8

@acdlite acdlite merged commit a2e05b6 into facebook:master Nov 1, 2019
@adasq
Copy link
Contributor

adasq commented Feb 19, 2020

What is the reason of removing rAF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants